In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/906bee2200491141

Change Log Message

Estimate Points

Attached Files

method_name_not_string_error.patch [^] (1,524 bytes) 2010-10-10 07:28 [Show Content]

Index: kernel/utility/unit_config_reader.php
===================================================================
--- kernel/utility/unit_config_reader.php	(revision 13962)
+++ kernel/utility/unit_config_reader.php	(working copy)
@@ -441,7 +441,9 @@
 		$this->ParseConfigs();
 		$this->AfterConfigRead(false);
 		$this->processDynamicClones();
-		$this->retrieveCollections();
+
+		// don't call kUnitConfigReader::retrieveCollections since it
+		// will overwrite what we already have in kApplication class instance
 	}
 
 	/**
Index: units/site_domains/site_domain_eh.php
===================================================================
--- units/site_domains/site_domain_eh.php	(revision 13936)
+++ units/site_domains/site_domain_eh.php	(working copy)
@@ -17,18 +17,19 @@
 	class SiteDomainEventHandler extends kDBEventHandler {
 
 		/**
-		 * Allows to override standart permission mapping
+		 * Permission check override
 		 *
+		 * @param kEvent $event
 		 */
-		function mapPermissions()
+		function CheckPermission(&$event)
 		{
-			parent::mapPermissions();
+			if ($event->Name == 'OnItemBuild') {
+				// check permission without using $event->getSection(),
+				// so first cache rebuild won't lead to "ldefault_Name" field being used
+				return true;
+			}
 
-			$permissions = Array (
-				'OnItemBuild' => Array ('self' => true),
-			);
-
-			$this->permMapping = array_merge($this->permMapping, $permissions);
+			return parent::CheckPermission($event);
 		}
 
 		/**

method_name_not_string_error_v2.patch [^] (2,506 bytes) 2010-10-10 23:58 [Show Content]

Index: kernel/utility/debugger.php
===================================================================
--- kernel/utility/debugger.php	(revision 13956)
+++ kernel/utility/debugger.php	(working copy)
@@ -1222,7 +1222,7 @@
 						$Debugger.DOMViewerURL = '<?php echo constant('DBG_DOMVIEWER'); ?>';
 						$Debugger.EditorPath = '<?php echo defined('DBG_EDITOR') ? addslashes(DBG_EDITOR) : '' ?>';
 						$Debugger.DebugURL = '<?php echo $this->baseURL.'/debugger_responce.php?sid='.$this->rowSeparator.'&path='.urlencode($dbg_path); ?>';
-						$Debugger.EventURL = '<?php echo is_object($application->Factory) ? $application->HREF('dummy', '', Array ('pass' => 'm')) : ''; ?>';
+						$Debugger.EventURL = '<?php echo is_object($application->Factory) ? $application->HREF('dummy', '', Array ('pass' => 'm', '__NO_REWRITE__' => 1)) : ''; ?>';
 						<?php
 							if ($this->IsFatalError || (DBG_RAISE_ON_WARNINGS && $this->WarningCount)) {
 								echo '$Debugger.Toggle();';
Index: kernel/utility/unit_config_reader.php
===================================================================
--- kernel/utility/unit_config_reader.php	(revision 13962)
+++ kernel/utility/unit_config_reader.php	(working copy)
@@ -441,7 +441,9 @@
 		$this->ParseConfigs();
 		$this->AfterConfigRead(false);
 		$this->processDynamicClones();
-		$this->retrieveCollections();
+
+		// don't call kUnitConfigReader::retrieveCollections since it
+		// will overwrite what we already have in kApplication class instance
 	}
 
 	/**
Index: units/site_domains/site_domain_eh.php
===================================================================
--- units/site_domains/site_domain_eh.php	(revision 13936)
+++ units/site_domains/site_domain_eh.php	(working copy)
@@ -17,18 +17,19 @@
 	class SiteDomainEventHandler extends kDBEventHandler {
 
 		/**
-		 * Allows to override standart permission mapping
+		 * Permission check override
 		 *
+		 * @param kEvent $event
 		 */
-		function mapPermissions()
+		function CheckPermission(&$event)
 		{
-			parent::mapPermissions();
+			if ($event->Name == 'OnItemBuild') {
+				// check permission without using $event->getSection(),
+				// so first cache rebuild won't lead to "ldefault_Name" field being used
+				return true;
+			}
 
-			$permissions = Array (
-				'OnItemBuild' => Array ('self' => true),
-			);
-
-			$this->permMapping = array_merge($this->permMapping, $permissions);
+			return parent::CheckPermission($event);
 		}
 
 		/**

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	0000472	closed (5.1.0)	alex	Domain-based site auto-configuration
child of	0000107	closed (5.1.0)	alex	Implement "MemCached" functionality
child of	0000313	closed (5.0.1)	alex	Mod-rewrite listeners defined via OnAfterConfigRead event don't work

Notes
(0002882) Dmitry (manager) 2010-10-13 23:16	Tested good, please commit. Good, catch and fix - thanks!

(0002894) alex (manager) 2010-10-19 04:01	Fix committed to 5.1.x branch. Commit Message: Fixes 0000884: Fatal error "Method name must be a string" on home page after Memcached server restart

(0003020) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
In-Portal CMS: 5.1.x r13989 Timestamp: 2010-10-19 04:01:22 Author: alex [ Details ] [ Diff ]	Fixes 0000884: Fatal error "Method name must be a string" on home page after Memcached server restart
	mod - /in-portal/branches/5.1.x/core/kernel/utility/debugger.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/kernel/utility/unit_config_reader.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/site_domains/site_domain_eh.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003020
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-10-19 04:01	alex	Note Added: 0002894
2010-10-19 04:01	alex	Status	reviewed and tested => resolved
2010-10-19 04:01	alex	Fixed in Version	=> 5.1.1-B2
2010-10-19 04:01	alex	Resolution	open => fixed
2010-10-19 04:01	alex	Assigned To	!COMMUNITY => alex
2010-10-19 04:01	alex	Changeset attached	5.1.x r13989
2010-10-13 23:16	Dmitry	Note Added: 0002882
2010-10-13 23:16	Dmitry	Status	needs testing => reviewed and tested
2010-10-10 23:58	alex	File Added: method_name_not_string_error_v2.patch
2010-10-10 10:58	alex	Relationship added	child of 0000313
2010-10-10 10:20	alex	Relationship added	related to 0000472
2010-10-10 10:19	alex	Relationship added	child of 0000107
2010-10-10 07:30	alex	Assigned To	=> !COMMUNITY
2010-10-10 07:30	alex	Developer	=> alex
2010-10-10 07:30	alex	Status	active => needs testing
2010-10-10 07:30	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/906bee2200491141
2010-10-10 07:28	alex	New Issue
2010-10-10 07:28	alex	File Added: method_name_not_string_error.patch

Web Development by Intechnic

In-Portal Open Source CMS