In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000829

[In-Portal CMS] Front End

bug report

always

2010-08-20 16:39

2010-11-30 12:48

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.1-B1

Status

closed

Product Version

5.1.0

Target Version

5.1.1

Time Estimate

No estimate

Summary

0000829: Method RemovePersistentVar doesn't work for Guests

Description

In-Portal has 2 session types:

* one that stored user-related data until he perform logout or closes browser window
* other (persistent) that holds data between user login/logout times

We use current user ID to store data in persistent session. All non logged in users share same ID - "-2". To prevent persistent session data to be mixed we store persistent session variables into regular session table and they will be deleted once user closes browser window.

All seems ok, but there is a problem with data deletion from persistent session for non logged in users (guests) - it doesn't work.

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/477c7a635a6fee3f

Change Log Message

Estimate Points

0

method_removepersistentvar_doesnt_work_for_guest.patch [^] (617 bytes) 2010-08-20 16:39 [Show Content]

Index: session.php
===================================================================
--- session.php	(revision 13782)
+++ session.php	(working copy)
@@ -451,7 +451,11 @@
 
 		$user_id = $session->RecallVar('user_id');
 
-		if ($user_id != USER_GUEST) {
+		if ($user_id == USER_GUEST || $user_id === false) {
+			// -2 (when not logged in), false (when after u:OnLogout event)
+			$session->RemoveVar($var_name);
+		}
+		else {
 			$sql = 'DELETE FROM '.TABLE_PREFIX.'PersistantSessionData
 					WHERE PortalUserId = '.$user_id.' AND VariableName = '.$this->Conn->qstr($var_name);
 			$this->Conn->Query($sql);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0002666) Dmitry (manager) 2010-08-26 16:57	Reviewed and tested good. Please commit.

(0002712) alex (manager) 2010-08-28 16:04	Fix committed to 5.1.x branch. Commit Message: Fixes 0000829: Method RemovePersistentVar doesn't work for Guests

(0003072) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
In-Portal CMS: 5.1.x r13880 Timestamp: 2010-08-28 16:04:47 Author: alex [ Details ] [ Diff ]	Fixes 0000829: Method RemovePersistentVar doesn't work for Guests
	mod - /in-portal/branches/5.1.x/core/kernel/session/session.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003072
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-08-28 16:04	alex	Note Added: 0002712
2010-08-28 16:04	alex	Status	reviewed and tested => resolved
2010-08-28 16:04	alex	Fixed in Version	=> 5.1.1-B1
2010-08-28 16:04	alex	Resolution	open => fixed
2010-08-28 16:04	alex	Changeset attached	5.1.x r13880
2010-08-26 17:21	Dmitry	Target Version	5.1.1-B1 => 5.1.1
2010-08-26 16:57	Dmitry	Note Added: 0002666
2010-08-26 16:57	Dmitry	Assigned To	!COMMUNITY => alex
2010-08-26 16:57	Dmitry	Status	needs testing => reviewed and tested
2010-08-20 16:40	alex	Assigned To	=> !COMMUNITY
2010-08-20 16:40	alex	Developer	=> alex
2010-08-20 16:40	alex	Status	active => needs testing
2010-08-20 16:40	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/477c7a635a6fee3f
2010-08-20 16:39	alex	New Issue
2010-08-20 16:39	alex	File Added: method_removepersistentvar_doesnt_work_for_guest.patch

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group