In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/1d15f950f653cd7c

Change Log Message

Estimate Points

Attached Files

basic_group_permission_moved_to_general_tab.patch [^] (6,624 bytes) 2010-07-23 07:12 [Show Content]

Index: admin_templates/groups/groups_edit.tpl
===================================================================
--- admin_templates/groups/groups_edit.tpl	(revision 13756)
+++ admin_templates/groups/groups_edit.tpl	(working copy)
@@ -53,18 +53,44 @@
 <inp2:g_SaveWarning name="grid_save_warning"/>
 <inp2:g_ErrorWarning name="form_error_warning"/>
 
+<inp2:m_DefineElement name="old_permission_element" prefix="g-perm">
+	<tr class="<inp2:m_odd_even odd='edit-form-odd' even='edit-form-even'/>">
+		<td class="label-cell">
+			<inp2:m_phrase name="$label"/>:
+
+			<inp2:m_if check="m_IsDebugMode">
+				<br/><small style="color: gray;"><inp2:m_param name="perm_name"/></small>
+			</inp2:m_if>
+		</td>
+		<td class="control-mid">&nbsp;</td>
+		<td class="control-cell">
+	 		<input type="hidden" id="<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" name="<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" value="<inp2:{$prefix}_PermissionValue section_name="$section_name" perm_name="$perm_name"/>">
+			<input type="checkbox" align="absmiddle" id="_cb_<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" name="_cb_<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" <inp2:m_if check="{$prefix}_PermissionValue" section_name="$section_name" perm_name="$perm_name" value="1">checked</inp2:m_if> onchange="update_checkbox(this, document.getElementById('<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]'));">
+		</td>
+	</tr>
+</inp2:m_DefineElement>
+
+<inp2:g-perm_LoadPermissions/>
+
 <div id="scroll_container">
 	<table class="edit-form">
 		<inp2:m_RenderElement name="subsection" prefix="g" fields="GroupId,Name,FrontRegistration,Description,Enabled" title="!la_section_General!"/>
 			<inp2:m_RenderElement name="inp_id_label" prefix="g" field="GroupId" title="!la_fld_GroupId!"/>
 			<inp2:m_RenderElement name="inp_edit_box" prefix="g" field="Name" title="!la_fld_GroupName!"/>
 			<inp2:m_RenderElement name="inp_edit_checkbox" prefix="g" field="FrontRegistration" title="la_fld_FrontRegistration"/>
-			<inp2:m_RenderElement name="inp_edit_textarea" prefix="g" field="Description" title="!la_fld_Comments!" control_options="{max_height: 200}" rows="5" cols="30"/>
+			<inp2:m_RenderElement name="inp_edit_textarea" prefix="g" field="Description" title="!la_fld_Comments!" control_options="{max_height: 100}"/>
 
 			<inp2:m_if check="m_IsDebugMode">
 				<inp2:m_RenderElement name="inp_edit_radio" prefix="g" field="Enabled" title="!la_fld_Enabled!"/>
 			</inp2:m_if>
 
+			<inp2:m_if check="m_CheckPermission" permissions="in-portal:user_groups.advanced:manage_permissions" system="1">
+				<inp2:m_RenderElement name="subsection" title="la_section_BasicPermissions"/>
+					<inp2:m_RenderElement name="old_permission_element" section_name="in-portal:root" perm_name="LOGIN" label="la_PermName_Login_desc"/>
+					<inp2:m_RenderElement name="old_permission_element" section_name="in-portal:root" perm_name="ADMIN" label="la_PermName_Admin_desc"/>
+					<inp2:m_RenderElement name="old_permission_element" section_name="in-portal:root" perm_name="SYSTEM_ACCESS.READONLY" label="la_PermName_SystemAccess.ReadOnly_desc"/>
+			</inp2:m_if>
+
 			<inp2:m_RenderElement name="inp_edit_filler"/>
 	</table>
 </div>
Index: admin_templates/groups/permissions_selector.tpl
===================================================================
--- admin_templates/groups/permissions_selector.tpl	(revision 13756)
+++ admin_templates/groups/permissions_selector.tpl	(working copy)
@@ -45,23 +45,6 @@
 	</tr>
 </inp2:m_DefineElement>
 
-
-<inp2:m_DefineElement name="old_permission_element" prefix="g-perm">
-	<tr class="<inp2:m_odd_even odd="table-color1" even="table-color2"/>">
-		<td>
-			<inp2:m_phrase name="$label"/>
-
-			<inp2:m_if check="m_IsDebugMode">
-				<br/><small style="color: gray;"><inp2:m_param name="perm_name"/></small>
-			</inp2:m_if>
-		</td>
-		<td>
-	 		<input type="hidden" id="<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" name="<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" value="<inp2:{$prefix}_PermissionValue section_name="$section_name" perm_name="$perm_name"/>">
-			<input type="checkbox" align="absmiddle" id="_cb_<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" name="_cb_<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]" <inp2:m_if check="{$prefix}_PermissionValue" section_name="$section_name" perm_name="$perm_name" value="1">checked</inp2:m_if> onchange="update_checkbox(this, document.getElementById('<inp2:m_param name="prefix"/>[<inp2:m_param name="section_name"/>][<inp2:m_param name="perm_name"/>]'));">
-		</td>
-	</tr>
-</inp2:m_DefineElement>
-
 <inp2:g-perm_LoadPermissions/>
 
 <div id="scroll_container">
@@ -72,13 +55,8 @@
 			<td><inp2:m_phrase label="la_col_PermissionName"/></td>
 			<td><inp2:m_phrase label="la_col_PermissionValue"/></td>
 		</tr>
-		<inp2:m_if check="m_GetEquals" name="section_name" value="in-portal:root">
-			<inp2:m_RenderElement name="old_permission_element" section_name="in-portal:root" perm_name="LOGIN" label="lu_PermName_Login_desc"/>
-			<inp2:m_RenderElement name="old_permission_element" section_name="in-portal:root" perm_name="ADMIN" label="lu_PermName_Admin_desc"/>
-			<inp2:m_RenderElement name="old_permission_element" section_name="in-portal:root" perm_name="SYSTEM_ACCESS.READONLY" label="la_PermName_SystemAccess.ReadOnly_desc"/>
-		<inp2:m_else/>
-			<inp2:adm_ListSectionPermissions render_as="permission_element" type="1"/>
-		</inp2:m_if>
+
+		<inp2:adm_ListSectionPermissions render_as="permission_element" type="1"/>
 	</table>
 </div>
 
Index: units/admin/admin_config.php
===================================================================
--- units/admin/admin_config.php	(revision 13756)
+++ units/admin/admin_config.php	(working copy)
@@ -57,7 +57,7 @@
 				'icon'			=>	'site',
 				'label'			=>	$this->Application->ConfigValue('Site_Name'),
 				'url'			=>	Array ('t' => 'index', 'pass' => 'm', 'pass_section' => true, 'no_amp' => 1),
-				'permissions'	=>	Array ('advanced:admin_login', 'advanced:front_login'),
+				'permissions'	=>	Array (),
 				'priority'		=>	0,
 				'container'		=>	true,
 				'type'			=>	stTREE,

Relationships [ Relation Graph ] [ Dependency Graph ]

parent of

0000800

closed (5.1.1)

!COMMUNITY

Missing some advanced permission name phrases

Notes
(0002602) Dmitry (manager) 2010-07-23 10:31	Reviewed and tested.

(0002603) phil (developer) 2010-07-23 11:13	I tested on v510, the new menu appears on the general tab, but: - old menu is still present in the additionnel permissions section - even if I select a login option on general tab, this option appears de-selected in the old menu

(0002607) alex (manager) 2010-07-23 14:00	Reminder sent to: phil Old menu, as you call it (it's not menu at all actually) will be hidden once you "reset sections cache" (if this means anything to you) or if you re-install In-Portal.

(0002608) phil (developer) 2010-07-23 14:53	Reminder sent to: alex ok it doesn't appears anymore now... and yes your words means hopefully something to me ;-)

(0002718) alex (manager) 2010-08-28 16:34	Fix committed to 5.1.x branch. Commit Message: Fixes 0000799: Move basic group permissions to "General" tab

(0003066) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
In-Portal CMS: 5.1.x r13886 Timestamp: 2010-08-28 16:34:58 Author: alex [ Details ] [ Diff ]	Fixes 0000799: Move basic group permissions to "General" tab
	mod - /in-portal/branches/5.1.x/core/admin_templates/groups/groups_edit.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/admin_templates/groups/permissions_selector.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/install/english.lang	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/admin/admin_config.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003066
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-08-28 16:34	alex	Note Added: 0002718
2010-08-28 16:34	alex	Status	reviewed and tested => resolved
2010-08-28 16:34	alex	Fixed in Version	=> 5.1.1-B1
2010-08-28 16:34	alex	Resolution	open => fixed
2010-08-28 16:34	alex	Assigned To	!COMMUNITY => alex
2010-08-28 16:34	alex	Changeset attached	5.1.x r13886
2010-07-31 13:06	alex	Target Version	5.1.1-B1 => 5.1.1
2010-07-31 13:03	alex	Target Version	Icebox => 5.1.1-B1
2010-07-23 14:53	phil	Issue Monitored: alex
2010-07-23 14:53	phil	Note Added: 0002608
2010-07-23 14:00	alex	Note Added: 0002607
2010-07-23 11:13	phil	Note Added: 0002603
2010-07-23 10:31	Dmitry	Note Added: 0002602
2010-07-23 10:31	Dmitry	Status	needs testing => reviewed and tested
2010-07-23 07:17	alex	Relationship added	parent of 0000800
2010-07-23 07:12	alex	Assigned To	=> !COMMUNITY
2010-07-23 07:12	alex	Developer	=> alex
2010-07-23 07:12	alex	Status	active => needs testing
2010-07-23 07:12	alex	File Added: basic_group_permission_moved_to_general_tab.patch
2010-07-23 07:12	alex	Reporter	alex => phil
2010-07-23 07:12	alex	New Issue
2010-07-23 07:12	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/1d15f950f653cd7c

Web Development by Intechnic

In-Portal Open Source CMS