In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-dev/browse_thread/thread/dc757fc9ef0a76b8

Change Log Message

Estimate Points

Attached Files

form_message_core.patch [^] (4,987 bytes) 2010-06-25 13:49 [Show Content]

Index: admin_templates/categories/categories_tabs.tpl
===================================================================
--- admin_templates/categories/categories_tabs.tpl	(revision 13756)
+++ admin_templates/categories/categories_tabs.tpl	(working copy)
@@ -1,5 +1,5 @@
 <inp2:m_DefineElement name="grid_save_warning">
-	<table id="save_warning" width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table"<inp2:m_ifnot check="m_Param" name="display"> style="display: none;"</inp2:_ifnot>>
+	<table id="save_warning" width="100%" cellspacing="0" cellpadding="4" class="warning-table"<inp2:m_ifnot check="m_Param" name="display"> style="display: none;"</inp2:_ifnot>>
 		<tr>
 			<td valign="top" class="form-warning">
 				<inp2:m_phrase name="la_Warning_Save_Item"/>
Index: admin_templates/incs/form_blocks.tpl
===================================================================
--- admin_templates/incs/form_blocks.tpl	(revision 13756)
+++ admin_templates/incs/form_blocks.tpl	(working copy)
@@ -97,6 +97,16 @@
 	</inp2:m_if>
 </inp2:m_DefineElement>
 
+<inp2:m_DefineElement name="form_message" id="">
+	<table width="100%" cellspacing="0" cellpadding="4" class="warning-table"<inp2:m_if check="m_Param" name="id"> id="<inp2:m_Param name='id'/>"</inp2:m_if>>
+		<tr>
+			<td valign="top" class="form-warning">
+				<inp2:m_Param name="content"/>
+			</td>
+		</tr>
+	</table>
+</inp2:m_DefineElement>
+
 <inp2:m_DefineElement name="default_field_caption_element">
 	<label for="<inp2:m_param name='NamePrefix'/><inp2:{$prefix}_InputName field='$field'/>">
 		<span class="<inp2:m_if check='{$prefix}_HasError' field='$field'>error-cell</inp2:m_if>"><inp2:m_phrase label="$title"/></span></span><inp2:m_if check="{$prefix}_IsRequired" field="$field"><span class="field-required">&nbsp;*</span></inp2:m_if>:<inp2:m_if check="m_Param" name="hint_label"><span>&nbsp;<img src="<inp2:m_TemplatesBase/>/img/hint_icon.png" width="12" height="13" title="<inp2:m_Phrase label='$hint_label' html_escape='1'/>" alt="<inp2:m_Phrase label='$hint_label' html_escape='1'/>"/></inp2:m_if>
@@ -1065,12 +1075,8 @@
 </inp2:m_DefineElement>
 
 <inp2:m_DefineElement name="form_error_warning">
-	<table width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table">
-  		<tr>
-    		<td valign="top" class="form-warning">
-    			<inp2:m_phrase name="la_Warning_NewFormError"/><br/>
-    			<span id="error_msg_<inp2:m_Param name='prefix'/>" style="font-weight: bold"><br/></span>
-    		</td>
-  		</tr>
-	</table>
+	<inp2:m_RenderElement design="form_message" pass_params="1">
+		<inp2:m_Phrase name="la_Warning_NewFormError"/><br/>
+		<span id="error_msg_<inp2:m_Param name='prefix'/>" style="font-weight: bold;"><br/></span>
+    </inp2:m_RenderElement>
 </inp2:m_DefineElement>
Index: admin_templates/incs/grid_blocks.tpl
===================================================================
--- admin_templates/incs/grid_blocks.tpl	(revision 13756)
+++ admin_templates/incs/grid_blocks.tpl	(working copy)
@@ -500,13 +500,10 @@
 <inp2:m_include template="incs/menu_blocks"/>
 
 <inp2:m_DefineElement name="grid_save_warning">
-	<table width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table">
-  		<tr>
-    		<td valign="top" class="form-warning">
-    			<inp2:m_phrase name="la_Warning_Save_Item"/>
-    		</td>
-  		</tr>
-	</table>
+	<inp2:m_RenderElement design="form_message" pass_params="1">
+		<inp2:m_phrase name="la_Warning_Save_Item"/>
+    </inp2:m_RenderElement>
+
 	<script type="text/javascript">
 		$edit_mode = <inp2:m_if check="m_ParamEquals" name="edit_mode" value="1">true<inp2:m_else />false</inp2:m_if>;
 		if (Form) Form.Changed();
@@ -622,13 +619,9 @@
 
 	<inp2:{$PrefixSpecial}_SaveWarning name="grid_save_warning" pass_params="1"/>
 	<inp2:m_if check="{$PrefixSpecial}_SearchActive" grid="$grid">
-		<table width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table">
-	  		<tr>
-	    		<td valign="top" class="form-warning">
-	    			<inp2:m_phrase name="la_Warning_Filter"/>
-	    		</td>
-	  		</tr>
-		</table>
+		<inp2:m_RenderElement design="form_message" pass_params="1">
+			<inp2:m_phrase name="la_Warning_Filter"/>
+		</inp2:m_RenderElement>
 	</inp2:m_if>
 
 	<div id="grid_<inp2:m_Param name='PrefixSpecial'/>_container"></div>
@@ -799,13 +792,9 @@
 
 	<inp2:{$PrefixSpecial}_SaveWarning name="grid_save_warning" main_prefix="$main_prefix"/>
 	<inp2:m_if check="{$PrefixSpecial}_SearchActive" grid="$grid">
-		<table width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table" >
-	  		<tr>
-	    		<td valign="top" class="hint_red">
-	    			<inp2:m_phrase name="la_Warning_Filter"/>
-	    		</td>
-	  		</tr>
-		</table>
+		<inp2:m_RenderElement design="form_message" pass_params="1">
+	    	<inp2:m_phrase name="la_Warning_Filter"/>
+		</inp2:m_RenderElement>
 	</inp2:m_if>
 
 	<inp2:m_if check="m_ParamEquals" name="per_page" value="-1" inverse="1">

form_message_modules.patch [^] (3,096 bytes) 2010-06-25 13:50 [Show Content]

Index: in-commerce/admin_templates/orders/order_product_edit.tpl
===================================================================
--- in-commerce/admin_templates/orders/order_product_edit.tpl	(revision 13756)
+++ in-commerce/admin_templates/orders/order_product_edit.tpl	(working copy)
@@ -57,13 +57,9 @@
 	<input type="hidden" name="p_id" value="<inp2:p_Field name='ProductId'/>">
 
 	<inp2:m_if check="p_OptionsHaveError">
-		<table width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table">
-  		<tr>
-    		<td valign="top" class="hint_red">
-    			<inp2:p_OptionsError required="lu_comm_OptionsRequired" not_available="lu_comm_OptionsNotAvailable"/>
-    		</td>
-  		</tr>
-		</table>
+		<inp2:m_RenderElement design="form_message" pass_params="1">
+			<inp2:p_OptionsError required="lu_comm_OptionsRequired" not_available="lu_comm_OptionsNotAvailable"/>
+		</inp2:m_RenderElement>
 	</inp2:m_if>
 
 	<inp2:m_if check="p_FieldEquals" field="OptionsSelectionMode" value="1"> <!-- Listable options (combinations) -->
Index: in-commerce/admin_templates/orders/orders_edit_shipping.tpl
===================================================================
--- in-commerce/admin_templates/orders/orders_edit_shipping.tpl	(revision 13756)
+++ in-commerce/admin_templates/orders/orders_edit_shipping.tpl	(working copy)
@@ -70,14 +70,10 @@
 <inp2:ord_SaveWarning name="grid_save_warning"/>
 
 <inp2:m_if check="m_Recall" name="usps_errors">
-	<table width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table">
-  		<tr>
-    		<td valign="top" class="form-warning">
-    			<inp2:m_Recall name="usps_errors" />
-    			<inp2:m_RemoveVar name="usps_errors"/>
-    		</td>
-  		</tr>
-	</table>
+	<inp2:m_RenderElement design="form_message" pass_params="1">
+		<inp2:m_Recall name="usps_errors" />
+    	<inp2:m_RemoveVar name="usps_errors"/>
+	</inp2:m_RenderElement>
 </inp2:m_if>
 
 <inp2:ord_ErrorWarning name="form_error_warning"/>
Index: in-commerce/admin_templates/orders/orders_toship_list.tpl
===================================================================
--- in-commerce/admin_templates/orders/orders_toship_list.tpl	(revision 13756)
+++ in-commerce/admin_templates/orders/orders_toship_list.tpl	(working copy)
@@ -63,16 +63,12 @@
 </table>
 
 <inp2:m_DefineElement name="usps_errors">
-	<table width="100%" border="0" cellspacing="0" cellpadding="4" class="warning-table">
-  		<tr>
-    		<td valign="top" class="form-warning">
-    			Order: <inp2:m_Param name="order_number"/>. USPS error: <inp2:m_Param name="error_description"/>
-    		</td>
-  		</tr>
-	</table>
+	Order: <inp2:m_Param name="order_number"/>. USPS error: <inp2:m_Param name="error_description"/><br/>
 </inp2:m_DefineElement>
 
-<inp2:ord_PrintUSPSErrors render_as="usps_errors" />
+<inp2:m_RenderElement design="form_message" pass_params="1">
+	<inp2:ord_PrintUSPSErrors render_as="usps_errors" />
+</inp2:m_RenderElement>
 
 <inp2:m_RenderElement name="grid" PrefixSpecial="ord.toship" IdField="OrderId" grid="Default"/>
 <script type="text/javascript">

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0002629) Dmitry (manager) 2010-07-30 19:10	Tested good. Please commit.

(0002738) alex (manager) 2010-08-29 05:44	Fix committed to 5.1.x branch. Commit Message: Fixes 0000787: Design for block with error message

(0003050) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
In-Portal CMS: 5.1.x r13909 Timestamp: 2010-08-29 05:44:09 Author: alex [ Details ] [ Diff ]	Fixes 0000787: Design for block with error message
	mod - /in-portal/branches/5.1.x/core/admin_templates/categories/categories_tabs.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/admin_templates/incs/form_blocks.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/admin_templates/incs/grid_blocks.tpl	[ Diff ] [ File ]

Modules :: In-Commerce: 5.1.x r13908 Timestamp: 2010-08-29 05:42:05 Author: alex [ Details ] [ Diff ]	Bug 0000787: Design for block with error message
	mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/order_product_edit.tpl	[ Diff ] [ File ]
	mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_edit_shipping.tpl	[ Diff ] [ File ]
	mod - /w/in-commerce/branches/5.1.x/admin_templates/orders/orders_toship_list.tpl	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003050
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-08-29 05:44	alex	Note Added: 0002738
2010-08-29 05:44	alex	Status	reviewed and tested => resolved
2010-08-29 05:44	alex	Fixed in Version	=> 5.1.1-B1
2010-08-29 05:44	alex	Resolution	open => fixed
2010-08-29 05:44	alex	Changeset attached	5.1.x r13909
2010-08-29 05:42	alex	Changeset attached	5.1.x r13908
2010-07-31 13:06	alex	Target Version	5.1.1-B1 => 5.1.1
2010-07-31 13:03	alex	Target Version	Icebox => 5.1.1-B1
2010-07-30 19:10	Dmitry	Note Added: 0002629
2010-07-30 19:10	Dmitry	Assigned To	!COMMUNITY => alex
2010-07-30 19:10	Dmitry	Status	needs testing => reviewed and tested
2010-07-07 11:46	alex	Target Version	=> Icebox
2010-06-25 13:50	alex	Assigned To	=> !COMMUNITY
2010-06-25 13:50	alex	Developer	=> alex
2010-06-25 13:50	alex	Status	active => needs testing
2010-06-25 13:50	alex	File Added: form_message_modules.patch
2010-06-25 13:49	alex	New Issue
2010-06-25 13:49	alex	File Added: form_message_core.patch
2010-06-25 13:49	alex	Reference	=> http://groups.google.com/group/in-portal-dev/browse_thread/thread/dc757fc9ef0a76b8

Web Development by Intechnic

In-Portal Open Source CMS