In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000781

[In-Portal CMS] Install / Upgrages

bug report

always

2010-06-17 14:30

2010-07-22 15:07

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.0

Status

closed

Product Version

5.1.0-RC1

Target Version

5.1.0

Time Estimate

No estimate

Summary

0000781: Upgrade from 5.1.0-B2 to 5.1.0-RC1 fails

Description

I was unable to upgrade other modules but Core 5.1.0-B2 to 5.1.0-RC1 version.

I just don't see other modules in upgradable module list.

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/18090647a82e3e1d

Change Log Message

Estimate Points

0

upgrade_in_510_version_fix.patch [^] (424 bytes) 2010-06-17 14:30 [Show Content]

Index: install.php
===================================================================
--- install.php	(revision 13780)
+++ install.php	(working copy)
@@ -1368,7 +1368,7 @@
 
 			$version = $this->toolkit->ConvertModuleVersion($version);
 
-			if ($version < $this->toolkit->ConvertModuleVersion('5.1.0')) {
+			if ($version < $this->toolkit->ConvertModuleVersion('5.1.0-B1')) {
 				return 'modules/' . $path;
 			}

empty_skin_upgrade_log_fix.patch [^] (431 bytes) 2010-06-17 14:44 [Show Content]

Index: install/install_toolkit.php
===================================================================
--- install/install_toolkit.php	(revision 13780)
+++ install/install_toolkit.php	(working copy)
@@ -946,7 +946,7 @@
 
 			if (!$versions) {
 				// not skin changes -> quit
-				return ;
+				return true;
 			}
 
 			$primary_skin =& $this->Application->recallObject('skin.primary', null, Array ('skip_autoload' => true));

upgrade_in_510_version_fix_v2.patch [^] (472 bytes) 2010-06-17 14:52 [Show Content]

Index: install.php
===================================================================
--- install.php	(revision 13780)
+++ install.php	(working copy)
@@ -1366,9 +1366,8 @@
 				return $path;
 			}
 
-			$version = $this->toolkit->ConvertModuleVersion($version);
-
-			if ($version < $this->toolkit->ConvertModuleVersion('5.1.0')) {
+			if (!preg_match('/^modules\//', $path)) {
+				// upgrade from 5.0.x/1.0.x to 5.1.x/1.1.x
 				return 'modules/' . $path;
 			}

Relationships [ Relation Graph ] [ Dependency Graph ]

child of

closed (5.1.0)

We should move all module folders to new "modules" subfolder

Notes
(0002472) alex (manager) 2010-06-17 14:44	Patch "empty_skin_upgrade_log_fix.patch" fixes empty skin upgrade log, when skin wasn't upgraded.

(0002473) Dmitry (manager) 2010-06-17 16:17	Tested good both Skin and 2nd patch for Upgrade. Please commit.

(0002474) alex (manager) 2010-06-18 13:02	Fix committed to 5.1.x branch. Commit Message: Fixes 0000781: Upgrade from 5.1.0-B2 to 5.1.0-RC1 fails

(0002580) alex (manager) 2010-07-22 15:07	Closing, since 5.1.0 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r13806 Timestamp: 2010-06-18 13:02:57 Author: alex [ Details ] [ Diff ]	Fixes 0000781: Upgrade from 5.1.0-B2 to 5.1.0-RC1 fails
	mod - /in-portal/branches/5.1.x/core/install/install_toolkit.php		[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/install.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-07-22 15:07	alex	Note Added: 0002580
2010-07-22 15:07	alex	Status	resolved => closed
2010-06-18 13:02	alex	Status	reviewed and tested => resolved
2010-06-18 13:02	alex	Fixed in Version	=> 5.1.0
2010-06-18 13:02	alex	Resolution	open => fixed
2010-06-18 13:02	alex	Assigned To	!COMMUNITY => alex
2010-06-18 13:02	alex	Changeset attached	5.1.x r13806
2010-06-18 13:02	alex	Note Added: 0002474
2010-06-17 16:17	Dmitry	Note Added: 0002473
2010-06-17 16:17	Dmitry	Status	needs testing => reviewed and tested
2010-06-17 14:52	alex	File Added: upgrade_in_510_version_fix_v2.patch
2010-06-17 14:44	alex	Note Added: 0002472
2010-06-17 14:44	alex	File Added: empty_skin_upgrade_log_fix.patch
2010-06-17 14:32	alex	Relationship added	child of 0000362
2010-06-17 14:31	alex	Assigned To	=> !COMMUNITY
2010-06-17 14:31	alex	Developer	=> alex
2010-06-17 14:31	alex	Status	active => needs testing
2010-06-17 14:31	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/18090647a82e3e1d
2010-06-17 14:30	alex	New Issue
2010-06-17 14:30	alex	File Added: upgrade_in_510_version_fix.patch

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group