In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000766 [In-Commerce] Payment Gateways bug report always 2010-06-08 22:39 2010-07-22 15:07
Reporter Dmitry View Status public Project Name In-Commerce
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.0-RC1
Status closed Product Version 5.1.0-B2 Target Version 5.1.0
Time EstimateNo estimate
Summary 0000766: Incorrect paths for In-Commerce & In-Auction gateway scripts
Description There have been some issue with PATHS defined within Gateway scripts of In-Commerce and In-Auction mainly due to migration of all modules under /modules folder.
Additional Information
Tags No tags attached.
Reference
Change Log Message Fixed Incorrect paths for In-Commerce & In-Auction gateway scripts
Estimate Points 0
Attached Files patch file icon incorrect_modules_paths_defined.patch [^] (18,690 bytes) 2010-06-08 22:39 [Show Content]
patch file icon path_fixes_in_auction_v2.patch [^] (3,217 bytes) 2010-06-09 04:11 [Show Content]
patch file icon path_fixes_in_commerce_v2.patch [^] (20,054 bytes) 2010-06-09 05:02 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
child of 0000362closed (5.1.0)!COMMUNITY In-Portal CMS We should move all module folders to new "modules" subfolder 

-  Notes
User avatar (0002379)
Dmitry (manager)
2010-06-08 22:39

Please review the code

I have tested all on some live transactions
User avatar (0002384)
alex (manager)
2010-06-09 04:12

Patch "patch file icon path_fixes_in_auction_v2.patch" also adds REL_PATH to all files, when appropriate. Also patch to "s.gif" was broken in "hitcounter.php".
User avatar (0002385)
alex (manager)
2010-06-09 05:07

Patch "path_fixes_in_commerce_v2.patch" also adds REL_PATH to all files, when appropriate.

1. Also I've removed "in-commerce/add_to_cart.php" since it wasn't working or used anyway.
2. Notification scripts were calling "gw_notify.php" using incorrect path.
3. You've copied one code into all files, but they were descendants of same class and you've could placed that code in parent class. I've did that.

Please test latest 2 patches on at least these payment gateways:
1. paypal direct, paypal normal, paypal reoccuring
2. google checkout
3. atosorigin/sella
User avatar (0002395)
Dmitry (manager)
2010-06-09 09:25

Tested, please commit.
User avatar (0002398)
alex (manager)
2010-06-09 09:52

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000766: Incorrect paths for In-Commerce & In-Auction gateway scripts
User avatar (0002591)
alex (manager)
2010-07-22 15:07

Closing, since 5.1.0 release has been released.

- Related Changesets
Modules :: In-Commerce: 5.1.x r13704
Timestamp: 2010-06-09 09:52:56
Author: alex
Details ] Diff ]
Fixes 0000766: Incorrect paths for In-Commerce & In-Auction gateway scripts
rm - /w/in-commerce/branches/5.1.x/add_to_cart.php
mod - /w/in-commerce/branches/5.1.x/gw_notify.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/atosorigin.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/google_checkout.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/gw_base.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/ideal_nl.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/multicards.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/atosorigin_notify.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/google_checkout_notify.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/google_checkout_shippings.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/multicards_notify.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/paybox_notify.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/sella_error.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/sella_notify.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/sella_ok.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/notify_scripts/verisign_pflink_notify.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/paypal.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gateways/gw_classes/worldpay.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-07-22 15:07 alex Note Added: 0002591
2010-07-22 15:07 alex Status resolved => closed
2010-06-10 15:06 alex Fixed in Version 5.1.0-B2 => 5.1.0-RC1
2010-06-09 09:52 alex Note Added: 0002398
2010-06-09 09:52 alex Status reviewed and tested => resolved
2010-06-09 09:52 alex Fixed in Version => 5.1.0-B2
2010-06-09 09:52 alex Resolution open => fixed
2010-06-09 09:52 alex Changeset attached 5.1.x r13704
2010-06-09 09:52 alex Changeset attached 5.1.x r13703
2010-06-09 09:25 Dmitry Note Added: 0002395
2010-06-09 09:25 Dmitry Assigned To Dmitry => alex
2010-06-09 09:25 Dmitry Status needs testing => reviewed and tested
2010-06-09 05:07 alex Note Added: 0002385
2010-06-09 05:07 alex Developer Dmitry => alex
2010-06-09 05:07 alex Status needs work => needs testing
2010-06-09 05:02 alex Assigned To alex => Dmitry
2010-06-09 05:02 alex Status needs testing => needs work
2010-06-09 05:02 alex File Added: path_fixes_in_commerce_v2.patch
2010-06-09 04:12 alex Note Added: 0002384
2010-06-09 04:11 alex File Added: path_fixes_in_auction_v2.patch
2010-06-08 22:45 Dmitry Relationship added child of 0000362
2010-06-08 22:39 Dmitry Note Added: 0002379
2010-06-08 22:39 Dmitry Assigned To => alex
2010-06-08 22:39 Dmitry Developer => Dmitry
2010-06-08 22:39 Dmitry Status active => needs testing
2010-06-08 22:39 Dmitry New Issue
2010-06-08 22:39 Dmitry File Added: incorrect_modules_paths_defined.patch
2010-06-08 22:39 Dmitry Change Log Message => Fixed Incorrect paths for In-Commerce & In-Auction gateway scripts



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker