In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/3e2841c791674b9

Change Log Message

Fixes "Section Template" button in Design Mode

Estimate Points

Attached Files

section_template_button_fix.patch [^] (2,529 bytes) 2010-05-11 12:39 [Show Content]

Index: categories_tag_processor.php
===================================================================
--- categories_tag_processor.php	(revision 13543)
+++ categories_tag_processor.php	(working copy)
@@ -1463,14 +1463,13 @@
 					'front'			=>	1,
 					'__URLENCODE__'	=>	1,
 					'__NO_REWRITE__'=>	1,
-					'escape'		=>	1,
 					'index_file' => 'index.php',
 				);
 
 				$edit_url = $this->Application->HREF('categories/categories_edit', ADMIN_DIRECTORY, $url_params);
 
 				$edit_btn .= '
-					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\''.$edit_url.'\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'c\', \'categories/categories_edit\');">
+					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\''.addslashes($edit_url).'\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'c\', \'categories/categories_edit\');">
 						<div class="cms-btn-image">
 							<img src="' . $this->Application->BaseURL() . 'core/admin_templates/img/top_frame/icons/section_properties.png" width="15" height="16" alt=""/>
 						</div>
@@ -1478,7 +1477,7 @@
 					</div>' . "\n";
 			} elseif (EDITING_MODE == EDITING_MODE_DESIGN) {
 				$url_params = Array(
-					'pass'			=>	'm,theme',
+					'pass'			=>	'm,theme,theme-file',
 					'm_opener'		=>	'd',
 					'theme_id'		=>	$this->Application->GetVar('m_theme'),
 					'theme_mode'	=>	't',
@@ -1487,7 +1486,6 @@
 					'front'			=>	1,
 					'__URLENCODE__'	=>	1,
 					'__NO_REWRITE__'=>	1,
-					'escape'		=>	1,
 					'index_file' => 'index.php',
 				);
 
@@ -1509,7 +1507,7 @@
 						</div>
 					</div>
 
-					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\''.$edit_url.'\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'theme\', \'themes/file_edit\');">
+					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\''.addslashes($edit_url).'\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'theme\', \'themes/file_edit\');">
 						<div class="cms-btn-image">
 							<img src="' . $this->Application->BaseURL() . 'core/admin_templates/img/top_frame/icons/section_properties.png" width="15" height="16" alt=""/>
 						</div>

section_template_button_fix_v2.patch [^] (2,788 bytes) 2010-05-18 10:47 [Show Content]

Index: units/categories/categories_tag_processor.php
===================================================================
--- units/categories/categories_tag_processor.php	(revision 13571)
+++ units/categories/categories_tag_processor.php	(working copy)
@@ -118,7 +118,7 @@
 	{
 		$object =& $this->getObject($params);
 		/* @var $object kDBItem */
-		
+
 		$ci_table = $this->Application->getUnitOption('ci', 'TableName');
 
 		$sql = 'SELECT COUNT(*)
@@ -1430,14 +1430,13 @@
 					'front'			=>	1,
 					'__URLENCODE__'	=>	1,
 					'__NO_REWRITE__'=>	1,
-					'escape'		=>	1,
 					'index_file' => 'index.php',
 				);
 
 				$edit_url = $this->Application->HREF('categories/categories_edit', ADMIN_DIRECTORY, $url_params);
 
 				$edit_btn .= '
-					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\''.$edit_url.'\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'c\', \'categories/categories_edit\');">
+					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\'' . addslashes($edit_url) . '\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'c\', \'categories/categories_edit\');">
 						<div class="cms-btn-image">
 							<img src="' . $this->Application->BaseURL() . 'core/admin_templates/img/top_frame/icons/section_properties.png" width="15" height="16" alt=""/>
 						</div>
@@ -1445,7 +1444,7 @@
 					</div>' . "\n";
 			} elseif (EDITING_MODE == EDITING_MODE_DESIGN) {
 				$url_params = Array(
-					'pass'			=>	'm,theme',
+					'pass'			=>	'm,theme,theme-file',
 					'm_opener'		=>	'd',
 					'theme_id'		=>	$this->Application->GetVar('m_theme'),
 					'theme_mode'	=>	't',
@@ -1454,7 +1453,6 @@
 					'front'			=>	1,
 					'__URLENCODE__'	=>	1,
 					'__NO_REWRITE__'=>	1,
-					'escape'		=>	1,
 					'index_file' => 'index.php',
 				);
 
@@ -1476,7 +1474,7 @@
 						</div>
 					</div>
 
-					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\''.$edit_url.'\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'theme\', \'themes/file_edit\');">
+					<div class="cms-section-properties-btn"' . ($display_mode === false ? ' style="margin: 0px;"' : '') . ' onmouseover="window.status=\'' . addslashes($edit_url) . '\'; return true" onclick="$form_name=\'kf_'.$page->GetID().'\'; std_edit_item(\'theme\', \'themes/file_edit\');">
 						<div class="cms-btn-image">
 							<img src="' . $this->Application->BaseURL() . 'core/admin_templates/img/top_frame/icons/section_properties.png" width="15" height="16" alt=""/>
 						</div>

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0002223) Dmitry (manager) 2010-05-17 18:21	I believe this should be moved to 5.0.4 since is quite critical and not a good idea to leave out for a while.

(0002224) Dmitry (manager) 2010-05-17 18:24	Patch can't be applied to 5.0.4. Please reassemble.

(0002240) Dmitry (manager) 2010-05-18 20:35	Tested good.

(0002251) alex (manager) 2010-05-19 02:49	Fix committed to 5.0.x branch. Commit Message: Fixes 0000727: Button "Section Template" (Design Mode) doesn't work

(0002417) alex (manager) 2010-06-10 13:44	Closing since version 5.0.4 is released.

Related Changesets
In-Portal CMS: 5.0.x r13586 Timestamp: 2010-05-19 02:49:15 Author: alex [ Details ] [ Diff ]	Fixes 0000727: Button "Section Template" (Design Mode) doesn't work
	mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]

In-Portal CMS: 5.1.x r13544 Timestamp: 2010-05-11 12:44:26 Author: alex [ Details ] [ Diff ]	1. Bug 0000727: Button "Section Template" (Design Mode) doesn't work 2. Manually merging to 5.1.0, since doesn't work at all without it
	mod - /in-portal/branches/5.1.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-06-10 13:44	alex	Note Added: 0002417
2010-06-10 13:44	alex	Status	resolved => closed
2010-05-19 02:49	alex	Note Added: 0002251
2010-05-19 02:49	alex	Status	reviewed and tested => resolved
2010-05-19 02:49	alex	Fixed in Version	=> 5.0.4-B1
2010-05-19 02:49	alex	Resolution	open => fixed
2010-05-19 02:49	alex	Assigned To	!COMMUNITY => alex
2010-05-19 02:49	alex	Changeset attached	5.0.x r13586
2010-05-18 20:35	Dmitry	Note Added: 0002240
2010-05-18 20:35	Dmitry	Status	needs testing => reviewed and tested
2010-05-18 10:47	alex	Assigned To	alex => !COMMUNITY
2010-05-18 10:47	alex	Status	needs work => needs testing
2010-05-18 10:47	alex	File Added: section_template_button_fix_v2.patch
2010-05-17 18:24	Dmitry	Assigned To	!COMMUNITY => alex
2010-05-17 18:24	Dmitry	Note Added: 0002224
2010-05-17 18:24	Dmitry	Status	needs testing => needs work
2010-05-17 18:21	Dmitry	Change Log Message	=> Fixes "Section Template" button in Design Mode
2010-05-17 18:21	Dmitry	Note Added: 0002223
2010-05-17 18:21	Dmitry	Priority	normal => critical
2010-05-17 18:21	Dmitry	Target Version	Icebox => 5.0.4
2010-05-11 12:44	alex	Changeset attached	5.1.x r13544
2010-05-11 12:40	alex	Assigned To	=> !COMMUNITY
2010-05-11 12:40	alex	Developer	=> alex
2010-05-11 12:40	alex	Status	active => needs testing
2010-05-11 12:40	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/3e2841c791674b9
2010-05-11 12:39	alex	New Issue
2010-05-11 12:39	alex	File Added: section_template_button_fix.patch

Web Development by Intechnic

In-Portal Open Source CMS