|
Viewing Issue Simple Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Advanced ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Type |
Reproducibility |
Date Submitted |
Last Update |
|
0000659 |
[In-Portal CMS] Front End |
bug report |
always |
2010-03-27 17:20 |
2011-06-18 04:24 |
|
|
Reporter |
alex |
View Status |
public |
Project Name |
In-Commerce |
|
Assigned To |
alex |
Developer |
|
|
Priority |
normal |
Resolution |
fixed |
Fixed in Version |
5.0.4-B1 |
|
Status |
closed |
Product Version |
5.0.3-B1 |
Target Version |
5.0.4 |
| Time Estimate | No estimate | |
|
|
Summary |
0000659: Order thank you screen and session expiration problem |
|
Description |
When you are on other thank you page (after checkout is complete) and then you go drink so tee for an 2 hours or so, then when you return session expiration happens or not happens. Anyway session is dead by then. On that thank you template, when order contents is printed it's ID is retrieved from session via "front_order_id" variable. When session is gone, then ID is gone too, so instead of products in order we are getting all possible products from database which most likely will end up with fatal error about too much memory being used by the script.
I propose to use FAKE_ORDER_ID constant as order id in case, when ID in session is lost. This will give us empty order and no errors. |
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Reference |
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/198c1d40484895f5 |
|
Change Log Message |
|
|
Estimate Points |
0 |
|
|
Attached Files |
 order_thank_you_screen_fix.patch [^] (679 bytes) 2010-05-19 07:24
[Show Content]
Index: orders_event_handler.php
===================================================================
--- orders_event_handler.php (revision 13571)
+++ orders_event_handler.php (working copy)
@@ -1058,7 +1058,9 @@
if ($event->Special == 'last') {
// return last order id (for using on thank you page)
- return $this->Application->RecallVar('front_order_id');
+ $order_id = $this->Application->RecallVar('front_order_id');
+
+ return $order_id > 0 ? $order_id : FAKE_ORDER_ID; // FAKE_ORDER_ID helps to keep parent filter for order items set in "kDBList::linkToParent"
}
$ses_id = $this->Application->RecallVar( $event->getPrefixSpecial(true) . '_id' );
|
|
|
Relationships [ Relation Graph ]
[ Dependency Graph ]
Relationships 
(0002258)
(0002261)
