0000629: Can't use custom Input Date/Time format for fields

Index: form_blocks.tpl =================================================================== --- form_blocks.tpl (revision 14059) +++ form_blocks.tpl (working copy) @@ -311,7 +311,7 @@ <inp2:m_DefineElement name="inp_edit_date" class="" error_field_suffix="_date"> <inp2:m_RenderElement design="form_row" pass_params="1"> <td class="control-cell"> - <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date' format='_regional_InputDateFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif">  + <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif">  <img src="img/calendar_icon.gif" id="cal_img_<inp2:{$prefix}_InputName field='{$field}'/>" style="cursor: pointer; margin-right: 5px" title="Date selector" @@ -340,7 +340,7 @@ <inp2:m_DefineElement name="inp_edit_time" class="" error_field_suffix="_time"> <inp2:m_RenderElement design="form_row" pass_params="1"> <td class="control-cell"> - <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time' format='_regional_InputTimeFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>">  + <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>">  <span class="small">(<inp2:{$prefix}_Format field="{$field}_time" input_format="1" human="true"/>)</span> <input type="hidden" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date' input_format='1'/>" value=""> @@ -352,7 +352,7 @@ <inp2:m_RenderElement design="form_row" pass_params="1"> <td class="control-cell">  - <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date' format='_regional_InputDateFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif"> + <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif"> <img src="img/calendar_icon.gif" id="cal_img_<inp2:{$prefix}_InputName field="{$field}"/>" style="cursor: pointer; margin-right: 5px" title="Date selector" @@ -375,7 +375,7 @@ } }); </script> -  <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time' format='_regional_InputTimeFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>"><span class="small"> (<inp2:{$prefix}_Format field="{$field}_time" input_format="1" human="true"/>)</span> +  <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>"><span class="small"> (<inp2:{$prefix}_Format field="{$field}_time" input_format="1" human="true"/>)</span> </td> </inp2:m_RenderElement> </inp2:m_DefineElement>

Index: admin_templates/incs/form_blocks.tpl =================================================================== --- admin_templates/incs/form_blocks.tpl (revision 14059) +++ admin_templates/incs/form_blocks.tpl (working copy) @@ -311,7 +311,7 @@ <inp2:m_DefineElement name="inp_edit_date" class="" error_field_suffix="_date"> <inp2:m_RenderElement design="form_row" pass_params="1"> <td class="control-cell"> - <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date' format='_regional_InputDateFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif">  + <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date' format='_input_'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif">  <img src="img/calendar_icon.gif" id="cal_img_<inp2:{$prefix}_InputName field='{$field}'/>" style="cursor: pointer; margin-right: 5px" title="Date selector" @@ -340,7 +340,7 @@ <inp2:m_DefineElement name="inp_edit_time" class="" error_field_suffix="_time"> <inp2:m_RenderElement design="form_row" pass_params="1"> <td class="control-cell"> - <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time' format='_regional_InputTimeFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>">  + <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time' format='_input_'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>">  <span class="small">(<inp2:{$prefix}_Format field="{$field}_time" input_format="1" human="true"/>)</span> <input type="hidden" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date' input_format='1'/>" value=""> @@ -352,7 +352,7 @@ <inp2:m_RenderElement design="form_row" pass_params="1"> <td class="control-cell">  - <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date' format='_regional_InputDateFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif"> + <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_date'/>" id="<inp2:{$prefix}_InputName field='{$field}_date'/>" value="<inp2:{$prefix}_Field field='{$field}_date' format='_input_'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_date' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>" datepickerIcon="<inp2:m_ProjectBase/>core/admin_templates/img/calendar_icon.gif"> <img src="img/calendar_icon.gif" id="cal_img_<inp2:{$prefix}_InputName field="{$field}"/>" style="cursor: pointer; margin-right: 5px" title="Date selector" @@ -375,7 +375,7 @@ } }); </script> -  <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time' format='_regional_InputTimeFormat'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>"><span class="small"> (<inp2:{$prefix}_Format field="{$field}_time" input_format="1" human="true"/>)</span> +  <input type="text" name="<inp2:{$prefix}_InputName field='{$field}_time'/>" id="<inp2:{$prefix}_InputName field='{$field}_time'/>" value="<inp2:{$prefix}_Field field='{$field}_time' format='_input_'/>" tabindex="<inp2:m_get param='tab_index'/>" size="<inp2:{$prefix}_Format field='{$field}_time' input_format='1' edit_size='edit_size'/>" class="<inp2:m_param name='class'/>"><span class="small"> (<inp2:{$prefix}_Format field="{$field}_time" input_format="1" human="true"/>)</span> </td> </inp2:m_RenderElement> </inp2:m_DefineElement> Index: kernel/utility/formatters/date_formatter.php =================================================================== --- kernel/utility/formatters/date_formatter.php (revision 14059) +++ kernel/utility/formatters/date_formatter.php (working copy) @@ -215,6 +215,11 @@ $options['format'] = $this->language->GetDBField($regs[1]); } + if ($options['format'] == '_input_') { + // use input format instead of output format + $options['format'] = $options['input_format']; + } + if (!$options['use_timezone']) { return adodb_gmdate($options['format'], $value); }

Issue History
Date Modified	Username	Field	Change
2012-08-21 12:55	alex	Relationship added	related to 0001384
2011-03-30 09:53	Dmitry	Note Added: 0003347
2011-03-30 09:53	Dmitry	Status	resolved => closed
2011-01-09 08:48	alex	Assigned To	!COMMUNITY => alex
2011-01-09 08:48	alex	Changeset attached	5.1.x r14134
2011-01-09 08:48	alex	Note Added: 0003184
2011-01-09 08:48	alex	Status	reviewed and tested => resolved
2011-01-09 08:48	alex	Fixed in Version	=> 5.1.2-B1
2011-01-09 08:48	alex	Resolution	open => fixed
2010-11-21 16:16	Dmitry	Note Added: 0002989
2010-11-21 16:16	Dmitry	Status	needs testing => reviewed and tested
2010-11-21 16:16	Dmitry	Change Log Message	=> Fixes bug with using custom Date/Time formats for Input fields
2010-11-19 07:58	alex	Note Added: 0002982
2010-11-19 07:57	alex	File Added: custom_time_input_format_ignored_v2.patch
2010-11-19 07:48	alex	Note Added: 0002981
2010-11-19 07:48	alex	Assigned To	=> !COMMUNITY
2010-11-19 07:48	alex	Developer	=> alex
2010-11-19 07:48	alex	Status	active => needs testing
2010-11-19 07:45	alex	Target Version	Icebox => 5.1.2
2010-11-19 07:45	alex	File Added: custom_time_input_format_ignored.patch
2010-05-10 14:50	alex	Target Version	5.0.4 => Icebox
2010-03-26 14:37	alex	Target Version	=> 5.0.4
2010-03-19 11:00	Dmitry	Relationship added	related to 0000507
2010-03-19 11:00	Dmitry	New Issue

Notes
(0002981) alex (manager) 2010-11-19 07:48	Actually removing "format" parameter from "inp_edit_date_time", "inp_edit_date", "inp_edit_time" blocks helped. Maybe this will have side effects, when date/time input formats will differ from input formats.

(0002982) alex (manager) 2010-11-19 07:58	Patch "custom_time_input_format_ignored_v2.patch" fixes issue, when display format differs from input format.

(0002989) Dmitry (manager) 2010-11-21 16:16	Tested good, and ready for commit!

(0003184) alex (manager) 2011-01-09 08:48	Fix committed to 5.1.x branch. Commit Message: Fixes 0000629: Can't use custom Input Date/Time format for fields

(0003347) Dmitry (manager) 2011-03-30 09:53	Closing, since 5.1.2 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14134 Timestamp: 2011-01-09 08:48:00 Author: alex [ Details ] [ Diff ]	Fixes 0000629: Can't use custom Input Date/Time format for fields
	mod - /in-portal/branches/5.1.x/core/admin_templates/incs/form_blocks.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/kernel/utility/formatters/date_formatter.php	[ Diff ] [ File ]

In-Portal Issue Tracker