In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/da310ac841199eb

Change Log Message

Estimate Points

Attached Files

primary_image_at_not_used_core_and_modules.patch [^] (6,818 bytes) 2010-03-17 06:52 [Show Content]

Index: core/units/categories/categories_config.php
===================================================================
--- core/units/categories/categories_config.php	(revision 13241)
+++ core/units/categories/categories_config.php	(working copy)
@@ -273,6 +273,7 @@
 			'' => Array (
 				'CurrentSort'	=>	"REPLACE(ParentPath, CONCAT('|', ".'%1$s'.".CategoryId, '|'), '')",
 
+				'AltName'		=>	'img.AltName',
 				'SameImages'	=>	'img.SameImages',
 				'LocalThumb'	=>	'img.LocalThumb',
 				'ThumbPath'		=>	'img.ThumbPath',
@@ -370,6 +371,7 @@
 			'OldPriority'	=>	Array('type' => 'int', 'default' => 0),
 
 			// for primary image
+			'AltName'		=>	Array('type' => 'string', 'default' => ''),
 			'SameImages'	=>	Array('type' => 'string', 'default' => ''),
 			'LocalThumb'	=>	Array('type' => 'string', 'default' => ''),
 			'ThumbPath'		=>	Array('type' => 'string', 'default' => ''),
Index: core/units/images/image_tag_processor.php
===================================================================
--- core/units/images/image_tag_processor.php	(revision 13248)
+++ core/units/images/image_tag_processor.php	(working copy)
@@ -104,9 +104,13 @@
 			}
 			else {
 				$object->SetDBField('Url', $parent_item->GetDBField('FullUrl'));
-				$object->SetDBField('AltName', $this->getItemTitle($parent_item));
 
-				$object->SetDBFieldsFromHash($parent_item->GetFieldValues(), Array('SameImages', 'LocalThumb', 'ThumbPath', 'ThumbUrl', 'LocalImage', 'LocalPath'));
+				$object->SetDBFieldsFromHash($parent_item->GetFieldValues(), Array('AltName', 'SameImages', 'LocalThumb', 'ThumbPath', 'ThumbUrl', 'LocalImage', 'LocalPath'));
+
+				if (!$object->GetDBField('AltName')) {
+					$object->SetDBField('AltName', $this->getItemTitle($parent_item));
+				}
+
 				$object->Loaded = true;
 			}
 
Index: in-bulletin/units/posts/posts_config.php
===================================================================
--- in-bulletin/units/posts/posts_config.php	(revision 13241)
+++ in-bulletin/units/posts/posts_config.php	(working copy)
@@ -65,6 +65,7 @@
 			'' => Array (
 				'UserName' => 'IF (ISNULL(u.Login), IF (%1$s.CreatedById = -1, "root", IF (%1$s.CreatedById = -2, "Guest", "n/a")), u.Login)',
 
+				'AltName'		=>	'img.AltName',
 				'SameImages'	=>	'img.SameImages',
 				'LocalThumb'	=>	'img.LocalThumb',
 				'ThumbPath'		=>	'img.ThumbPath',
@@ -99,6 +100,7 @@
 			'ShowSignatures' => Array ('type' => 'int', 'formatter' => 'kOptionsFormatter', 'options' => Array (0 => 'la_No', 1 => 'la_Yes'), 'use_phrases' => 1, 'default' => 1),
 
 			// for avatar image
+			'AltName'		=>	Array('type' => 'string', 'default' => ''),
 			'SameImages'	=>	Array('type' => 'string', 'default' => ''),
 			'LocalThumb'	=>	Array('type' => 'string', 'default' => ''),
 			'ThumbPath'		=>	Array('type' => 'string', 'default' => ''),
Index: in-bulletin/units/topics/topics_config.php
===================================================================
--- in-bulletin/units/topics/topics_config.php	(revision 13241)
+++ in-bulletin/units/topics/topics_config.php	(working copy)
@@ -255,6 +255,7 @@
 							'PrimaryCat'	=> TABLE_PREFIX.'%3$sCategoryItems.PrimaryCat',
 							'ParentPath' => TABLE_PREFIX.'Category.ParentPath',
 
+							'AltName'		=>	'img.AltName',
 							'SameImages'	=>	'img.SameImages',
 							'LocalThumb'	=>	'img.LocalThumb',
 							'ThumbPath'		=>	'img.ThumbPath',
@@ -331,7 +332,7 @@
 			            	'type' => 'int',
 			            	'formatter' => 'kOptionsFormatter',
 			            	'options' => Array (
-								0 => 'la_Disabled',	
+								0 => 'la_Disabled',
 								1 => 'la_Active',
 								2 => 'la_Pending',
 							),
@@ -450,6 +451,7 @@
 						),
 
 						// for primary image
+						'AltName'		=>	Array('type' => 'string', 'default' => ''),
 						'SameImages'	=>	Array ('type' => 'string', 'default' => ''),
 						'LocalThumb'	=>	Array ('type' => 'string', 'default' => ''),
 						'ThumbPath'		=>	Array ('type' => 'string', 'default' => ''),
Index: in-commerce/units/products/products_config.php
===================================================================
--- in-commerce/units/products/products_config.php	(revision 13241)
+++ in-commerce/units/products/products_config.php	(working copy)
@@ -350,6 +350,7 @@
 					'TableName'			=>	TABLE_PREFIX.'Products',
 					'CalculatedFields' => Array (
 						''	=>	Array (
+							'AltName'		=>	'img.AltName',
 							'SameImages'	=>	'img.SameImages',
 							'LocalThumb'	=>	'img.LocalThumb',
 							'ThumbPath'		=>	'img.ThumbPath',
@@ -538,6 +539,7 @@
 												'FileVersion'			=>	Array(),
 
 												// for primary image
+												'AltName'		=>	Array('type' => 'string', 'default' => ''),
 												'SameImages'	=>	Array('type' => 'string', 'default' => ''),
 												'LocalThumb'	=>	Array('type' => 'string', 'default' => ''),
 												'ThumbPath'		=>	Array('type' => 'string', 'default' => ''),
Index: in-link/units/links/links_config.php
===================================================================
--- in-link/units/links/links_config.php	(revision 13241)
+++ in-link/units/links/links_config.php	(working copy)
@@ -360,6 +360,7 @@
 							'PrimaryCat'	=> TABLE_PREFIX.'%3$sCategoryItems.PrimaryCat',
 							'ParentPath' => TABLE_PREFIX.'Category.ParentPath',
 
+							'AltName'		=>	'img.AltName',
 							'SameImages'	=>	'img.SameImages',
 							'LocalThumb'	=>	'img.LocalThumb',
 							'ThumbPath'		=>	'img.ThumbPath',
@@ -484,6 +485,7 @@
 						'ParentPath'			=>	Array('type' => 'string', 'default' => ''),
 
 						// for primary image
+						'AltName'		=>	Array('type' => 'string', 'default' => ''),
 						'SameImages'	=>	Array('type' => 'string', 'default' => ''),
 						'LocalThumb'	=>	Array('type' => 'string', 'default' => ''),
 						'ThumbPath'		=>	Array('type' => 'string', 'default' => ''),
Index: in-news/units/articles/articles_config.php
===================================================================
--- in-news/units/articles/articles_config.php	(revision 13241)
+++ in-news/units/articles/articles_config.php	(working copy)
@@ -297,6 +297,7 @@
 							'PrimaryCat'	=> TABLE_PREFIX.'%3$sCategoryItems.PrimaryCat',
 							'ParentPath' => TABLE_PREFIX.'Category.ParentPath',
 
+							'AltName'		=>	'img.AltName',
 							'SameImages'	=>	'img.SameImages',
 							'LocalThumb'	=>	'img.LocalThumb',
 							'ThumbPath'		=>	'img.ThumbPath',
@@ -381,6 +382,7 @@
 						'ParentPath'			=>	Array('type' => 'string', 'default' => ''),
 
 						// for primary image
+						'AltName'		=>	Array('type' => 'string', 'default' => ''),
 						'SameImages'	=>	Array('type' => 'string', 'default' => ''),
 						'LocalThumb'	=>	Array('type' => 'string', 'default' => ''),
 						'ThumbPath'		=>	Array('type' => 'string', 'default' => ''),

primary_image_at_not_used_themes.patch [^] (3,066 bytes) 2010-03-17 06:52 [Show Content]

Index: in-commerce/products/product_detail.tpl
===================================================================
--- in-commerce/products/product_detail.tpl	(revision 13211)
+++ in-commerce/products/product_detail.tpl	(working copy)
@@ -67,7 +67,7 @@
 									<td style="text-align: center; padding-right: 10px;" valign="top">
 										<!--## Check if image exists ##-->
 										<inp2:m_if check="p_ImageSrc" MaxWidth="fullsize">
-											<a href="<inp2:p_ImageSrc DefaultImage="platform/img/no_picture.gif" format="resize:450x450;wm:platform/img/logo_watermark.png|-1|-1"/>" class="thickbox" rel="product-images" title="<inp2:p_Field name='Name' html_escape='1'/>">
+											<a href="<inp2:p_ImageSrc DefaultImage="platform/img/no_picture.gif" format="resize:450x450;wm:platform/img/logo_watermark.png|-1|-1"/>" class="thickbox" rel="product-images" title="<inp2:p_Field name='PrimaryImageAlt' html_escape='1'/>">
 												<inp2:p_Image render_as="image_element" Primary="1" MaxWidth="thumbnail" DefaultWidth="150" DefaultImage="platform/img/no_picture.gif" align="center"/><br />
 											</a>
 										<!--## Check if image exists ##-->
Index: in-link/links/link_standard.tpl
===================================================================
--- in-link/links/link_standard.tpl	(revision 13211)
+++ in-link/links/link_standard.tpl	(working copy)
@@ -78,7 +78,7 @@
 								<tr>
 									<td class="picture-padding" style="padding-left:25px" valign="top">
 										<inp2:m_if check="l_ImageSrc" MaxWidth="fullsize">
-										<a href="<inp2:l_ImageSrc MaxWidth="fullsize" />" class="thickbox" rel="link-images" title="<inp2:l_Field name='Name' html_escape='1'/>">
+										<a href="<inp2:l_ImageSrc MaxWidth="fullsize" />" class="thickbox" rel="link-images" title="<inp2:l_Field name='PrimaryImageAlt' html_escape='1'/>">
 											<inp2:l_Image render_as="image_element" Primary="1" MaxWidth="thumbnail" DefaultWidth="150" DefaultImage="platform/img/no_picture.gif" /><br />
 										</a>
 										<inp2:m_else/>
Index: in-news/articles/article_detail.tpl
===================================================================
--- in-news/articles/article_detail.tpl	(revision 13211)
+++ in-news/articles/article_detail.tpl	(working copy)
@@ -97,7 +97,7 @@
 								<inp2:m_if check="n_Field" name="cust_RssOriginalURL" inverse="1">
 								<td class="picture-padding" style="padding-left:25px" valign="top">
 									<inp2:m_if check="n_ImageSrc" MaxWidth="fullsize">
-										<a href="<inp2:n_ImageSrc MaxWidth="fullsize" DefaultImage="platform/img/no_picture.gif"/>" class="thickbox" rel="article-images">
+										<a href="<inp2:n_ImageSrc MaxWidth="fullsize" DefaultImage="platform/img/no_picture.gif"/>" class="thickbox" rel="article-images" title="<inp2:l_Field name='PrimaryImageAlt' html_escape='1'/>">
 											<inp2:n_Image render_as="image_element" Primary="1" MaxWidth="thumbnail" DefaultWidth="150" DefaultImage="platform/img/no_picture.gif"/><br />
 										</a>
 									<inp2:m_else/>

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001683) Dmitry (manager) 2010-03-18 14:24	Tested Good

(0001759) alex (manager) 2010-03-30 04:06	Fix committed to 5.0.x branch. Commit Message: Fixes 0000627: Primary Image "Alt" is not used on category item detail page

(0002108) alex (manager) 2010-05-11 02:59	Closing all tasks from released versions.

Related Changesets
In-Portal CMS: 5.0.x r13328 Timestamp: 2010-03-30 04:06:01 Author: alex [ Details ] [ Diff ]	Fixes 0000627: Primary Image "Alt" is not used on category item detail page
	mod - /in-portal/branches/5.0.x/core/units/categories/categories_config.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/images/image_tag_processor.php	[ Diff ] [ File ]

Themes :: Advanced: 1.0.x r13327 Timestamp: 2010-03-30 04:04:52 Author: alex [ Details ] [ Diff ]	Bug 0000627: Primary Image "Alt" is not used on category item detail page
	mod - /themes/advanced/branches/1.0.x/in-commerce/products/product_detail.tpl	[ Diff ] [ File ]
	mod - /themes/advanced/branches/1.0.x/in-link/links/link_standard.tpl	[ Diff ] [ File ]
	mod - /themes/advanced/branches/1.0.x/in-news/articles/article_detail.tpl	[ Diff ] [ File ]

Modules :: In-News: 5.0.x r13326 Timestamp: 2010-03-30 04:03:11 Author: alex [ Details ] [ Diff ]	Bug 0000627: Primary Image "Alt" is not used on category item detail page
	mod - /modules/in-news/branches/5.0.x/units/articles/articles_config.php	[ Diff ] [ File ]

Modules :: In-Link: 5.0.x r13325 Timestamp: 2010-03-30 04:02:16 Author: alex [ Details ] [ Diff ]	Bug 0000627: Primary Image "Alt" is not used on category item detail page
	mod - /modules/in-link/branches/5.0.x/units/links/links_config.php	[ Diff ] [ File ]

Modules :: In-Commerce: 5.0.x r13324 Timestamp: 2010-03-30 04:01:14 Author: alex [ Details ] [ Diff ]	Bug 0000627: Primary Image "Alt" is not used on category item detail page
	mod - /w/in-commerce/branches/5.0.x/units/products/products_config.php	[ Diff ] [ File ]

Modules :: In-Bulletin: 5.0.x r13323 Timestamp: 2010-03-30 03:59:13 Author: alex [ Details ] [ Diff ]	Bug 0000627: Primary Image "Alt" is not used on category item detail page
	mod - /modules/in-bulletin/branches/5.0.x/units/posts/posts_config.php	[ Diff ] [ File ]
	mod - /modules/in-bulletin/branches/5.0.x/units/topics/topics_config.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-05-11 02:59	alex	Note Added: 0002108
2010-05-11 02:59	alex	Status	resolved => closed
2010-03-30 04:06	alex	Changeset attached	5.0.x r13328
2010-03-30 04:06	alex	Note Added: 0001759
2010-03-30 04:06	alex	Status	reviewed and tested => resolved
2010-03-30 04:06	alex	Fixed in Version	=> 5.0.3-B2
2010-03-30 04:06	alex	Resolution	open => fixed
2010-03-30 04:06	alex	Assigned To	!COMMUNITY => alex
2010-03-30 04:04	alex	Changeset attached	1.0.x r13327
2010-03-30 04:03	alex	Changeset attached	5.0.x r13326
2010-03-30 04:02	alex	Changeset attached	5.0.x r13325
2010-03-30 04:01	alex	Changeset attached	5.0.x r13324
2010-03-30 03:59	alex	Changeset attached	5.0.x r13323
2010-03-24 04:52	alex	Note Deleted: 0001675
2010-03-24 04:51	alex	version	5.0.2 => 5.0.3-B1
2010-03-18 14:24	Dmitry	Note Added: 0001683
2010-03-18 14:24	Dmitry	Status	needs testing => reviewed and tested
2010-03-17 06:53	alex	Note Added: 0001675
2010-03-17 06:53	alex	Assigned To	=> !COMMUNITY
2010-03-17 06:53	alex	Developer	=> alex
2010-03-17 06:53	alex	Status	active => needs testing
2010-03-17 06:53	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/da310ac841199eb
2010-03-17 06:52	alex	File Added: primary_image_at_not_used_themes.patch
2010-03-17 06:52	alex	New Issue
2010-03-17 06:52	alex	File Added: primary_image_at_not_used_core_and_modules.patch

Web Development by Intechnic

In-Portal Open Source CMS