In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0000552

[In-Portal CMS] Data Management

bug report

always

2010-01-25 10:29

2010-05-11 03:00

Reporter

alex

View Status

public

Project Name

In-Commerce

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.0.3-B1

Status

closed

Product Version

5.0.2

Target Version

5.0.3

Time Estimate

No estimate

Summary

0000552: Total Order Amount (calculated field TotalAmount) is Rounded Twice

Description

Total order amount (calculated field) is rounded twice:
   - in calculated field declaration (MySQL ROUND(<expr>, 2) function)
   - in virtual field associated with given calculated field (via formatter)
When site uses multiple currencies, then all prices are stored in database
in primary currency. All currency conversions work, except for TotalAmount
calculated field, because of double round it operates with M.NN number
instead of M.NNNN and looses some cents during conversions of course.
For example:
   - Site primary currency is LVL
   - Current currency on Front-End is EEK, which has 0.0449 conversion rate
   related to LVL
   - Product price is: 26.9827 LVL
   - Shipping price is: 3.0061 LVL
Field TotalAmount shows 669.93, but it should show 667.90 instead.

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/b481066bd38c4c08

Change Log Message

Estimate Points

Attached Files

order_total_currency_round.patch [^] (1,366 bytes) 2010-01-25 10:29 [Show Content]

Index: orders_config.php
===================================================================
--- orders_config.php	(revision 13134)
+++ orders_config.php	(working copy)
@@ -250,7 +250,7 @@
 							'SubtotalWithoutDiscount'	=>	'(SubTotal + DiscountTotal)',
 							'SubtotalWithDiscount'	=>	'(SubTotal)',
 							'AmountWithoutVAT'		=>	'(SubTotal+IF(ShippingTaxable=1, ShippingCost, 0)+IF(ProcessingTaxable=1, ProcessingFee, 0))',
-							'TotalAmount'			=>	'ROUND(SubTotal+ShippingCost+VAT+ProcessingFee+InsuranceFee-GiftCertificateDiscount,2)',
+							'TotalAmount'			=>	'SubTotal+ShippingCost+VAT+ProcessingFee+InsuranceFee-GiftCertificateDiscount',
 							'CouponCode'			=>	'pc.Code',
 							'CouponName'			=>	'pc.Name',
 							'AffiliateUser'			=>	'IF( LENGTH(au.Login),au.Login,\'!la_None!\')',
@@ -264,7 +264,7 @@
 							'SubtotalWithoutDiscount'	=>	'(SubTotal + DiscountTotal)',
 							'SubtotalWithDiscount'	=>	'(SubTotal)',
 							'AmountWithoutVAT'		=>	'(SubTotal+IF(ShippingTaxable=1, ShippingCost, 0)+IF(ProcessingTaxable=1, ProcessingFee, 0))',
-							'TotalAmount'			=>	'ROUND(SubTotal+ShippingCost+VAT+ProcessingFee+InsuranceFee-GiftCertificateDiscount,2)',
+							'TotalAmount'			=>	'SubTotal+ShippingCost+VAT+ProcessingFee+InsuranceFee-GiftCertificateDiscount',
 							/*'ItemsCount'			=>	'COUNT(%1$s.OrderId)',*/
 						),
 					),

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001571) Dmitry (manager) 2010-03-11 23:56	Tested okay

(0001582) alex (manager) 2010-03-12 07:55	Fix committed to 5.0.x branch. Commit Message: Fixes 0000552: Total Order Amount (calculated field TotalAmount) is Rounded Twice

(0002157) alex (manager) 2010-05-11 03:00	Closing all tasks from released versions.

Related Changesets
Modules :: In-Commerce: 5.0.x r13210 Timestamp: 2010-03-12 07:55:10 Author: alex [ Details ] [ Diff ]	Fixes 0000552: Total Order Amount (calculated field TotalAmount) is Rounded Twice
	mod - /w/in-commerce/branches/5.0.x/units/orders/orders_config.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-05-11 03:00	alex	Note Added: 0002157
2010-05-11 03:00	alex	Status	resolved => closed
2010-03-12 07:55	alex	Note Added: 0001582
2010-03-12 07:55	alex	Status	reviewed and tested => resolved
2010-03-12 07:55	alex	Fixed in Version	=> 5.0.3-B1
2010-03-12 07:55	alex	Resolution	open => fixed
2010-03-12 07:55	alex	Changeset attached	5.0.x r13210
2010-03-11 23:56	Dmitry	Note Added: 0001571
2010-03-11 23:56	Dmitry	Assigned To	Dmitry => alex
2010-03-11 23:56	Dmitry	Status	needs testing => reviewed and tested
2010-02-26 18:49	Dmitry	Developer	=> alex
2010-01-25 10:31	Dmitry	Assigned To	=> Dmitry
2010-01-25 10:31	Dmitry	Status	active => needs testing
2010-01-25 10:29	Dmitry	Reporter	Dmitry => alex
2010-01-25 10:29	Dmitry	New Issue
2010-01-25 10:29	Dmitry	File Added: order_total_currency_round.patch
2010-01-25 10:29	Dmitry	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/b481066bd38c4c08

Web Development by Intechnic

In-Portal Open Source CMS