In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000483 [In-Portal CMS] Front End feature request N/A 2009-12-23 03:18 2012-07-25 05:32
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-B1
Status closed Product Version 5.0.2-B1 Target Version 5.2.0
Time EstimateNo estimate
Summary 0000483: Add option for searching all typed keyword inside single category item record
Description I propose to add option (in administrative console) for searching (on Front-End) all typed keyword inside single category item record. For now if I type "test case" I will get all items, that contain "test" and all items, that contain "case". When I type "test +case", then only items, that contain both keywords will be found. This new option will make search act like "+" was used between all typed keywords.

This was implemented somewhere, by modifying kSearchHelper class.

This should be implemented as Config Option enabled by
Additional Information
Tags No tags attached.
Change Log Message
Estimate Points 1
Attached Files patch file icon search_all_keywords_483.patch [^] (3,942 bytes) 2011-11-01 05:47 [Show Content]
patch file icon search_all_keywords_483.2.patch [^] (4,835 bytes) 2011-11-02 09:02 [Show Content]
patch file icon search_all_keywords_v3.patch [^] (5,807 bytes) 2011-11-03 06:25 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0003886)
Dmitry (manager)
2011-09-23 21:54

I think we already have that, but need double-check.
User avatar (0004109)
erik (manager)
2011-11-01 05:48

patch attached - needs testing
User avatar (0004118)
alex (manager)
2011-11-02 04:52

1. I think, that config variable name "PerformExactSearch" (translation: "Perform Exact Search") with a hint label "la_hint_PerformExactSearch" (translation: "Search for all entered keywords, instead of any one of them") would be more understandable for average user, then current "Search Require All Keywords".

2. Term "category item" mentioned in task means and item, that is located within the category, not a category itself (e.g. links, products, articles, etc.).

Better place to make a change is kSearchHelper::splitKeywords method (but don't use ConfigValue in each method call, just put it's value into class variable/attribute), since it will also cover the case when multiple words are specified in quotes (e.g. "first second" keyword isn't correctly processed in this patch, since it is separated by space no matter what). There you can do a system-wide (I allow this change) adding of "+", when there are not +/- in front of keywords discovered within kSearchHelper::splitKeywords method.

Next time, when creating text, that is displayed to users (e.g. entering new label translation) try to make it's translation as simple as possible. And check grammar of your translation.
User avatar (0004119)
erik (manager)
2011-11-02 08:48

Patch search_all_keywords_483.2.patch attached - needs testing
User avatar (0004128)
alex (manager)
2011-11-03 06:28

Works, but here are few fixed I've made:

1. place INSERT statement of new configuration variable into "install/install_data.sql" file in same place where variable is visually located in Admin Console (e.g. "PerformExactSearch" config variable is displayed after "cms_DefaultTrackingCode" config variable and that's why it's INSERT statement should follow that variable's INSERT statement).
This allows to made necessary changes to install_data.sql file easier.

2. Class variable/attribute "_perform_exact_search" wasn't following In-Portal naming conversions. The correct name should be "_performExactSearch".
User avatar (0004129)
alex (manager)
2011-11-03 06:29

Fix committed to 5.2.x branch. Commit Message:

Fixes 0000483: Add option for searching all typed keyword inside single category item record
Commit on behalf of Erik
User avatar (0005063)
alex (manager)
2012-07-25 05:32

Since 5.2.0 version was released.

- Related Changesets
In-Portal CMS: 5.2.x r14730
Timestamp: 2011-11-03 06:29:40
Author: alex
Details ] Diff ]
Fixes 0000483: Add option for searching all typed keyword inside single category item record
Commit on behalf of Erik
mod - /in-portal/branches/5.2.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_data.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/search_helper.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005063
2012-07-25 05:32 alex Status resolved => closed
2011-11-03 06:29 alex Changeset attached 5.2.x r14730
2011-11-03 06:29 alex Note Added: 0004129
2011-11-03 06:29 alex Status reviewed and tested => resolved
2011-11-03 06:29 alex Fixed in Version => 5.2.0-B1
2011-11-03 06:29 alex Resolution open => fixed
2011-11-03 06:29 alex Assigned To !COMMUNITY => alex
2011-11-03 06:28 alex Note Added: 0004128
2011-11-03 06:28 alex Assigned To alex => !COMMUNITY
2011-11-03 06:28 alex Status needs testing => reviewed and tested
2011-11-03 06:25 alex File Added: search_all_keywords_v3.patch
2011-11-02 09:02 erik File Added: search_all_keywords_483.2.patch
2011-11-02 09:01 erik File Deleted: search_all_keywords_483.2.patch
2011-11-02 08:49 erik File Added: search_all_keywords_483.2.patch
2011-11-02 08:48 erik Note Added: 0004119
2011-11-02 08:48 erik Assigned To erik => alex
2011-11-02 08:48 erik Status needs work => needs testing
2011-11-02 04:52 alex Note Added: 0004118
2011-11-02 04:52 alex Assigned To alex => erik
2011-11-02 04:52 alex Status needs testing => needs work
2011-11-01 05:48 erik Time Estimate Removed 1 =>
2011-11-01 05:48 erik Note Added: 0004109
2011-11-01 05:48 erik Assigned To erik => alex
2011-11-01 05:48 erik Developer => erik
2011-11-01 05:48 erik Status needs work => needs testing
2011-11-01 05:47 erik File Added: search_all_keywords_483.patch
2011-10-22 05:25 alex Estimate Points => 1
2011-10-21 09:07 Dmitry Assigned To => erik
2011-10-21 09:07 Dmitry Status active => needs work
2011-09-27 05:19 alex Time Estimate Added 1
2011-09-23 21:54 Dmitry Note Added: 0003886
2011-09-23 21:54 Dmitry Target Version Icebox => 5.2.0
2009-12-23 03:18 alex Target Version => Icebox
2009-12-23 03:18 alex New Issue
2009-12-23 03:18 alex Reference =>

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker