In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000449

[In-Portal CMS] Permissions

bug report

always

2009-12-16 11:35

2010-01-11 22:01

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.0.2-B1

Status

closed

Product Version

5.0.1

Target Version

5.0.2

Time Estimate

No estimate

Summary

0000449: Category Permission Cache is calculated incorrectly on PHP5

Description

Noticed that allow/deny category permissions are used for categories,
then they are incorrectly inherited (at least CATEGORY.VIEW permission). To
inherit permission kPermCacheUpdater class assigns permission object without
reference to copy it. This approach works in PHP4, because "=" is used
instead of "=&". PHP5 always passes objects by reference even if "=&"
operator is not used. This way we got random inheritance logic.

To solve this in PHP5 "clone" operator is used, but since this should work
in PHP4 too, then serialize/unserialize is used.

Additional Information

Tested on another project, but should be tasted on 5.0.2 as well.

Tags

No tags attached.

Reference

Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/34323dc499e7b9fc

Change Log Message

Estimate Points

0

wrong_category_permissions_on_php5.patch [^] (831 bytes) 2009-12-16 11:35 [Show Content]

Index: cache_updater.php
===================================================================
--- cache_updater.php	(revision 12940)
+++ cache_updater.php	(working copy)
@@ -392,7 +392,10 @@
 				$next_data['template']			=	$data['template'];
 				$next_data['item_template']		=	$data['item_template'];
 				$next_data['current_id']		=	$data['children'][ $data['current_child'] ]; //next iteration should process child
-				$next_data['perms']				=	$data['perms']; //we should copy our permissions to child - inheritance
+
+				// TODO: use "clone" when on PHP5
+				$next_data['perms']				=	unserialize( serialize($data['perms']) ); // we should copy our permissions to child - inheritance
+
 				$next_data['perms']->SetCatId($next_data['current_id']);
 				$next_data['left'] = $data['right'];
 				$data['current_child']++;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001171) Dmitry (manager) 2009-12-20 01:38	Tested OK, please commit

(0001188) alex (manager) 2009-12-20 07:00	Fix committed to 5.0.x branch. Commit Message: Fixes 0000449: Category Permission Cache is calculated incorrectly on PHP5

(0001308) Dmitry (manager) 2010-01-11 22:01	Closing completed tasks.

Related Changesets
In-Portal CMS: 5.0.x r12958 Timestamp: 2009-12-20 07:00:57 Author: alex [ Details ] [ Diff ]	Fixes 0000449: Category Permission Cache is calculated incorrectly on PHP5
	mod - /in-portal/branches/5.0.x/core/units/categories/cache_updater.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-01-11 22:01	Dmitry	Note Added: 0001308
2010-01-11 22:01	Dmitry	Status	resolved => closed
2009-12-20 07:00	alex	Note Added: 0001188
2009-12-20 07:00	alex	Status	reviewed and tested => resolved
2009-12-20 07:00	alex	Fixed in Version	=> 5.0.2-B1
2009-12-20 07:00	alex	Resolution	open => fixed
2009-12-20 07:00	alex	Assigned To	!COMMUNITY => alex
2009-12-20 07:00	alex	Changeset attached	5.0.x r12958
2009-12-20 01:38	Dmitry	Note Added: 0001171
2009-12-20 01:38	Dmitry	Status	needs testing => reviewed and tested
2009-12-16 11:35	Dmitry	Reporter	Dmitry => alex
2009-12-16 11:35	Dmitry	Status	needs work => needs testing
2009-12-16 11:35	Dmitry	New Issue
2009-12-16 11:35	Dmitry	Status	active => needs work
2009-12-16 11:35	Dmitry	Assigned To	=> !COMMUNITY
2009-12-16 11:35	Dmitry	File Added: wrong_category_permissions_on_php5.patch
2009-12-16 11:35	Dmitry	Reference	=> Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/34323dc499e7b9fc

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group