In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000445 [In-Portal CMS] Other bug report always 2009-12-16 10:40 2011-03-14 02:10
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.0.2-B1
Status closed Product Version 5.0.1 Target Version 5.0.2
Time EstimateNo estimate
Summary 0000445: Enable Mod-rewrite for Front-end in Admin
Description Currently mod-rewrite mode (on/off) is ignored, when Front-End is viewed via
right frame in administrative console. This is no big deal, because all url
building methods build urls, that will work in both cases (with and without
mod-rewrite). But, with new rewrite listener approach (added in 5.0.1) we
could came across situation, when developer could create such rewrite
listener, that must be always present for customized urls to work. See
example provided below:

Example #1:
mod-rewrite off:
http://www.site.com/index.php?env=-path/to/template:m555--2--s-
mod-rewrite on:
http://www.site.com/russian/path/to/category/path/to/template.html

In example #1 such transformation to url happens:

   - "-2-" is language id, which is transformed to "/russian/";
   - "m555" is category id, which is transformed to "/path/to/category/";
   - "path/to/template" is just added to url's ending without
   transformations.

In this scenario url parser/builder always could determine what url part is
transformed/parsed to what ID or any other environment variable ("env"
variable in non-mod-rewrite url) part.

Example #2:
mod-rewrite off:
http://www.site.com/index.php?env=-path/to/template:m0--1--s-
mod-rewrite on: http://www.site.com/completely/different/template.html

In example #2 only one transformation happens: real template named
"path/to/template" is replaced with nice (to create SEO urls) name
"completely/different/template", which of course doesn't exist on disk.
Using this approach only rewrite listener (which made transformation) knows
what real templates should be used for each of given virtual urls.
If mod-rewrite is turned off, then such url won't work (in case if someone
placed direct link to it). Based on my experience I could say, that, when
mod-rewrite is enabled on site, that it's never going to be disabled.

So, for large projects, when there is very complex url building/parsing
schemes it's hard to always track url compatibility between mod-rewrite and
non-mod-rewrite modes.

Based on all above I propose to use mod-rewrite urls even, when Front-End is
viewed in right frame in administrative console (see attached patch).
Additional Information
Tags No tags attached.
Reference Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e00f519eaed911f9
Change Log Message
Estimate Points 0
Attached Files patch file icon admin_rewrite_urls.patch [^] (652 bytes) 2009-12-16 10:40 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
child of 0000098closed (5.0.1)alex Redo Mod-Rewrite for Better Flexibility 

-  Notes
User avatar (0001178)
Dmitry (manager)
2009-12-20 02:04

 Tested good!
User avatar (0001182)
alex (manager)
2009-12-20 06:51

 Fix committed to 5.0.x branch. Commit Message:

1. Fixes 0000445: Enable Mod-rewrite for Front-end in Admin
2. It seems, that Dmitry haven't found several bugs in this patch:
- phrase editing won't working
- edit block/edit design won't working
- whole template editing (index) won't working in "Design Mode"
User avatar (0001313)
Dmitry (manager)
2010-01-11 22:01

 Closing completed tasks.

- Related Changesets
In-Portal CMS: 5.0.x r12953
Timestamp: 2009-12-20 06:51:32
Author: alex
[ Details ] [ Diff ] 		1. Fixes 0000445: Enable Mod-rewrite for Front-end in Admin
2. It seems, that Dmitry haven't found several bugs in this patch:
- phrase editing won't working
- edit block/edit design won't working
- whole template editing (index) won't working in "Design Mode"
mod - /in-portal/branches/5.0.x/core/kernel/application.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/kernel/utility/http_query.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2011-03-14 02:10 alex Relationship added child of 0000098
2010-01-11 22:01 Dmitry Note Added: 0001313
2010-01-11 22:01 Dmitry Status resolved => closed
2009-12-20 06:51 alex Note Added: 0001182
2009-12-20 06:51 alex Status reviewed and tested => resolved
2009-12-20 06:51 alex Fixed in Version => 5.0.2-B1
2009-12-20 06:51 alex Resolution open => fixed
2009-12-20 06:51 alex Assigned To !COMMUNITY => alex
2009-12-20 06:51 alex Changeset attached 5.0.x r12953
2009-12-20 02:04 Dmitry Note Added: 0001178
2009-12-20 02:04 Dmitry Status needs testing => reviewed and tested
2009-12-16 10:41 Dmitry Reporter Dmitry => alex
2009-12-16 10:41 Dmitry Status needs work => needs testing
2009-12-16 10:40 Dmitry New Issue
2009-12-16 10:40 Dmitry Status active => needs work
2009-12-16 10:40 Dmitry Assigned To => !COMMUNITY
2009-12-16 10:40 Dmitry File Added: admin_rewrite_urls.patch
2009-12-16 10:40 Dmitry Reference => Google Groups http://groups.google.com/group/in-portal-bugs/browse_thread/thread/e00f519eaed911f9

Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker