In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

Change Log Message

Estimate Points

Attached Files

sitemap_broken.png [^] (723 bytes) 2009-11-03 13:40

sitemap_ok.png [^] (2,515 bytes) 2009-11-03 13:41

broken_sitemap_v1.patch [^] (4,553 bytes) 2009-11-03 13:46 [Show Content]

Index: core/units/categories/categories_tag_processor.php
===================================================================
--- core/units/categories/categories_tag_processor.php	(revision 12872)
+++ core/units/categories/categories_tag_processor.php	(working copy)
@@ -378,7 +378,10 @@
 
 	function BuildListSpecial($params)
 	{
-		if ($this->Special != '') {
+		if (($this->Special != '') && !is_numeric($this->Special)) {
+			// When recursive category list is printed (like in sitemap), then special
+			// should be generated even if it's already present. Without it list on this
+			// level will erase list on previous level, because it will be stored in same object.
 			return $this->Special;
 		}
 
Index: themes/advanced/platform/elements/categories.elm.tpl
===================================================================
--- themes/advanced/platform/elements/categories.elm.tpl	(revision 12866)
+++ themes/advanced/platform/elements/categories.elm.tpl	(working copy)
@@ -82,52 +82,25 @@
 
 <!--## SITEMAP ELEMENTS ##-->
 <inp2:m_DefineElement name="more_link_elem">
-<li>
-	<a href="<inp2:c_CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:m_Phrase label="lu_more"/>...</a>
-</li>
+	<li>
+		<a href="<inp2:c_CategoryLink template='__default__' m_cat_page='1'/>" class="sub-category"><inp2:m_Phrase label="lu_more"/>...</a>
+	</li>
 </inp2:m_DefineElement>
 
-<inp2:m_DefineElement name="sitemap_category_element3">
-<li>
-	<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>1
-</li>
-</inp2:m_DefineElement>
+<inp2:m_DefineElement name="sitemap_category_element" level_var="sitemap_level" max_levels="0">
+	<li>
+		<a href="<inp2:CategoryLink template='__default__' m_cat_page='1'/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>
 
-<inp2:m_DefineElement name="sitemap_category_element2">
-<li>
-	<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>
-	<inp2:InitList requery="1"/>
-	<inp2:m_if check="TotalRecords">
-	<ul>
-		<inp2:ListCategories render_as="sitemap_category_element2" more_link_render_as="more_link_elem" max_items="50" no_table="1"/>
-	</ul>
-	</inp2:m_if>
-</li>
-</inp2:m_DefineElement>
+		<inp2:m_ifnot check="m_Get" name="$level_var" equals_to="$max_levels">
+			<inp2:InitList requery="1" per_page="50"/>
 
-<inp2:m_DefineElement name="sitemap_category_element1">
-<li>
-	<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>
-	<inp2:InitList requery="1"/>
-	<inp2:m_if check="TotalRecords">
-	<ul>
-		<inp2:ListCategories render_as="sitemap_category_element2" max_items="50" more_link_render_as="more_link_elem" no_table="1"/>
-	</ul>
-	</inp2:m_if>
-</li>
-</inp2:m_DefineElement>
-
-<inp2:m_DefineElement name="sitemap_category_element">
-	<li>
-		<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/> (level 2)</a>
-		<inp2:InitList requery="1" max_items="50" />
-		<inp2:m_if check="TotalRecords">
-		<ul>
-			<inp2:ListCategories render_as="sitemap_category_element1" max_items="100" more_link_render_as="more_link_elem" no_table="1"/>
-		</ul>
-		</inp2:m_if>
+			<inp2:m_if check="TotalRecords">
+				<ul>
+					<inp2:m_Inc param="$level_var" by="1"/>
+					<inp2:PrintList render_as="sitemap_category_element" max_levels="$max_levels" more_link_render_as="more_link_elem"/>
+				</ul>
+			</inp2:m_if>
+		</inp2:m_ifnot>
 	</li>
 </inp2:m_DefineElement>
-
-
-<!--## //SITEMAP ELEMENTS ##-->
+<!--## //SITEMAP ELEMENTS ##-->
\ No newline at end of file
Index: themes/advanced/platform/sitemap.tpl
===================================================================
--- themes/advanced/platform/sitemap.tpl	(revision 12866)
+++ themes/advanced/platform/sitemap.tpl	(working copy)
@@ -43,11 +43,10 @@
 				<inp2:m_include template="platform/elements/categories.elm"/>
 
 				<div id="sitemap">
-
-				<ul>
-					<inp2:c_ListCategories types="menu" render_as="sitemap_category_element" per_page="100" columns="1" direction="H" parent_cat_id="0" no_table="1"/>
-				</ul>
-
+					<ul>
+						<inp2:m_Set sitemap_level="0"/>
+						<inp2:c_PrintList types="menu" render_as="sitemap_category_element" max_levels="3" per_page="100" parent_cat_id="0"/>
+					</ul>
 				</div>
 			</inp2:m_RenderElement>
 		</div>

421-Sitemap_broken-2009_11_09_DmitryA_v1.patch [^] (6,096 bytes) 2009-11-09 20:29 [Show Content]

Index: themes/simple/sitemap.tpl
===================================================================
--- themes/simple/sitemap.tpl	(revision 12879)
+++ themes/simple/sitemap.tpl	(working copy)
@@ -13,16 +13,33 @@
 			<div class="content">
 				<h1 class="movable-header"><inp2:st_PageInfo type="title"/></h1>
 				<inp2:st_ContentBlock num="1"/>
-
-				<inp2:m_DefineElement name="sitemap_element">
-	 				<li>
-	 					<a href="<inp2:m_Link template='$template' m_cat_id='$cat_id' use_section='$use_section' m_cat_page='1'/>" title="<inp2:m_Param name="title"/>"><inp2:m_Param name="title"/></a>
-	   				</li>
- 				</inp2:m_DefineElement>
-
- 				<ul>
-					<inp2:st_CachedMenu render_as="sitemap_element" category_id="1" per_page="-1"/>
-				</ul>
+				                
+                <inp2:m_DefineElement name="more_link_elem">
+                	<li>
+                		<a href="<inp2:c_CategoryLink template='__default__' m_cat_page='1'/>" class="sub-category"><inp2:m_Phrase label="lu_more"/>...</a>
+                	</li>
+                </inp2:m_DefineElement>
+                
+                <inp2:m_DefineElement name="sitemap_category_element" level_var="sitemap_level" max_levels="0">
+                	<li>
+                		<a href="<inp2:CategoryLink template='__default__' m_cat_page='1'/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>
+                
+                		<inp2:m_ifnot check="m_Get" name="$level_var" equals_to="$max_levels">
+                			<inp2:InitList requery="1" per_page="50"/>
+                
+                			<inp2:m_if check="TotalRecords">
+                				<ul>
+                					<inp2:m_Inc param="$level_var" by="1"/>
+                					<inp2:PrintList render_as="sitemap_category_element" max_levels="$max_levels" more_link_render_as="more_link_elem"/>
+                				</ul>
+                			</inp2:m_if>
+                		</inp2:m_ifnot>
+                	</li>
+                </inp2:m_DefineElement>              
+				<ul>
+					<inp2:m_Set sitemap_level="0"/>
+					<inp2:c_PrintList types="menu" render_as="sitemap_category_element" max_levels="3" per_page="100" parent_cat_id="0"/>
+				</ul>				
 			</div>
 			<div class="round-bottom"></div>
 		</div>
Index: themes/advanced/platform/sitemap.tpl
===================================================================
--- themes/advanced/platform/sitemap.tpl	(revision 12879)
+++ themes/advanced/platform/sitemap.tpl	(working copy)
@@ -43,11 +43,10 @@
 				<inp2:m_include template="platform/elements/categories.elm"/>
 
 				<div id="sitemap">
-
-				<ul>
-					<inp2:c_ListCategories types="menu" render_as="sitemap_category_element" per_page="100" columns="1" direction="H" parent_cat_id="0" no_table="1"/>
-				</ul>
-
+					<ul>
+						<inp2:m_Set sitemap_level="0"/>
+						<inp2:c_PrintList types="menu" render_as="sitemap_category_element" max_levels="3" per_page="100" parent_cat_id="0"/>
+					</ul>
 				</div>
 			</inp2:m_RenderElement>
 		</div>
Index: themes/advanced/platform/elements/categories.elm.tpl
===================================================================
--- themes/advanced/platform/elements/categories.elm.tpl	(revision 12879)
+++ themes/advanced/platform/elements/categories.elm.tpl	(working copy)
@@ -82,52 +82,25 @@
 
 <!--## SITEMAP ELEMENTS ##-->
 <inp2:m_DefineElement name="more_link_elem">
-<li>
-	<a href="<inp2:c_CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:m_Phrase label="lu_more"/>...</a>
-</li>
-</inp2:m_DefineElement>
-
-<inp2:m_DefineElement name="sitemap_category_element3">
-<li>
-	<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>1
-</li>
+	<li>
+		<a href="<inp2:c_CategoryLink template='__default__' m_cat_page='1'/>" class="sub-category"><inp2:m_Phrase label="lu_more"/>...</a>
+	</li>
 </inp2:m_DefineElement>
 
-<inp2:m_DefineElement name="sitemap_category_element2">
-<li>
-	<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>
-	<inp2:InitList requery="1"/>
-	<inp2:m_if check="TotalRecords">
-	<ul>
-		<inp2:ListCategories render_as="sitemap_category_element2" more_link_render_as="more_link_elem" max_items="50" no_table="1"/>
-	</ul>
-	</inp2:m_if>
-</li>
-</inp2:m_DefineElement>
+<inp2:m_DefineElement name="sitemap_category_element" level_var="sitemap_level" max_levels="0">
+	<li>
+		<a href="<inp2:CategoryLink template='__default__' m_cat_page='1'/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>
 
-<inp2:m_DefineElement name="sitemap_category_element1">
-<li>
-	<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/></a>
-	<inp2:InitList requery="1"/>
-	<inp2:m_if check="TotalRecords">
-	<ul>
-		<inp2:ListCategories render_as="sitemap_category_element2" max_items="50" more_link_render_as="more_link_elem" no_table="1"/>
-	</ul>
-	</inp2:m_if>
-</li>
-</inp2:m_DefineElement>
+		<inp2:m_ifnot check="m_Get" name="$level_var" equals_to="$max_levels">
+			<inp2:InitList requery="1" per_page="50"/>
 
-<inp2:m_DefineElement name="sitemap_category_element">
-	<li>
-		<a href="<inp2:CategoryLink template="__default__" m_cat_page="1"/>" class="sub-category"><inp2:Field name="Name" html_escape="1"/> (level 2)</a>
-		<inp2:InitList requery="1" max_items="50" />
-		<inp2:m_if check="TotalRecords">
-		<ul>
-			<inp2:ListCategories render_as="sitemap_category_element1" max_items="100" more_link_render_as="more_link_elem" no_table="1"/>
-		</ul>
-		</inp2:m_if>
+			<inp2:m_if check="TotalRecords">
+				<ul>
+					<inp2:m_Inc param="$level_var" by="1"/>
+					<inp2:PrintList render_as="sitemap_category_element" max_levels="$max_levels" more_link_render_as="more_link_elem"/>
+				</ul>
+			</inp2:m_if>
+		</inp2:m_ifnot>
 	</li>
 </inp2:m_DefineElement>
-
-
-<!--## //SITEMAP ELEMENTS ##-->
+<!--## //SITEMAP ELEMENTS ##-->
\ No newline at end of file

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

0000320

closed (5.0.2)

alex

Special, used in tags has not effect for c/st prefixes

Notes
(0001042) alex (manager) 2009-11-03 13:51	How to test: 1. create at least 4 levels deep category structure under "Home" and under "Products" categories. 2. For categories under "Home" (you could reuse top level categories like "Directory", "News" etc.) all categories should be visible in menu. 3. For "Products" it's not required, that they should be visible in menu. 4. For sitemap you should see all only categories from 1st 3 levels (that's configurable via "max_levels" parameter in "platform/sitemap.tpl". 5. For products you should see only 2 levels (top and sub) with more... links, where there is more, then 4 subcategories. ----------------- You should create proposed category structure before patch is applied to verify, that it's really broken and patch fixes what it says.

(0001046) alex (manager) 2009-11-03 14:16	Moving to 5.0.2 as community input on beta testing phase.

(0001056) Dmitry (manager) 2009-11-09 19:47	Tested OK!

(0001058) Dmitry (manager) 2009-11-09 20:30	Please find my Patch that includes fix for Simple theme as well.

(0001061) alex (manager) 2009-11-10 02:48	Fix committed to 5.0.x branch. Commit Message: Fixes 0000421: Sitemap is broken

(0001113) alex (manager) 2009-11-13 12:57	Fix committed to 5.0.x branch. Commit Message: Fixes 0000421: Sitemap is broken

(0001126) alex (manager) 2009-11-13 13:06	Fix committed to 5.0.x branch. Commit Message: Fixes 0000421: Sitemap is broken

(0001128) alex (manager) 2009-11-13 13:33	This task was resolved multiple times, because of themes were moved into separate modules. I will revert issue status and fixed in version fields back to normal manually.

(0001328) Dmitry (manager) 2010-01-11 22:05	Closing completed tasks.

Related Changesets
In-Portal CMS: 5.0.x r12884 Timestamp: 2009-11-10 02:48:08 Author: alex [ Details ] [ Diff ]	Fixes 0000421: Sitemap is broken
	mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/advanced/platform/elements/categories.elm.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/advanced/platform/sitemap.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/simple/sitemap.tpl	[ Diff ] [ File ]

Themes :: Advanced: 5.0.x r12884 Timestamp: 2009-11-10 02:48:08 Author: alex [ Details ] [ Diff ]	Fixes 0000421: Sitemap is broken
	mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/advanced/platform/elements/categories.elm.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/advanced/platform/sitemap.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/simple/sitemap.tpl	[ Diff ] [ File ]

Themes :: Simple: 5.0.x r12884 Timestamp: 2009-11-10 02:48:08 Author: alex [ Details ] [ Diff ]	Fixes 0000421: Sitemap is broken
	mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/advanced/platform/elements/categories.elm.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/advanced/platform/sitemap.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/themes/simple/sitemap.tpl	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-01-11 22:05	Dmitry	Note Added: 0001328
2010-01-11 22:05	Dmitry	Status	resolved => closed
2009-11-13 13:33	alex	Note Added: 0001128
2009-11-13 13:33	alex	Fixed in Version	=> 5.0.2-B1
2009-11-13 13:06	alex	Note Added: 0001126
2009-11-13 13:06	alex	Changeset attached	5.0.x r12884
2009-11-13 12:57	alex	Changeset attached	5.0.x r12884
2009-11-13 12:57	alex	Note Added: 0001113
2009-11-13 12:57	alex	Fixed in Version	5.0.2-B1 =>
2009-11-10 02:48	alex	Note Added: 0001061
2009-11-10 02:48	alex	Status	reviewed and tested => resolved
2009-11-10 02:48	alex	Fixed in Version	=> 5.0.2-B1
2009-11-10 02:48	alex	Resolution	open => fixed
2009-11-10 02:48	alex	Assigned To	!COMMUNITY => alex
2009-11-10 02:48	alex	Changeset attached	5.0.x r12884
2009-11-09 20:30	Dmitry	Note Added: 0001058
2009-11-09 20:29	Dmitry	File Added: 421-Sitemap_broken-2009_11_09_DmitryA_v1.patch
2009-11-09 19:47	Dmitry	Note Added: 0001056
2009-11-09 19:47	Dmitry	Status	needs testing => reviewed and tested
2009-11-03 14:17	alex	Relationship added	related to 0000320
2009-11-03 14:16	alex	Note Added: 0001046
2009-11-03 14:16	alex	Target Version	=> 5.0.2
2009-11-03 13:51	alex	Note Added: 0001042
2009-11-03 13:51	alex	Assigned To	=> !COMMUNITY
2009-11-03 13:51	alex	Status	active => needs testing
2009-11-03 13:46	alex	File Added: broken_sitemap_v1.patch
2009-11-03 13:41	alex	File Added: sitemap_ok.png
2009-11-03 13:40	alex	File Added: sitemap_broken.png
2009-11-03 13:40	alex	New Issue

Web Development by Intechnic

In-Portal Open Source CMS