In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]  [ Related Changesets ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000407 [In-Portal CMS] Front End bug report always 2009-10-26 16:26 2010-01-11 22:01
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.0.2-B1
Status closed Product Version 5.0.1 Target Version 5.0.2
Time EstimateNo estimate
Summary 0000407: Issue with Home section
Description Some changes are require to Home section to properly fit the current setup:

1. Use data from structure page, that have "/index" as it's design. In particular we use it's name ("Home" or what ever it is) as first component of navigation bar and it's url as link for that component.

2. Don't show "Home > Home" in Nav bar when located on Home section.
Additional Information
Tags No tags attached.
Reference
Change Log Message
Estimate Points 0
Attached Files jpeg file icon EditingSectionTitleInSIMPLEAdmin-20091030.jpeg [^] (88,188 bytes) 2009-10-30 17:03


jpeg file icon EditingSectionTitleInAVANCEDAdmin-20091030.jpeg [^] (97,769 bytes) 2009-10-30 17:03


jpeg file icon EditingSectionTitle-20091030.jpeg [^] (80,896 bytes) 2009-10-30 17:03


patch file icon dupe_home_problem_display.patch [^] (5,514 bytes) 2009-11-10 04:02 [Show Content]
patch file icon duplicate_home_in_navigation_bar_v2.patch [^] (744 bytes) 2009-11-18 08:37 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
User avatar (0001012)
Dmitry (manager)
2009-10-28 01:21
edited on: 2009-10-28 01:21

 This seems to be fixed it self with patch symlink_for_physical_templates_v3.patch from 0000359
User avatar (0001019)
alex (manager)
2009-10-29 03:39

 Reminder sent to: Dmitry

Not exactly, I was fixed, when I removed code, that was setting "m_cat_id" when physical template name was used in url, because it was breaking permission check on link add review page.
User avatar (0001020)
alex (manager)
2009-10-29 03:40

 Anyway I think, that we should use "MenuTitle" field of "index" page for navigation bar, not it's "Name" field contents.
User avatar (0001021)
Dmitry (manager)
2009-10-29 10:14

 Real question is what happens when you are in Simple admin interface and not able to manage all 3 Titles, then you update 1 and other 2 are stay un-updated?
User avatar (0001022)
alex (manager)
2009-10-29 10:19
edited on: 2009-10-29 10:32

 There is fix somewhere in e_category_eh.php in 0000392 (task about page renaming), that does this:
in case if visible title field is changed and menu title and html title value matches previous title field value, then they are also updated.
User avatar (0001023)
Dmitry (manager)
2009-10-30 17:08

 Hi Alex,


I thought it would make more sense to show things visually, here it comes:

1. I had Title section created in Simple interf.

2. Renamed it (1st field only available) to New Title in Simple interf.

3. TO Test -- opened on Front End see that

4. TO Confirm -- opened Edit section in Admin in Advanced interf.


Can you confirm that this won't be happening when we apply patch from 0000392 ?
User avatar (0001053)
Dmitry (manager)
2009-11-09 01:16

 Addition to above we need to address the issue with highlighting the Home section for Default and Simple menus.

The best this can be accomplished by adjusting CachedMenu method itself so it thinks of index.tpl template as of Home section and highlights it.
User avatar (0001066)
alex (manager)
2009-11-10 04:06

 1. Both 0000407:0001023 and 0000407:0001053 fixed and commited.
2. "Home > Home" problem in navigation bar is back if you apply patch I've attached.

If you don't apply patch, then link to home page from menu will be "home.html", but from header/footer/navigation bar will be "index.html". So it seems, that we still need to fix this in this or next release.

What you think about it?
User avatar (0001079)
Dmitry (manager)
2009-11-11 02:08

 Is it possible that I can't get new patch to work as described:

http://simone1.intechnic.com/dev/SVN/5.0.x-bf/simple/index.html

Please try Home URLs
User avatar (0001083)
alex (manager)
2009-11-11 02:34

 It works as expected:
1. visit http://simone1.intechnic.com/dev/SVN/5.0.x-bf/simple/index.html
2. Site logo (which is missing) in top left corner lead to home.html and "Home" menu item also leads to home.html
3. Go to mentioned links and see "home > home" navigation bar.
User avatar (0001151)
alex (manager)
2009-11-15 05:15

 Agreed with Dmitry, that solution, where st_CachedMenu tag will always use physical template name for link to home page (e.g. "index.html") instead of structure-based name (e.g. "home.html") will be more appropriate under current conditions.
User avatar (0001156)
alex (manager)
2009-11-18 08:38

 Please use "duplicate_home_in_navigation_bar_v2.patch" for testing. This patch only affects 0000407:0001151 comment.
User avatar (0001161)
Dmitry (manager)
2009-11-25 01:15

 Please commit
User avatar (0001166)
alex (manager)
2009-12-19 04:04

 Fix committed to 5.0.x branch. Commit Message:

Fixes 0000407: Issue with Home section
User avatar (0001315)
Dmitry (manager)
2010-01-11 22:01

 Closing completed tasks.

- Related Changesets
In-Portal CMS: 5.0.x r12951
Timestamp: 2009-12-19 04:04:11
Author: alex
[ Details ] [ Diff ] 		Fixes 0000407: Issue with Home section
mod - /in-portal/branches/5.0.x/core/units/helpers/menu_helper.php [ Diff ] [ File ]
In-Portal CMS: 5.0.x r12891
Timestamp: 2009-11-10 04:01:59
Author: alex
[ Details ] [ Diff ] 		1. Bug 0000407: Issue with Home section
2. Warning about missing "page_class" parameter in design template.
mod - /in-portal/branches/5.0.x/themes/default/designs/default_design.des.tpl [ Diff ] [ File ]
Themes :: Default: 5.0.x r12891
Timestamp: 2009-11-10 04:01:59
Author: alex
[ Details ] [ Diff ] 		1. Bug 0000407: Issue with Home section
2. Warning about missing "page_class" parameter in design template.
mod - /in-portal/branches/5.0.x/themes/default/designs/default_design.des.tpl [ Diff ] [ File ]
In-Portal CMS: 5.0.x r12890
Timestamp: 2009-11-10 03:58:21
Author: alex
[ Details ] [ Diff ] 		1. Bug 0000407: Issue with Home section (comment 0000407:0001053 fix)
2. License added.
mod - /in-portal/branches/5.0.x/core/units/helpers/menu_helper.php [ Diff ] [ File ]
In-Portal CMS: 5.0.x r12889
Timestamp: 2009-11-10 03:55:04
Author: alex
[ Details ] [ Diff ] 		Bug 0000407: Issue with Home section (comment 0000407:0001023 fix)
mod - /in-portal/branches/5.0.x/core/units/categories/categories_event_handler.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2010-01-11 22:01 Dmitry Note Added: 0001315
2010-01-11 22:01 Dmitry Status resolved => closed
2009-12-19 04:04 alex Changeset attached 5.0.x r12951
2009-12-19 04:04 alex Note Added: 0001166
2009-12-19 04:04 alex Status reviewed and tested => resolved
2009-12-19 04:04 alex Fixed in Version => 5.0.2-B1
2009-12-19 04:04 alex Resolution open => fixed
2009-12-19 04:04 alex Assigned To !COMMUNITY => alex
2009-11-25 01:15 Dmitry Note Added: 0001161
2009-11-25 01:15 Dmitry Status needs testing => reviewed and tested
2009-11-18 08:38 alex Note Added: 0001156
2009-11-18 08:38 alex Assigned To alex => !COMMUNITY
2009-11-18 08:38 alex Status needs work => needs testing
2009-11-18 08:37 alex File Added: duplicate_home_in_navigation_bar_v2.patch
2009-11-15 05:15 alex Note Added: 0001151
2009-11-15 05:15 alex Assigned To Dmitry => alex
2009-11-15 05:15 alex Status needs feedback => needs work
2009-11-13 12:59 alex Changeset attached 5.0.x r12891
2009-11-11 02:34 alex Note Added: 0001083
2009-11-11 02:34 alex Assigned To alex => Dmitry
2009-11-11 02:34 alex Status needs work => needs feedback
2009-11-11 02:08 Dmitry Note Added: 0001079
2009-11-11 02:08 Dmitry Assigned To Dmitry => alex
2009-11-11 02:08 Dmitry Status needs feedback => needs work
2009-11-10 04:06 alex Note Added: 0001066
2009-11-10 04:06 alex Assigned To alex => Dmitry
2009-11-10 04:06 alex Description Updated View Revisions
2009-11-10 04:02 alex File Added: dupe_home_problem_display.patch
2009-11-10 04:01 alex Changeset attached 5.0.x r12891
2009-11-10 03:58 alex Changeset attached 5.0.x r12890
2009-11-10 03:55 alex Changeset attached 5.0.x r12889
2009-11-09 01:16 Dmitry Note Added: 0001053
2009-10-30 17:08 Dmitry Note Added: 0001023
2009-10-30 17:03 Dmitry File Added: EditingSectionTitle-20091030.jpeg
2009-10-30 17:03 Dmitry File Added: EditingSectionTitleInAVANCEDAdmin-20091030.jpeg
2009-10-30 17:03 Dmitry File Added: EditingSectionTitleInSIMPLEAdmin-20091030.jpeg
2009-10-29 10:32 alex Note Edited: 0001022 View Revisions
2009-10-29 10:19 alex Note Added: 0001022
2009-10-29 10:14 Dmitry Note Added: 0001021
2009-10-29 10:14 Dmitry Assigned To !COMMUNITY => alex
2009-10-29 10:14 Dmitry Status needs testing => needs feedback
2009-10-29 03:40 alex Note Added: 0001020
2009-10-29 03:39 alex Note Added: 0001019
2009-10-28 01:21 Dmitry Note Edited: 0001012 View Revisions
2009-10-28 01:21 Dmitry Status needs feedback => needs testing
2009-10-28 01:21 Dmitry Note Added: 0001012
2009-10-28 01:21 Dmitry Assigned To alex => !COMMUNITY
2009-10-28 01:21 Dmitry Status needs work => needs feedback
2009-10-26 16:47 alex Description Updated View Revisions
2009-10-26 16:26 Dmitry New Issue
2009-10-26 16:26 Dmitry Status active => needs work
2009-10-26 16:26 Dmitry Assigned To => alex

Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker