In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0000388

[In-Portal CMS] Front End

bug report

always

2009-10-14 08:40

2010-01-11 22:05

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.0.2-B1

Status

closed

Product Version

5.0.1

Target Version

5.0.2

Time Estimate

No estimate

Summary

0000388: National symbols are incorrectly parsed from url resulting module index page to be shown instead of section template

Description

During url parsing function mb_strtolower is used to lowercase url and database data, that is matched against it. Problem is, that mb_internral_encoding('UTF-8') function is called after url parsing, when language is already available.

Because of it mb_strtolower uses default mbstring extension encoding, that in my case was "ISO-8859-1" resulting corrupted url as the result. Because of that only urls parts (between "/") in english were parsed correctly.

This way if url is "http://www.site.com/products/baskı-urünleri.html" it's only "products" part is parsed and corresponding to that section template is shown.

Additional Information

Tags

No tags attached.

Reference

Change Log Message

Estimate Points

Attached Files

national_symbols_in_url_fix.patch [^] (1,472 bytes) 2009-10-14 08:55 [Show Content]

Index: mod_rewrite_helper.php
===================================================================
--- mod_rewrite_helper.php	(revision 12690)
+++ mod_rewrite_helper.php	(working copy)
@@ -38,6 +38,13 @@
 		var $_modulePrefix = false;
 
 		/**
+		 * Charset, used to parse url, while language is not detected from it
+		 *
+		 * @var string
+		 */
+		var $_charset = 'UTF-8';
+
+		/**
 		 * Constructor of kModRewriteHelper class
 		 *
 		 * @return kModRewriteHelper
@@ -120,7 +127,7 @@
 			}
 
 			$vars = Array ('pass' => Array ('m'));
-			$url_parts = $url ? explode('/', trim(mb_strtolower($url), '/')) : Array ();
+			$url_parts = $url ? explode('/', trim(mb_strtolower($url, $this->_charset), '/')) : Array ();
 
 			if (($this->HTTPQuery->Get('rewrite') == 'on') || !$url_parts) {
 				$this->_setDefaultValues($vars);
@@ -612,7 +619,7 @@
 
 				// 1. Set virtual page as template, this will be replaced to physical template later in kApplication::Run.
 				// 2. Don't set CachedTemplate field as template here, because we will loose original page associated with it's cms blocks!
-				$vars['t'] = strtolower( preg_replace('/^Content\//i', '', $last_category_info['NamedParentPath']) );
+				$vars['t'] = mb_strtolower( preg_replace('/^Content\//i', '', $last_category_info['NamedParentPath']), $this->_charset );
 
 				$vars['m_cat_id'] = $last_category_info['CategoryId'];
 				$vars['is_virtual'] = true; // for template from POST, strange code there!

site_charset_not_respected_in_close_popup_template.patch [^] (411 bytes) 2009-10-15 01:46 [Show Content]

Index: close_popup.tpl
===================================================================
--- close_popup.tpl	(revision 12677)
+++ close_popup.tpl	(working copy)
@@ -1,5 +1,7 @@
 <inp2:m_NoDebug/>
 <inp2:m_Set skip_last_template="1"/>
+<inp2:lang.current_Field name="Charset" result_to_var="charset"/>
+<inp2:m_Header data="Content-type: text/html; charset=$charset"/>
 <html>
 	<head>
 		<title></title>

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0000917) Dmitry (manager) 2009-10-18 02:23	Tested ok

(0000973) alex (manager) 2009-10-25 15:37	Moving to 5.0.2 release as community input during 5.0.2-B1 version testing.

(0000974) alex (manager) 2009-10-25 15:51	Fix committed to 5.0.x branch. Commit Message: Fixes 0000388: National symbols are incorrectly parsed from url resulting module index page to be shown instead of section template

(0001356) Dmitry (manager) 2010-01-11 22:05	Closing completed tasks.

Related Changesets
In-Portal CMS: 5.0.x r12787 Timestamp: 2009-10-25 15:51:17 Author: alex [ Details ] [ Diff ]	Fixes 0000388: National symbols are incorrectly parsed from url resulting module index page to be shown instead of section template
	mod - /in-portal/branches/5.0.x/core/admin_templates/incs/close_popup.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/helpers/mod_rewrite_helper.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-01-11 22:05	Dmitry	Note Added: 0001356
2010-01-11 22:05	Dmitry	Status	resolved => closed
2009-10-25 15:51	alex	Changeset attached	5.0.x r12787
2009-10-25 15:51	alex	Note Added: 0000974
2009-10-25 15:51	alex	Status	reviewed and tested => resolved
2009-10-25 15:51	alex	Fixed in Version	=> 5.0.2-B1
2009-10-25 15:51	alex	Resolution	open => fixed
2009-10-25 15:37	alex	Note Added: 0000973
2009-10-25 15:37	alex	Target Version	Icebox => 5.0.2
2009-10-18 02:23	Dmitry	Note Added: 0000917
2009-10-18 02:23	Dmitry	Assigned To	!COMMUNITY => alex
2009-10-18 02:23	Dmitry	Status	needs testing => reviewed and tested
2009-10-15 01:46	alex	File Added: site_charset_not_respected_in_close_popup_template.patch
2009-10-14 08:55	alex	Assigned To	=> !COMMUNITY
2009-10-14 08:55	alex	Status	active => needs testing
2009-10-14 08:55	alex	File Added: national_symbols_in_url_fix.patch
2009-10-14 08:40	alex	Target Version	=> Icebox
2009-10-14 08:40	alex	New Issue

Web Development by Intechnic

In-Portal Open Source CMS