In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

Change Log Message

Estimate Points

Attached Files

id_colum_filter_is_small.png [^] (58,483 bytes) 2009-08-26 03:52

ie_column_width_problem.patch [^] (6,589 bytes) 2009-10-10 18:17 [Show Content]

Index: core/admin_templates/groups/groups_edit_users.tpl
===================================================================
--- core/admin_templates/groups/groups_edit_users.tpl	(revision 12686)
+++ core/admin_templates/groups/groups_edit_users.tpl	(working copy)
@@ -86,7 +86,7 @@
 	</inp2:m_if>
 </inp2:m_DefineElement>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="g-ug" IdField="PortalUserId" grid="GroupUsers" limited_heights="1"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="g-ug" IdField="PortalUserId" grid="GroupUsers"/>
 <script type="text/javascript">
 	Grids['g-ug'].SetDependantToolbarButtons( new Array('delete') );
 	Grids['g-ug'].DblClick = function() {return false};
Index: core/admin_templates/groups/groups_list.tpl
===================================================================
--- core/admin_templates/groups/groups_list.tpl	(revision 12686)
+++ core/admin_templates/groups/groups_list.tpl	(working copy)
@@ -68,7 +68,7 @@
 </tbody>
 </table>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="g.total" IdField="GroupId" grid="Default" limited_heights="1"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="g.total" IdField="GroupId" grid="Default"/>
 <script type="text/javascript">
 	Grids['g.total'].SetDependantToolbarButtons( new Array('edit', 'delete', 'e-mail') );
 </script>
Index: core/admin_templates/logs/change_logs/change_log_list.tpl
===================================================================
--- core/admin_templates/logs/change_logs/change_log_list.tpl	(revision 12686)
+++ core/admin_templates/logs/change_logs/change_log_list.tpl	(working copy)
@@ -71,7 +71,7 @@
 	<inp2:Field field="$field" first_chars="$first_chars" nl2br="$nl2br" grid="$grid" no_special="1" format="$format"/>
 </inp2:m_DefineElement>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="change-log" IdField="ChangeLogId" grid="Default" grid_filters="1" limited_heights="1" row_class_render_as="row_class"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="change-log" IdField="ChangeLogId" grid="Default" grid_filters="1" row_class_render_as="row_class"/>
 <script type="text/javascript">
 	Grids['change-log'].SetDependantToolbarButtons( new Array('edit') );
 </script>
Index: core/admin_templates/logs/session_logs/session_log_list.tpl
===================================================================
--- core/admin_templates/logs/session_logs/session_log_list.tpl	(revision 12686)
+++ core/admin_templates/logs/session_logs/session_log_list.tpl	(working copy)
@@ -58,7 +58,7 @@
 	<a href="<inp2:m_t t="logs/change_logs/change_log_list" pass="m,change-log" grid_name="Default" custom_filters[change-log][Default][SessionLogId][like]="$sessionlog_id" change-log_event="OnSearch"/>"><inp2:Field name="AffectedItems"/></a>
 </inp2:m_DefineElement>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="session-log" IdField="SessionLogId" grid="Default" grid_filters="1" limited_heights="1" row_class_render_as="row_class"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="session-log" IdField="SessionLogId" grid="Default" grid_filters="1" row_class_render_as="row_class"/>
 <script type="text/javascript">
 	Grids['session-log'].SetDependantToolbarButtons( new Array() );
 </script>
Index: core/admin_templates/users/admins_edit_groups.tpl
===================================================================
--- core/admin_templates/users/admins_edit_groups.tpl	(revision 12686)
+++ core/admin_templates/users/admins_edit_groups.tpl	(working copy)
@@ -93,7 +93,7 @@
 	</inp2:m_if>
 </inp2:m_DefineElement>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="u-ug" IdField="GroupId" grid="Default" limited_heights="1"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="u-ug" IdField="GroupId" grid="Default"/>
 <script type="text/javascript">
 	Grids['u-ug'].SetDependantToolbarButtons( new Array('delete', 'edit', 'setprimary') );
 </script>
Index: core/admin_templates/users/Attic/group_selector.tpl
===================================================================
--- core/admin_templates/users/Attic/group_selector.tpl	(revision 12686)
+++ core/admin_templates/users/Attic/group_selector.tpl	(working copy)
@@ -38,7 +38,7 @@
 </tbody>
 </table>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="g.user" IdField="GroupId" grid="GroupSelector" limited_heights="1"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="g.user" IdField="GroupId" grid="GroupSelector"/>
 <script type="text/javascript">
 	Grids['g.user'].SetDependantToolbarButtons( new Array('select') );
 </script>
Index: core/admin_templates/users/group_selector.tpl
===================================================================
--- core/admin_templates/users/group_selector.tpl	(revision 12686)
+++ core/admin_templates/users/group_selector.tpl	(working copy)
@@ -38,7 +38,7 @@
 </tbody>
 </table>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="g.user" IdField="GroupId" grid="GroupSelector" limited_heights="1"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="g.user" IdField="GroupId" grid="GroupSelector"/>
 <script type="text/javascript">
 	Grids['g.user'].SetDependantToolbarButtons( new Array('select') );
 </script>
Index: core/admin_templates/users/users_edit_groups.tpl
===================================================================
--- core/admin_templates/users/users_edit_groups.tpl	(revision 12686)
+++ core/admin_templates/users/users_edit_groups.tpl	(working copy)
@@ -94,7 +94,7 @@
 	</inp2:m_if>
 </inp2:m_DefineElement>
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="u-ug" IdField="GroupId" grid="Default" limited_heights="1"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="u-ug" IdField="GroupId" grid="Default"/>
 <script type="text/javascript">
 	Grids['u-ug'].SetDependantToolbarButtons( new Array('delete', 'edit', 'setprimary') );
 </script>
Index: custom/admin_templates/widgets/widget_list.tpl
===================================================================
--- custom/admin_templates/widgets/widget_list.tpl	(revision 12686)
+++ custom/admin_templates/widgets/widget_list.tpl	(working copy)
@@ -128,7 +128,7 @@
 </inp2:m_DefineElement>
 
 
-<inp2:m_RenderElement name="grid" PrefixSpecial="widget" IdField="WidgetId" grid="Default" grid_filters="1" limited_heights="true" max_row_height="100"/>
+<inp2:m_RenderElement name="grid" PrefixSpecial="widget" IdField="WidgetId" grid="Default" grid_filters="1" max_row_height="100"/>
 <script type="text/javascript">
 	Grids['widget'].SetDependantToolbarButtons( new Array('edit', 'delete', 'approve', 'decline') );
 </script>

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0000419) alex (manager) 2009-09-10 03:49	Noticed also in group list in IE8 (tested in 5.0.0 release), but in compatibility mode works. Maybe it's related to amount of text in grid columns.

(0000421) Dmitry (manager) 2009-09-11 00:11	Let's see how it behaves once we put in the "width" for Grids. I have noticed similar, but it flashes for a split second and then resizes to normal in IE on my end. I'll keep an eye on this too.

(0000536) alex (manager) 2009-09-23 13:27	Seems strange, that this only affect only 1st column. Need to look closely in grid_scroller.js in all column iterations.

(0000873) alex (manager) 2009-10-10 18:27	There is some strange "limited_heights" parameter to "grid" block, that is intended to limit heights of rows for cases when there are a lot of data in cells, to prevent creating of rows with large height. Strange, but in IE it also affects column filters making some cursor workaround divs around them. Don't know why, but such divs for first filter (no matter what filter is used) always act like they don't have "width: 100%", but like "width: auto", but only for first filter only. Same divs are set for all filters. Again, I don't know how height limiting should related with column filter cursor workarounds, but it works that way. Besides it don't work in IE7 too. Such parameter was applied only for 9 lists and widget list (in screenshot) is one of them. I've removed it from that lists and all is fixed.

(0000907) Dmitry (manager) 2009-10-18 01:15	Tested ok

(0000933) alex (manager) 2009-10-20 09:01	Fix committed to 5.0.x branch. Commit Message: Fixes 0000245: Filter in ID column in grid in IE8 sometimes is resized incorrectly

(0001371) Dmitry (manager) 2010-01-11 22:05	Closing completed tasks.

Related Changesets
In-Portal CMS: 5.0.x r12714 Timestamp: 2009-10-20 09:01:27 Author: alex [ Details ] [ Diff ]	Fixes 0000245: Filter in ID column in grid in IE8 sometimes is resized incorrectly
	mod - /in-portal/branches/5.0.x/core/admin_templates/groups/groups_edit_users.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/admin_templates/groups/groups_list.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/admin_templates/logs/change_logs/change_log_list.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/admin_templates/logs/session_logs/session_log_list.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/admin_templates/users/Attic/group_selector.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/admin_templates/users/admins_edit_groups.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/admin_templates/users/group_selector.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/admin_templates/users/users_edit_groups.tpl	[ Diff ] [ File ]

Modules :: Custom: 1.0.x r12713 Timestamp: 2009-10-20 09:00:33 Author: alex [ Details ] [ Diff ]	Bug 0000245: Filter in ID column in grid in IE8 sometimes is resized incorrectly
	mod - /custom/branches/1.0.x/custom/admin_templates/widgets/widget_list.tpl	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-01-11 22:05	Dmitry	Note Added: 0001371
2010-01-11 22:05	Dmitry	Status	resolved => closed
2009-10-20 09:01	alex	Note Added: 0000933
2009-10-20 09:01	alex	Status	reviewed and tested => resolved
2009-10-20 09:01	alex	Fixed in Version	=> 5.0.2
2009-10-20 09:01	alex	Resolution	open => fixed
2009-10-20 09:01	alex	Changeset attached	5.0.x r12714
2009-10-20 09:00	alex	Changeset attached	1.0.x r12713
2009-10-18 01:15	Dmitry	Note Added: 0000907
2009-10-18 01:15	Dmitry	Assigned To	!COMMUNITY => alex
2009-10-18 01:15	Dmitry	Status	needs testing => reviewed and tested
2009-10-10 18:27	alex	Time Estimate Removed	2 =>
2009-10-10 18:27	alex	Note Added: 0000873
2009-10-10 18:27	alex	Assigned To	alex => !COMMUNITY
2009-10-10 18:27	alex	Status	active => needs testing
2009-10-10 18:17	alex	File Added: ie_column_width_problem.patch
2009-10-03 07:52	administrator	Status	reviewed and tested => active
2009-09-30 06:59	alex	Assigned To	andrew => alex
2009-09-30 06:58	alex	Status	active => reviewed and tested
2009-09-30 06:58	alex	Assigned To	=> andrew
2009-09-23 13:27	alex	Time Estimate Added	2
2009-09-23 13:27	alex	Note Added: 0000536
2009-09-11 00:11	Dmitry	Target Version	=> 5.0.2
2009-09-11 00:11	Dmitry	Note Added: 0000421
2009-09-10 03:49	alex	Note Added: 0000419
2009-08-26 03:52	alex	New Issue
2009-08-26 03:52	alex	File Added: id_colum_filter_is_small.png

Web Development by Intechnic

In-Portal Open Source CMS