In-Portal Issue Tracker

Index: kernel/db/dbitem.php
===================================================================
--- kernel/db/dbitem.php	(revision 12650)
+++ kernel/db/dbitem.php	(working copy)
@@ -323,20 +323,22 @@
 	*/
 	function GetKeyClause($method=null, $keys_hash = null)
 	{
-		if( !isset($keys_hash) ) $keys_hash = Array($this->IDField => $this->ID);
+		if (!isset($keys_hash)) {
+			$keys_hash = Array ($this->IDField => $this->ID);
+		}
 
 		$ret = '';
-		foreach($keys_hash as $field => $value)
-		{
+
+		foreach ($keys_hash as $field => $value) {
 			if (!preg_match('/\./', $field)) {
-				$ret .= '(`'.$this->TableName.'`.'.$field.' = '.$this->Conn->qstr($value).') AND ';
+				$ret .= '(`' . $this->TableName . '`.' . $field . ' = ' . $this->Conn->qstr($value) . ') AND ';
 			}
 			else {
-				$ret .= '('.$field.' = '.$this->Conn->qstr($value).') AND ';
+				$ret .= '(' . $field . ' = ' . $this->Conn->qstr($value) . ') AND ';
 			}
 		}
 
-		return preg_replace('/(.*) AND $/', '\\1', $ret);
+		return substr($ret, 0, -5);
 	}
 
 	/**
Index: kernel/utility/email_send.php
===================================================================
--- kernel/utility/email_send.php	(revision 12650)
+++ kernel/utility/email_send.php	(working copy)
@@ -585,9 +585,8 @@
 			foreach ($addresses as $name => $address) {
 				$value .= $this->QuotedPrintableEncode($name, $this->charset).' <'.$address.'>, ';
 			}
-			$value = preg_replace('/(.*),$/', '\\1', $value);
 
-			$this->SetHeader($header, $value);
+			$this->SetHeader($header, substr($value, 0, -2));
 		}
 
 
@@ -1903,10 +1902,9 @@
 			}
 
 			$value = isset($this->headers[$header_name]) ? $this->headers[$header_name] : '';
-			$value .= ', '.$this->QuotedPrintableEncode($name, $this->charset).' <'.$email.'>';
+			$value .= ', ' . $this->QuotedPrintableEncode($name, $this->charset) . ' <' . $email . '>';
 
-			$value = preg_replace('/^,(.*)/', '\\1', $value); // remove first comma
-			$this->SetHeader($header_name, $value);
+			$this->SetHeader($header_name, substr($value, 2));
 		}
 
 		/**
Index: units/admin/admin_events_handler.php
===================================================================
--- units/admin/admin_events_handler.php	(revision 12650)
+++ units/admin/admin_events_handler.php	(working copy)
@@ -820,7 +820,7 @@
 	    foreach ($a_fields AS $field_name) {
 			$fields_sql .= '`'.$field_name.'`,';
 	    }
-		$fields_sql = preg_replace('/(.*),$/', '\\1', $fields_sql);
+		$fields_sql = substr($fields_sql, 0, -1);
 		$temp = '';
 	    foreach ($a_data AS $a_row)
 	    {
@@ -828,7 +828,7 @@
 			foreach ($a_row as $field_name => $field_value) {
 				$values_sql .= $this->Conn->qstr($field_value).',';
 			}
-			$values_sql = preg_replace('/(.*),$/', '\\1', $values_sql);
+			$values_sql = substr($values_sql, 0, -1);
 			$sql = 'INSERT INTO '.$table.' ('.$fields_sql.') VALUES ('.$values_sql.');';
 			$sql = str_replace("\n", "\\n", $sql);
 			$sql = str_replace("\r", "\\r", $sql);
Index: units/helpers/cat_dbitem_export_helper.php
===================================================================
--- units/helpers/cat_dbitem_export_helper.php	(revision 12650)
+++ units/helpers/cat_dbitem_export_helper.php	(working copy)
@@ -121,7 +121,9 @@
 					$values_sql .= sprintf($sql_mask, $this->Conn->qstr($var_name), $this->Conn->qstr($var_value) );
 				}
 			}
-			$values_sql = preg_replace('/(.*),$/', '\\1', $values_sql);
+
+			$values_sql = substr($values_sql, 0, -1);
+
 			if ($values_sql) {
 				$sql = 'INSERT INTO '.$this->cacheTable.'(`CacheName`,`VarName`,`VarValue`) VALUES '.$values_sql;
 				$this->Conn->Query($sql);
@@ -391,7 +393,7 @@
 				$custom_sql .= 'custom_data.'.$ml_formatter->LangFieldName('cust_'.$custom_id).' AS cust_'.$custom_name.', ';
 			}
 
-			return preg_replace('/(.*), /', '\\1', $custom_sql);
+			return substr($custom_sql, 0, -2);
 		}
 
 		function getPlainExportSQL($count_only = false) {
@@ -464,7 +466,7 @@
 					foreach ($this->exportOptions['export_cats_ids'] as $category_id) {
 						$sql .= '(c.ParentPath LIKE "%|'.$category_id.'|%") OR ';
 					}
-					$sql = preg_replace('/(.*) OR $/', '\\1', $sql);
+					$sql = substr($sql, 0, -4);
 				}
 
 				$sql .= ' ORDER BY ci.PrimaryCat DESC'; // NEW
@@ -841,7 +843,7 @@
 						}
 
 					}
-					$where_clause = preg_replace('/(.*) AND $/', '\\1', $where_clause);
+					$where_clause = substr($where_clause, 0, -5);
 
 					$item_id = $this->getFromCache('new_ids', crc32($where_clause));
 					if (!$item_id) {
@@ -1105,7 +1107,7 @@
 					foreach ($this->exportOptions['export_cats_ids'] as $category_id) {
 						$where_clause .= '(c.ParentPath LIKE "%|'.$category_id.'|%") OR ';
 					}
-					$where_clause = preg_replace('/(.*) OR $/', '\\1', $where_clause);
+					$where_clause = substr($where_clause, 0, -4);
 				}
 			}
 			else {
Index: units/helpers/category_helper.php
===================================================================
--- units/helpers/category_helper.php	(revision 12650)
+++ units/helpers/category_helper.php	(working copy)
@@ -503,7 +503,8 @@
 				/*if ($this->Application->IsAdmin()) {
 					$page_url = preg_replace('/&(admin|editing_mode)=[\d]/', '', $page_url);
 				}*/
-			$text = preg_replace('/@@' . $page_id . '@@/', $page_url, $text);
+
+				$text = str_replace('@@' . $page_id . '@@', $page_url, $text);
 			}
 
 			return $text;
Index: units/helpers/language_import_helper.php
===================================================================
--- units/helpers/language_import_helper.php	(revision 12650)
+++ units/helpers/language_import_helper.php	(working copy)
@@ -207,9 +207,13 @@
 				}
 
 				// email events
-				if( in_array('In-Portal',$module_ids) ) unset( $module_ids[array_search('',$module_ids)] ); // for old language packs
-				$module_sql = preg_replace('/(.*) OR $/', '\\1', preg_replace('/(.*),/U', 'INSTR(Module,\'\\1\') OR ', implode(',', $module_ids).',' ) );
+				if ( in_array('In-Portal',$module_ids) ) {
+					unset( $module_ids[array_search('',$module_ids)] ); // for old language packs
+				}
 
+				$module_sql = preg_replace('/(.*),/U', 'INSTR(Module,\'\\1\') OR ', implode(',', $module_ids).',');
+				$module_sql = substr($module_sql, 0, -4);
+
 				$sql = 'SELECT EventId FROM '.$mainevents_table.' WHERE '.$module_sql;
 				$event_ids = $this->Conn->GetCol($sql);
 
Index: units/helpers/multilanguage_helper.php
===================================================================
--- units/helpers/multilanguage_helper.php	(revision 12650)
+++ units/helpers/multilanguage_helper.php	(working copy)
@@ -197,11 +197,12 @@
 
 			$sql = 'ALTER TABLE '.$table_name.' ';
 			$sql_template = 'DROP COLUMN %s, ';
+
 			foreach ($fields as $field_name) {
 				$sql .= sprintf($sql_template, $field_name);
 			}
-			$sql = preg_replace('/(.*), $/', '\\1', $sql);
-			$this->Conn->Query($sql);
+
+			$this->Conn->Query( substr($sql, 0, -2) );
 		}
 
 		/**
Index: units/helpers/spam_helper.php
===================================================================
--- units/helpers/spam_helper.php	(revision 12650)
+++ units/helpers/spam_helper.php	(working copy)
@@ -102,7 +102,7 @@
 				$ret .= '('.$field_name.' = '.$this->Conn->qstr($field_value).') AND ';
 			}
 
-			return preg_replace('/(.*) AND $/', '\\1', $ret);
+			return substr($ret, 0, -5);
 		}
 
 		/**
Index: units/permissions/permissions_tag_processor.php
===================================================================
--- units/permissions/permissions_tag_processor.php	(revision 12650)
+++ units/permissions/permissions_tag_processor.php	(working copy)
@@ -125,7 +125,7 @@
 			foreach ($perm_positions as $perm_name => $category_pos) {
 				$pos_sql .= '(#TABLE_PREFIX#.Permission = "'.$perm_name.'" AND #TABLE_PREFIX#.CatId = '.$categories[$category_pos].') OR ';
 			}
-			$pos_sql = $pos_sql ? preg_replace('/(.*) OR $/', '\\1', $pos_sql) : '0';
+			$pos_sql = $pos_sql ? substr($pos_sql, 0, -4) : '0';
 
 			// get all permissions list with iheritence status, inherited category id and permission value
 			$sql = 'SELECT 	pc.PermissionName,
Index: units/statistics/statistics_event_handler.php
===================================================================
--- units/statistics/statistics_event_handler.php	(revision 12650)
+++ units/statistics/statistics_event_handler.php	(working copy)
@@ -33,7 +33,7 @@
 			foreach ($this->Application->ModuleInfo as $module_name => $module_info) {
 				$module_list .= $this->Conn->qstr($module_name).',';
 			}
-			$module_list = preg_replace('/(.*),$/', '\\1', $module_list);
+			$module_list = substr($module_list, 0, -1);
 
 			$object->addFilter('status_filter', '%1$s.Module IN ('.$module_list.')');
 		}

Index: links_event_handler.php
===================================================================
--- links_event_handler.php	(revision 12650)
+++ links_event_handler.php	(working copy)
@@ -118,7 +118,7 @@
 				foreach ($grouping as $grouping_field) {
 					$group_key .= 'main_table.`'.$grouping_field.'` = '.$this->Conn->qstr($link_data[$grouping_field]).' AND ';
 				}
-				$group_key = preg_replace('/(.*) AND $/', '\\1', $group_key);
+				$group_key = substr($group_key, 0, -5);
 
 				if (isset($primary_links[$group_key])) {
 					$groping_error = true;
@@ -153,7 +153,7 @@
 						foreach ($categories as $category_id) {
 							$values_sql .= '('.$category_id.','.$primary_resource_id.',0),';
 						}
-						$values_sql = preg_replace('/(.*),$/', '\\1', $values_sql);
+						$values_sql = substr($values_sql, 0, -1);
 						$insert_sql = 'INSERT INTO '.TABLE_PREFIX.'CategoryItems (CategoryId,ItemResourceId,PrimaryCat) VALUES '.$values_sql;
 						$this->Conn->Query($insert_sql);
 					}