In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001424 [In-Portal CMS] Admin Interfaces task always 2012-11-05 03:38 2012-11-06 11:21
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.1-B1
Status resolved Product Version 5.1.3 Target Version 5.2.1
Time EstimateNo estimate
Summary 0001424: Inconsistent naming in "E-mail Templates" section
Description 1. In-Portal has "E-mail Templates" section, where all e-mail templates are defined.
Later via special function call developer can render each of templates and send result to e-mail address given.

But internally we call them as "e-mail events". I think we should do some renaming to have "e-mail templates" term across the system.

2. We also validate, during e-mail sending, that supplied e-mail event name has only upper case letters and dots, but we don't validate the same upon e-mail event adding/editing.

This way it's possible to enter e-mail event name, that won't be sent just because it's named incorrectly.
Additional Information
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-bugs/9q4Z2BZsW_o/discussion
Change Log Message Renames e-mail events into e-mail templates
Estimate Points 1
Attached Files patch file icon email_template_rename_core.patch [^] (275,414 bytes) 2012-11-06 11:11
patch file icon email_template_rename_modules.patch [^] (80,396 bytes) 2012-11-06 11:11 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0005256)
alex (manager)
2012-11-06 11:13

Will test all together later.
User avatar (0005257)
alex (manager)
2012-11-06 11:21

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001424: Inconsistent naming in "E-mail Templates" section

- Related Changesets
In-Portal CMS: 5.2.x r15608
Timestamp: 2012-11-06 11:21:28
Author: alex
Details ] Diff ]
Fixes 0001424: Inconsistent naming in "E-mail Templates" section
rm - /in-portal/branches/5.2.x/admin/system_presets/simple/email_events_emailevents.php
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/email_logs_email-log.php Diff ] File ]
add - /in-portal/branches/5.2.x/admin/system_presets/simple/email_templates_email-template.php File ]
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/languages_lang.php Diff ] File ]
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/phrases_phrases.php Diff ] File ]
mod - /in-portal/branches/5.2.x/admin/system_presets/simple/system_event_subscriptions_system-event-subscription.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/config/custom_variables.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/incs/form_blocks.tpl Diff ] File ]
rm - /in-portal/branches/5.2.x/core/admin_templates/languages/email_message_edit.tpl
rm - /in-portal/branches/5.2.x/core/admin_templates/languages/email_message_list.tpl
rm - /in-portal/branches/5.2.x/core/admin_templates/languages/email_message_settings.tpl
add - /in-portal/branches/5.2.x/core/admin_templates/languages/email_template_edit.tpl File ]
add - /in-portal/branches/5.2.x/core/admin_templates/languages/email_template_list.tpl File ]
add - /in-portal/branches/5.2.x/core/admin_templates/languages/email_template_settings.tpl File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/logs/email_logs/email_log_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/logs/email_logs/email_queue_list.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/mailing_lists/send_complete.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/mailing_lists/send_queue.tpl Diff ] File ]
rm - /in-portal/branches/5.2.x/core/admin_templates/regional/email_messages_edit.tpl
add - /in-portal/branches/5.2.x/core/admin_templates/regional/email_template_edit.tpl File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/regional/languages_edit_email_events.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/regional/languages_export.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/site_domains/site_domain_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/system_event_subscriptions/system_event_subscription_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_data.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/install_schema.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/remove_schema.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.sql Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/application.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/constants.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/db/cat_dbitem.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/db/cat_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/db/db_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/event_manager.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/managers/subscription_manager.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/utility/email.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/utility/logger.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/categories/categories_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/configuration/configuration_event_handler.php Diff ] File ]
rm - /in-portal/branches/5.2.x/core/units/email_events
add - /in-portal/branches/5.2.x/core/units/email_templates File ]
rm - /in-portal/branches/5.2.x/core/units/email_templates/email_event_tp.php
rm - /in-portal/branches/5.2.x/core/units/email_templates/email_events_config.php
rm - /in-portal/branches/5.2.x/core/units/email_templates/email_events_event_handler.php
add - /in-portal/branches/5.2.x/core/units/email_templates/email_template_eh.php File ]
add - /in-portal/branches/5.2.x/core/units/email_templates/email_template_tp.php File ]
add - /in-portal/branches/5.2.x/core/units/email_templates/email_templates_config.php File ]
mod - /in-portal/branches/5.2.x/core/units/forms/form_submissions/form_submissions_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/forms/forms/forms_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/forms/submission_log/submission_log_eh.php Diff ] File ]
rm - /in-portal/branches/5.2.x/core/units/helpers/email_message_helper.php
add - /in-portal/branches/5.2.x/core/units/helpers/email_template_helper.php File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/helpers_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/language_import_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/languages/languages_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/languages/languages_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/logs/email_logs/email_log_tp.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/logs/email_logs/email_logs_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/logs/system_logs/system_log_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/phrases/phrase_tp.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/phrases/phrases_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/reviews/reviews_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/site_domains/site_domain_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/spam_reports/spam_report_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/system_event_subscriptions/system_event_subscription_tp.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/system_event_subscriptions/system_event_subscriptions_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/users/users_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/users/users_item.php Diff ] File ]
Modules :: In-News: 5.2.x r15607
Timestamp: 2012-11-06 11:14:51
Author: alex
Details ] Diff ]
Bug 0001424: Inconsistent naming in "E-mail Templates" section
mod - /modules/in-news/branches/5.2.x/install/install_data.sql Diff ] File ]
Modules :: In-Link: 5.2.x r15606
Timestamp: 2012-11-06 11:14:42
Author: alex
Details ] Diff ]
Bug 0001424: Inconsistent naming in "E-mail Templates" section
mod - /modules/in-link/branches/5.2.x/install/install_data.sql Diff ] File ]
mod - /modules/in-link/branches/5.2.x/units/link_validation/link_validation_eh.php Diff ] File ]
mod - /modules/in-link/branches/5.2.x/units/links/links_event_handler.php Diff ] File ]
mod - /modules/in-link/branches/5.2.x/units/listings/listings_event_handler.php Diff ] File ]
Modules :: In-Commerce: 5.2.x r15605
Timestamp: 2012-11-06 11:14:27
Author: alex
Details ] Diff ]
Bug 0001424: Inconsistent naming in "E-mail Templates" section
mod - /w/in-commerce/branches/5.2.x/install/install_data.sql Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/affiliates/affiliates_event_handler.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/gift_certificates/gift_certificates_eh.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/orders/orders_event_handler.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/orders/orders_tag_processor.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/products/products_event_handler.php Diff ] File ]
Modules :: In-Bulletin: 5.2.x r15604
Timestamp: 2012-11-06 11:13:47
Author: alex
Details ] Diff ]
Bug 0001424: Inconsistent naming in "E-mail Templates" section
mod - /modules/in-bulletin/branches/5.2.x/install/install_data.sql Diff ] File ]
mod - /modules/in-bulletin/branches/5.2.x/units/helpers/post_helper.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.2.x/units/posts/post_eh.php Diff ] File ]
mod - /modules/in-bulletin/branches/5.2.x/units/private_messages/private_message_eh.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-11-06 11:21 alex Note Added: 0005257
2012-11-06 11:21 alex Status reviewed and tested => resolved
2012-11-06 11:21 alex Fixed in Version => 5.2.1-B1
2012-11-06 11:21 alex Resolution open => fixed
2012-11-06 11:21 alex Assigned To !COMMUNITY => alex
2012-11-06 11:21 alex Changeset attached 5.2.x r15608
2012-11-06 11:14 alex Changeset attached 5.2.x r15607
2012-11-06 11:14 alex Changeset attached 5.2.x r15606
2012-11-06 11:14 alex Changeset attached 5.2.x r15605
2012-11-06 11:13 alex Changeset attached 5.2.x r15604
2012-11-06 11:13 alex Changeset attached 5.2.x r15603
2012-11-06 11:13 alex Note Added: 0005256
2012-11-06 11:13 alex Status needs testing => reviewed and tested
2012-11-06 11:12 alex Assigned To => !COMMUNITY
2012-11-06 11:12 alex Developer => alex
2012-11-06 11:12 alex Status active => needs testing
2012-11-06 11:11 alex File Added: email_template_rename_modules.patch
2012-11-06 11:11 alex File Added: email_template_rename_core.patch
2012-11-05 03:38 alex New Issue
2012-11-05 03:38 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/9q4Z2BZsW_o/discussion
2012-11-05 03:38 alex Change Log Message => Renames e-mail events into e-mail templates
2012-11-05 03:38 alex Estimate Points => 1



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker