In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001420 [In-Portal CMS] Admin Interfaces feature request always 2012-10-22 18:02 2012-12-06 11:26
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution open Fixed in Version
Status needs testing Product Version 5.1.3 Target Version 5.3.0
Time EstimateNo estimate
Summary 0001420: Using CodeMirror on SQL Query page in Admin
Description Using CodeMirror (from http://codemirror.net/) on SQL Query page in Admin for better syntax highlighting.

Perhaps we can use the same formatting as PMA does.
Additional Information Implement this as "inp_edit_codemirror" block with "language" parameter, that would allow easily create multiple editors for needed languages on a page.
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-bugs/ckjKdgkBZbk/discussion
Change Log Message Added CodeMirror to SQL Query page in Admin
Estimate Points 0
Attached Files patch file icon code_mirror_1420.patch [^] (156,018 bytes) 2012-12-05 06:49 [Show Content]
png file icon v1_screenshot.png [^] (14,239 bytes) 2012-12-06 06:15


png file icon textarea_before_codemirror.png [^] (67,645 bytes) 2012-12-06 06:16


patch file icon code_mirror_1420_v2.patch [^] (381,496 bytes) 2012-12-06 11:23
zip file icon codemirror.zip [^] (485,071 bytes) 2012-12-06 11:23

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0005312)
alex (manager)
2012-12-05 02:42

Plan:

1. create "core/admin_templates/incs/code_mirror" folder
2. place extracted code from downloaded CodeMirror version into folder created above
3. create block "inp_edit_codemirror" in "form_blocks.tpl" file and connect CodeMirror into it (similar to "inp_edit_codepress" block)
4. carefully test new block at least using following scenarios:
- 1/2 blocks on a page and attempt to save form OR go to next tab + is validation error = content is saved
- 1/2 blocks on a page and attempt to save form OR go to next tab + no validation error = content is saved
User avatar (0005316)
erik (manager)
2012-12-05 06:50

Patch attached. Needs testing
User avatar (0005318)
alex (manager)
2012-12-06 03:56

1. edit should be of same size as textarea, that were before him (e.g. all paddings, borders, position stays same), but only internals of textarea needs to be replaced by editor

2. new block "inp_edit_codemirror" is specially called this way to allow developer to use any language he pleases, that's why we need to:
- remove default language (will force developer to choose a language)
- add all supported languages (js/css files)
- add support for specifying codemirror options via tag parameters, like it's done with "control_options" parameter in "inp_edit_textarea" block

3. enable line numbers
User avatar (0005322)
erik (manager)
2012-12-06 11:26

Fixes done. New patch version attached. Codemirror full sources attached.

- Issue History
Date Modified Username Field Change
2012-12-06 11:26 erik Note Added: 0005322
2012-12-06 11:26 erik Assigned To erik => alex
2012-12-06 11:26 erik Status needs work => needs testing
2012-12-06 11:23 erik File Added: codemirror.zip
2012-12-06 11:23 erik File Added: code_mirror_1420_v2.patch
2012-12-06 06:16 alex File Added: textarea_before_codemirror.png
2012-12-06 06:15 alex File Added: v1_screenshot.png
2012-12-06 03:56 alex Note Added: 0005318
2012-12-06 03:56 alex Assigned To alex => erik
2012-12-06 03:56 alex Status needs testing => needs work
2012-12-05 06:50 erik Note Added: 0005316
2012-12-05 06:50 erik Assigned To => alex
2012-12-05 06:50 erik Developer => erik
2012-12-05 06:50 erik Status active => needs testing
2012-12-05 06:49 erik File Added: code_mirror_1420.patch
2012-12-05 06:40 erik File Deleted: code_mirror_1420.patch
2012-12-05 06:40 erik File Added: code_mirror_1420.patch
2012-12-05 02:42 alex Note Added: 0005312
2012-11-05 03:53 alex version => 5.1.3
2012-11-05 03:53 alex Target Version Icebox => 5.3.0
2012-11-05 03:52 alex Additional Information Updated View Revisions
2012-10-22 18:02 Dmitry New Issue
2012-10-22 18:02 Dmitry Reference => https://groups.google.com/d/topic/in-portal-bugs/ckjKdgkBZbk/discussion
2012-10-22 18:02 Dmitry Change Log Message => Added CodeMirror to SQL Query page in Admin
2012-10-22 18:02 Dmitry Estimate Points => 0



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker