In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001407

[In-Portal CMS] Front End

bug report

always

2012-09-27 06:06

2012-09-27 06:08

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.1-B1

Status

resolved

Product Version

5.2.0

Target Version

5.2.1

Time Estimate

No estimate

Summary

0001407: Additional parameters lost during FormManager redirect

Description

In In-Portal 5.2.0 JavaScript class FormManager was introduced. It allows to process any form on a page using ajax instead whole page submit.

To use it you must:

* register form on a page
* handle it's submit and pass it to FormManager instead
* wrap form processing event in AjaxFormHelper::transitEvent method call

If wrapped event requested a redirect to other, then current, page then instead of doing that redirect AjaxFormHelper::transitEvent method grabs redirect url and returns is to as 'redirect_to' parameter to FormManager class.
This gives a lots of space, since FormManager class can:

* redirect url to that url
* show page from that url in div/popup

Because of FormManager is JavaScript class and AjaxFormHelper is PHP class an url in 'redirect_to' parameter must not have "&" in it.
But it does and this results in all extra url parameters lost on the page, where redirect is made.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/YYFvNtFaFWE/discussion

Change Log Message

Fixes &amp in url after redirect from FormManager

Estimate Points

1

amp_problem_in_ajaxformhelper_fix.patch [^] (879 bytes) 2012-09-27 06:06 [Show Content]

Index: units/helpers/ajax_form_helper.php
===================================================================
--- units/helpers/ajax_form_helper.php	(revision 15437)
+++ units/helpers/ajax_form_helper.php	(working copy)
@@ -82,7 +82,10 @@
 			}
 			else {
 				if ( !isset($params['redirect_to']) && ($event->redirect === true || strlen($event->redirect) > 0) ) {
-					$params['redirect_to'] = $this->Application->HREF($event->redirect, '', $event->getRedirectParams(), $event->redirectScript);
+					$redirect_to = $this->Application->HREF($event->redirect, '', $event->getRedirectParams(), $event->redirectScript);
+
+					// is used from JavaScript / redirecting, so any "&amp;" could break it
+					$params['redirect_to'] = str_replace(Array ('&amp;', '%5C'), Array ('&', '\\'), $redirect_to);
 				}
 
 				$params = array_merge($params, $event->getRedirectParams());

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0005188) alex (manager) 2012-09-27 06:07	Will test all together later.

(0005189) alex (manager) 2012-09-27 06:08	Fix committed to 5.2.x branch. Commit Message: Fixes 0001407: Additional parameters lost during FormManager redirect

Related Changesets
In-Portal CMS: 5.2.x r15546 Timestamp: 2012-09-27 06:08:18 Author: alex [ Details ] [ Diff ]	Fixes 0001407: Additional parameters lost during FormManager redirect
	mod - /in-portal/branches/5.2.x/core/units/helpers/ajax_form_helper.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-09-27 06:08	alex	Note Added: 0005189
2012-09-27 06:08	alex	Status	reviewed and tested => resolved
2012-09-27 06:08	alex	Fixed in Version	=> 5.2.1-B1
2012-09-27 06:08	alex	Resolution	open => fixed
2012-09-27 06:08	alex	Assigned To	!COMMUNITY => alex
2012-09-27 06:08	alex	Changeset attached	5.2.x r15546
2012-09-27 06:07	alex	Note Added: 0005188
2012-09-27 06:07	alex	Status	needs testing => reviewed and tested
2012-09-27 06:07	alex	Assigned To	=> !COMMUNITY
2012-09-27 06:07	alex	Developer	=> alex
2012-09-27 06:07	alex	Status	active => needs testing
2012-09-27 06:07	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/YYFvNtFaFWE/discussion
2012-09-27 06:07	alex	Description Updated	View Revisions
2012-09-27 06:06	alex	New Issue
2012-09-27 06:06	alex	File Added: amp_problem_in_ajaxformhelper_fix.patch
2012-09-27 06:06	alex	Change Log Message	=> Fixes &amp in url after redirect from FormManager
2012-09-27 06:06	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group