Anonymous | Login | Signup for a new account | 2023-09-29 05:37 CDT | ![]() |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0001395 | [In-Portal CMS] Email Templates | bug report | always | 2012-09-14 11:10 | 2012-09-14 11:13 | ||
Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Fixed in Version | 5.2.1-B1 | ||
Status | resolved | Product Version | 5.2.0-B1 | Target Version | 5.2.1 | ||
Time Estimate | No estimate | ||||||
Summary | 0001395: Too aggressive line ending normalization in plain text e-mails | ||||||
Description |
In In-Portal 5.2.0 release ability to separately enter HTML and Plain-text versions of e-mail was added. Playing around with this feature I discovered that plain text version of e-mail being severely transformed in terms of line ending before it gets sent to recipient. Here are the transformations I've found: 1. trailing line endings are replaced with a single line ending This obviously was designed from HTML version of e-mail since there new line symbols doesn't mean much (unless inside a < pre > tag of course). As a fix I've kept this behavior only for HTML version of e-mail. 2. new lines, produced due m_DefineElement tag execution are removed This is a bug, but since we only looked at HTML e-mail version where this wasn't noticeable we didn't knew this was happening at all. To test the fixes I've made I've added "Send" button (visible only in debug mode) to e-mail events list. It just sends an e-mail event. I'm sure that nobody won't be against having this button also commited. Beware, that not any e-mail event can be sent this way. For example e-mail events that rely on data to be preloaded by code which calls them would just be sent empty. |
||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | https://groups.google.com/d/topic/in-portal-bugs/sAVoUaUMNZc/discussion | ||||||
Change Log Message | Fixes stripped new lines in plain text e-mails | ||||||
Estimate Points | 1 | ||||||
Attached Files |
![]() |
||||||
|
![]() |
||||||
|
![]() |
|
![]() alex (manager) 2012-09-14 11:12 |
Will test all together later. |
![]() alex (manager) 2012-09-14 11:13 |
Fix committed to 5.2.x branch. Commit Message: Fixes 0001395: Too aggressive line ending normalization in plain text e-mails |
![]() |
|||
In-Portal CMS: 5.2.x r15542 Timestamp: 2012-09-14 11:13:22 Author: alex [ Details ] [ Diff ] |
Fixes 0001395: Too aggressive line ending normalization in plain text e-mails | ||
mod - /in-portal/branches/5.2.x/core/admin_templates/languages/email_message_list.tpl | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.2.x/core/kernel/utility/email.php | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.2.x/core/units/email_events/email_events_config.php | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.2.x/core/units/email_events/email_events_event_handler.php | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
2012-09-14 11:13 | alex | Changeset attached | 5.2.x r15542 |
2012-09-14 11:13 | alex | Note Added: 0005179 | |
2012-09-14 11:13 | alex | Status | reviewed and tested => resolved |
2012-09-14 11:13 | alex | Fixed in Version | => 5.2.1-B1 |
2012-09-14 11:13 | alex | Resolution | open => fixed |
2012-09-14 11:13 | alex | Assigned To | !COMMUNITY => alex |
2012-09-14 11:12 | alex | Relationship replaced | child of 0001003 |
2012-09-14 11:12 | alex | Relationship added | related to 0001003 |
2012-09-14 11:12 | alex | Note Added: 0005178 | |
2012-09-14 11:12 | alex | Status | needs testing => reviewed and tested |
2012-09-14 11:12 | alex | Assigned To | => !COMMUNITY |
2012-09-14 11:12 | alex | Developer | => alex |
2012-09-14 11:12 | alex | Status | active => needs testing |
2012-09-14 11:12 | alex | Reference | => https://groups.google.com/d/topic/in-portal-bugs/sAVoUaUMNZc/discussion |
2012-09-14 11:12 | alex | Description Updated | View Revisions |
2012-09-14 11:11 | alex | Description Updated | View Revisions |
2012-09-14 11:10 | alex | Description Updated | View Revisions |
2012-09-14 11:10 | alex | New Issue | |
2012-09-14 11:10 | alex | File Added: plain_text_email_line_ending_problem_fix.patch | |
2012-09-14 11:10 | alex | Change Log Message | => Fixes stripped new lines in plain text e-mails |
2012-09-14 11:10 | alex | Estimate Points | => 1 |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic![]() In-Portal Open Source CMS |