In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001378

[In-Portal CMS] Front End

bug report

always

2012-08-19 14:11

2012-08-19 14:13

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.1-B1

Status

resolved

Product Version

5.2.0

Target Version

5.2.1

Time Estimate

No estimate

Summary

0001378: Sequential user login attempts result in a notice

Description

Steps to reproduce:

1. Enable mod-rewrite.
2. Try pressing "Login" button (on a login form) twice in a row without entering any user credentials.
3. You should end with "/?env=u-\-2----" at the end of url.
3. Try to login with valid credentials.
5. Warnings below are shown.

Notice (#1): Undefined index: pass in ...\core\units\helpers\user_helper.php on line 426
Warning (#2): implode() [function.implode]: Invalid arguments passed in ...\core\units\helpers\user_helper.php on line 426

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/ZUhDmAi_kXY/discussion

Change Log Message

Fixes warnings on sequential login attempts

Estimate Points

1

warnings_on_normal_user_login_fix.patch [^] (550 bytes) 2012-08-19 14:11 [Show Content]

Index: kernel/managers/rewrite_url_processor.php
===================================================================
--- kernel/managers/rewrite_url_processor.php	(revision 15445)
+++ kernel/managers/rewrite_url_processor.php	(working copy)
@@ -371,7 +371,8 @@
 		$url_components = parse_url($string);
 
 		if ( isset($url_components['query']) ) {
-			parse_str($url_components['query'], $vars);
+			parse_str($url_components['query'], $url_params);
+			$vars = array_merge($vars, $url_params);
 		}
 
 		if ( isset($url_components['path']) ) {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

resolved (5.2.1)

Notice after user completes a login procedure

Notes
(0005143) alex (manager) 2012-08-19 14:12	Will test all together later.

(0005144) alex (manager) 2012-08-19 14:13	Fix committed to 5.2.x branch. Commit Message: Fixes 0001378: Sequential user login attempts result in a notice

Related Changesets
In-Portal CMS: 5.2.x r15520 Timestamp: 2012-08-19 14:13:05 Author: alex [ Details ] [ Diff ]	Fixes 0001378: Sequential user login attempts result in a notice
	mod - /in-portal/branches/5.2.x/core/kernel/managers/rewrite_url_processor.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-08-19 14:13	alex	Note Added: 0005144
2012-08-19 14:13	alex	Status	reviewed and tested => resolved
2012-08-19 14:13	alex	Fixed in Version	=> 5.2.1-B1
2012-08-19 14:13	alex	Resolution	open => fixed
2012-08-19 14:13	alex	Assigned To	!COMMUNITY => alex
2012-08-19 14:13	alex	Changeset attached	5.2.x r15520
2012-08-19 14:12	alex	Note Added: 0005143
2012-08-19 14:12	alex	Status	needs testing => reviewed and tested
2012-08-19 14:12	alex	Assigned To	=> !COMMUNITY
2012-08-19 14:12	alex	Developer	=> alex
2012-08-19 14:12	alex	Status	active => needs testing
2012-08-19 14:12	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/ZUhDmAi_kXY/discussion
2012-08-19 14:11	alex	Relationship added	related to 0001377
2012-08-19 14:11	alex	New Issue
2012-08-19 14:11	alex	File Added: warnings_on_normal_user_login_fix.patch
2012-08-19 14:11	alex	Change Log Message	=> Fixes warnings on sequential login attempts
2012-08-19 14:11	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group