In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001373

[In-Portal CMS] Data Management

bug report

always

2012-08-15 06:04

2012-08-15 06:07

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.1-B1

Status

resolved

Product Version

5.2.0

Target Version

5.2.1

Time Estimate

No estimate

Summary

0001373: Class kCurlHelper ignores GET parameters

Description

In following code example parameters set through setRequestData method would be ignored:

$curl_helper = $this->Application->recallObject('CurlHelper');
/* @var $curl_helper kCurlHelper */

$curl_helper->setRequestData(Array ('param1' => 'value1'));
$response = $curl_helper->Send('http://www.twitter.com');

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/iQvoSuK7sPc/discussion

Change Log Message

Fixing GET parameter processing by kCurlHelper class

Estimate Points

1

curl_ignoring_get_request_parameters_fix.patch [^] (668 bytes) 2012-08-15 06:04 [Show Content]

Index: units/helpers/curl_helper.php
===================================================================
--- units/helpers/curl_helper.php	(revision 15437)
+++ units/helpers/curl_helper.php	(working copy)
@@ -340,8 +340,14 @@
 				$this->debugMode = $log_status;
 			}
 
-			$this->connectionID = curl_init($url);
+			$request_url = $url;
 
+			if ( $this->requestMethod == self::REQUEST_METHOD_GET && $this->requestData ) {
+				$request_url .= (strpos($request_url, '?') !== false ? '&' : '?') . $this->requestData;
+			}
+
+			$this->connectionID = curl_init($request_url);
+
 			if ( $this->debugMode ) {
 				// collect page data
 				$page_data = Array ();

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

closed (5.2.0)

Headers are returned along with response, when curl requests with followLocation option sent

Notes
(0005133) alex (manager) 2012-08-15 06:07	Will test all together later.

(0005134) alex (manager) 2012-08-15 06:07	Fix committed to 5.2.x branch. Commit Message: Fixes 0001373: Class kCurlHelper ignores GET parameters

Related Changesets
In-Portal CMS: 5.2.x r15514 Timestamp: 2012-08-15 06:07:24 Author: alex [ Details ] [ Diff ]	Fixes 0001373: Class kCurlHelper ignores GET parameters
	mod - /in-portal/branches/5.2.x/core/units/helpers/curl_helper.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-08-15 06:07	alex	Changeset attached	5.2.x r15514
2012-08-15 06:07	alex	Note Added: 0005134
2012-08-15 06:07	alex	Status	reviewed and tested => resolved
2012-08-15 06:07	alex	Fixed in Version	=> 5.2.1-B1
2012-08-15 06:07	alex	Resolution	open => fixed
2012-08-15 06:07	alex	Assigned To	!COMMUNITY => alex
2012-08-15 06:07	alex	Note Added: 0005133
2012-08-15 06:07	alex	Status	needs testing => reviewed and tested
2012-08-15 06:06	alex	Relationship added	related to 0001338
2012-08-15 06:05	alex	Assigned To	=> !COMMUNITY
2012-08-15 06:05	alex	Developer	=> alex
2012-08-15 06:05	alex	Status	active => needs testing
2012-08-15 06:05	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/iQvoSuK7sPc/discussion
2012-08-15 06:04	alex	New Issue
2012-08-15 06:04	alex	File Added: curl_ignoring_get_request_parameters_fix.patch
2012-08-15 06:04	alex	Change Log Message	=> Fixing GET parameter processing by kCurlHelper class
2012-08-15 06:04	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group