In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0001368

[In-Portal CMS] Data Management

refactoring

N/A

2012-07-23 08:01

2012-07-23 08:17

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

Developer

Priority

normal

Resolution

open

Fixed in Version

Status

active

Product Version

5.2.0-RC1

Target Version

Icebox

Time Estimate

No estimate

Summary

0001368: Removing "module root category" term and related functionality

Description

Here are all places, based on code, where "RootCat" word is used. I must admit, that some of them are pretty weird and most probably were traveling from one release to another without being noticed.

1. SuggestItemLink tag - when shown on index page, then actually allows to suggest into module root category - I haven't seen suggest link on index page :))
2. IsModuleHome tag - used to display different content of category in case if that's module root category (used in In-Commerce in in-commerce/designs/section.tpl) - used for mixed themes (e.g. where in-link and in-commerce are together used). I won't be recommending such themes to be created. I vote for create e-shop themes independent from in-link themes and so on. Or at least display all top/hot and so on items on main site index page, not to each module have it's own.
3. CategorySelector tag - shows child category structure based on module root category for suggest/edit link/article page - since it don't know what category is a top, them "Home" category will be used and that will display In-News categories on In-Link suggest page
4. c_CheckModuleRoot tag - ensures that module root category is always displayed using given template (used in onlinestore theme) - never used in advanced theme, so I propose to remove it at all
5. c_CategoryLink tag - builds link to module root category - just won't be doing that anymore
6. PrintList - lists category items from module root category recursively - just will be printing from "Home" category and deeper
7. c_NavigationBar - renders module root category using separate block - that I don't know how to handle; maybe there is no need for special handling, since you could do the same by specifying different section design for category acting as module root (if any)
8. Item rendering template detection, when category not passed - get from root category of module associated with given prefix (don't recall if it even was required by someone)
9. u:OnResetPassword event redirects to thank you page with In-Commerce root category hardcoded :) - works even, when In-Commerce isn't installed, needs to be removed
10. Various places getting top product category (In-Auction, In-Commerce) - could scan all db instead

All output related usages could use Home category instead and will get same behavior.

My most concern is about CategorySelector tag.

Additional Information

Then tags "c_CheckModuleRoot" and "IsModuleHome" should be deleted, since they rely on module root categories only. Other places will get category as follows:

* when not passed, then Home category used
* when passed will use passed category
* when 0 passed, then actual ID of Home category will be used

Also we will remove interface for changing module root category (useful for websites who do an upgrade to keep what they have) and we set Home as root category for all modules during new installations.
We can keep "RootCat" column in Modules table for backwards compatibility, but don't rely on it internally.

Issue History
Date Modified	Username	Field	Change
2012-07-23 08:17	alex	Target Version	5.2.0 => Icebox
2012-07-23 08:17	alex	Reference	=> https://groups.google.com/d/topic/in-portal-dev/LDN9GQhjurY/discussion
2012-07-23 08:17	alex	Change Log Message	=> Removed module-root concept
2012-07-23 08:01	alex	New Issue
2012-07-23 08:01	alex	Estimate Points	=> 3

Relationships [ Relation Graph ] [ Dependency Graph ]