Anonymous | Login | Signup for a new account | 2023-06-03 06:53 CDT | ![]() |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0001295 | [In-Portal CMS] Front End | refactoring | N/A | 2012-05-18 05:54 | 2012-07-25 05:30 | ||
Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Fixed in Version | 5.2.0-RC1 | ||
Status | closed | Product Version | 5.2.0-B1 | Target Version | 5.2.0 | ||
Time Estimate | No estimate | ||||||
Summary | 0001295: Improvements to FormManager JavaScript class | ||||||
Description |
In In-Portal we've developed FormManager class, that is used to manage forms that are submitted and validated through ajax. I wanted to share several improvements we've made to original version we've used quite a lot over last years: * set error into a field before form is registered * set form-specific template to be used in all ajax calls * perform immediate validation for inputs on blur event, but for other controls (like radio buttons) in click event * if event, called through AjaxFormHelper::transitEvent method requested a redirect to another page (e.g. by setting $event->redirect property), then automatically perform redirect * watermarks were not removed when using immediate field validation * watermark removal code (that was called before form submit) first removed watermarks and then restored them, but should be restoring original values in these fields * error were not removed from form after it was closed by user (without submitting) |
||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | https://groups.google.com/d/topic/in-portal-dev/IHK2c-QayMk/discussion | ||||||
Change Log Message | Adds improvements to FormManager class | ||||||
Estimate Points | 1 | ||||||
Attached Files |
![]() |
||||||
|
![]() |
|
![]() |
|
![]() alex (manager) 2012-05-18 05:56 |
Will test all together later. |
![]() alex (manager) 2012-05-18 05:57 |
Fix committed to 5.2.x branch. Commit Message: Fixes 0001295: Improvements to FormManager JavaScript class |
![]() alex (manager) 2012-07-25 05:30 |
Since 5.2.0/1.2.0 versions was released. |
![]() |
|||
In-Portal CMS: 5.2.x r15357 Timestamp: 2012-05-18 05:57:04 Author: alex [ Details ] [ Diff ] |
Fixes 0001295: Improvements to FormManager JavaScript class | ||
mod - /in-portal/branches/5.2.x/core/units/helpers/ajax_form_helper.php | [ Diff ] [ File ] | ||
Themes :: Modern-Store: 1.0.x r15356 Timestamp: 2012-05-18 05:56:29 Author: alex [ Details ] [ Diff ] |
Bug 0001295: Improvements to FormManager JavaScript class | ||
mod - /themes/modern-store/branches/1.0.x/inc/js/form_manager.js | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
2012-07-25 05:30 | alex | Note Added: 0004893 | |
2012-07-25 05:30 | alex | Status | resolved => closed |
2012-05-18 05:57 | alex | Note Added: 0004661 | |
2012-05-18 05:57 | alex | Status | reviewed and tested => resolved |
2012-05-18 05:57 | alex | Fixed in Version | => 5.2.0-RC1 |
2012-05-18 05:57 | alex | Resolution | open => fixed |
2012-05-18 05:57 | alex | Assigned To | !COMMUNITY => alex |
2012-05-18 05:57 | alex | Changeset attached | 5.2.x r15357 |
2012-05-18 05:56 | alex | Changeset attached | 1.0.x r15356 |
2012-05-18 05:56 | alex | Note Added: 0004660 | |
2012-05-18 05:56 | alex | Status | needs testing => reviewed and tested |
2012-05-18 05:55 | alex | Assigned To | => !COMMUNITY |
2012-05-18 05:55 | alex | Developer | => alex |
2012-05-18 05:55 | alex | Status | active => needs testing |
2012-05-18 05:55 | alex | Reference | => https://groups.google.com/d/topic/in-portal-dev/IHK2c-QayMk/discussion |
2012-05-18 05:54 | alex | New Issue | |
2012-05-18 05:54 | alex | File Added: form_manager_improvements_core.patch | |
2012-05-18 05:54 | alex | Change Log Message | => Adds improvements to FormManager class |
2012-05-18 05:54 | alex | Estimate Points | => 1 |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic![]() In-Portal Open Source CMS |