In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001275

[In-Portal CMS] Data Management

bug report

always

2012-05-15 14:09

2012-07-25 05:30

Reporter

Dmitry

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0-RC1

Status

closed

Product Version

5.2.0-B1

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001275: User can't Subscribe to Newsletter

Description

Can't Subscribe to Newsletter due to code issues in u_OnSubscribeUser event:

Line 759 $this->RemoveRequiredFields($object);

Line 790 if ( $object->isRequired('Username') ) {
$object->SetDBField('Username', $user_email);
}

First mentioned line ensures that 'Username' field is never set, and,
as result - subscriber-user record is not created with error "username
is too short" (as fact, it is empty, so it length is 0).

Additional Information

To fix we need to check $object->isRequired('Username') before we do $this->RemoveRequiredFields($object);

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/QV-1VDJp11U/discussion

Change Log Message

Fixed user can't subscribe to newsletter

Estimate Points

0

User-cant-Subscribe-to-Newsletter.patch [^] (658 bytes) 2012-05-15 14:09 [Show Content]

Index: units/users/users_event_handler.php
===================================================================
--- units/users/users_event_handler.php	(revision 15331)
+++ units/users/users_event_handler.php	(working copy)
@@ -755,6 +755,7 @@
 				return ;
 			}
 
+			$username_required = $object->isRequired('Username');
 			$this->RemoveRequiredFields($object);
 			$object->Load($user_email, 'Email');
 
@@ -786,7 +787,7 @@
 				$object->generatePassword();
 				$object->SetDBField('Email', $user_email);
 
-				if ( $object->isRequired('Username') )	{
+				if ( $username_required )	{
 					$object->SetDBField('Username', $user_email);
 				}

User-cant-Subscribe-to-Newsletter_v2.patch [^] (829 bytes) 2012-05-29 08:57 [Show Content]

Index: units/users/users_event_handler.php
===================================================================
--- units/users/users_event_handler.php	(revision 15359)
+++ units/users/users_event_handler.php	(working copy)
@@ -755,6 +755,7 @@
 				return ;
 			}
 
+			$username_required = $object->isRequired('Username');
 			$this->RemoveRequiredFields($object);
 			$object->Load($user_email, 'Email');
 
@@ -786,8 +787,8 @@
 				$object->generatePassword();
 				$object->SetDBField('Email', $user_email);
 
-				if ( $object->isRequired('Username') )	{
-					$object->SetDBField('Username', $user_email);
+				if ( $username_required )	{
+					$object->SetDBField('Username', str_replace('@', '_at_', $user_email));
 				}
 
 				$object->SetDBField('Status', STATUS_ACTIVE); // make user subscriber Active by default

Relationships [ Relation Graph ] [ Dependency Graph ]

parent of

closed (5.2.0)

Logical changes on user registration/my profile/forgot password forms

Notes
(0004682) alex (manager) 2012-05-29 08:57	Tested, but small issue with "@" symbol present in Username field was happening and it was fixed in uploaded patch (v2).

(0004683) alex (manager) 2012-05-29 08:58	Fix committed to 5.2.x branch. Commit Message: Fixes 0001275: User can't Subscribe to Newsletter Commit on behalf of Dmitry

(0004881) alex (manager) 2012-07-25 05:30	Since 5.2.0/1.2.0 versions was released.

Related Changesets
In-Portal CMS: 5.2.x r15370 Timestamp: 2012-05-29 08:58:24 Author: alex [ Details ] [ Diff ]	Fixes 0001275: User can't Subscribe to Newsletter Commit on behalf of Dmitry
	mod - /in-portal/branches/5.2.x/core/units/users/users_event_handler.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:30	alex	Note Added: 0004881
2012-07-25 05:30	alex	Status	resolved => closed
2012-05-29 08:58	alex	Changeset attached	5.2.x r15370
2012-05-29 08:58	alex	Note Added: 0004683
2012-05-29 08:58	alex	Status	reviewed and tested => resolved
2012-05-29 08:58	alex	Fixed in Version	=> 5.2.0-RC1
2012-05-29 08:58	alex	Resolution	open => fixed
2012-05-29 08:58	alex	Assigned To	!COMMUNITY => alex
2012-05-29 08:57	alex	File Added: User-cant-Subscribe-to-Newsletter_v2.patch
2012-05-29 08:57	alex	Note Added: 0004682
2012-05-29 08:57	alex	Status	needs testing => reviewed and tested
2012-05-16 08:36	Dmitry	Assigned To	=> !COMMUNITY
2012-05-16 08:36	Dmitry	Developer	=> Dmitry
2012-05-16 08:36	Dmitry	Status	active => needs testing
2012-05-15 14:12	Dmitry	Summary	User can't Subscribe to a Newsletter => User can't Subscribe to Newsletter
2012-05-15 14:12	Dmitry	Relationship added	parent of 0001107
2012-05-15 14:09	Dmitry	New Issue
2012-05-15 14:09	Dmitry	File Added: User-cant-Subscribe-to-Newsletter.patch
2012-05-15 14:09	Dmitry	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/QV-1VDJp11U/discussion
2012-05-15 14:09	Dmitry	Change Log Message	=> Fixed user can't subscribe to newsletter
2012-05-15 14:09	Dmitry	Estimate Points	=> 0

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group