In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001241

[In-Portal CMS] Data Management

bug report

always

2012-03-30 12:28

2012-07-25 05:31

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0-B3

Status

closed

Product Version

5.2.0-B2

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001241: Automatic redirect from ?env= urls to their mod-rewrite equivalents results in fatal error

Description

When mod-rewrite mode isn't enabled all links created by In-Portal looks like http://www.domain.tld/?env=sid-template:m-.....
When mod-rewrite mode is enabled same link would look like http://www.domain.tld/template.html?sid=sid.

If you started to use In-Portal with disabled mod-rewrite mode and then, after some time, enabled it you might get into situation when visitors are coming on website using both old (with ?env=) and new (without ?env=) style links.
This usually happens, when visitors (or spiders) have bookmarked links when mod-rewrite was disabled.

To solve that problem In-Portal does automatic redirect to mod-rewrite equivalent of every non mod-rewrite link it encounters.

And during that redirect happens fatal error caused by accessing kApplication::Session attribute from kApplication::RecallVar method, since session isn't yet initialized when In-Portal decides to do that redirect.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/TAEQLMUY__o/discussion

Change Log Message

Fixes fatal error during redirect from non mod-rewrite url to mod-rewrite url

Estimate Points

1

fatal_error_on_env_to_rewrite_redirect.patch [^] (627 bytes) 2012-03-30 12:28 [Show Content]

Index: application.php
===================================================================
--- application.php	(revision 15250)
+++ application.php	(working copy)
@@ -1887,7 +1887,12 @@
 		$session = $this->recallObject('Session');
 		/* @var $session Session */
 
-		$this->HandleEvent(new kEvent('adm:OnBeforeShutdown'));
+		if ( $this->InitDone ) {
+			// if redirect happened in the middle of application initialization don't call event,
+			// that presumes that application was successfully initialized
+			$this->HandleEvent(new kEvent('adm:OnBeforeShutdown'));
+		}
+
 		$session->SaveData();
 
 		ob_end_flush();

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	0001207	closed (5.2.0)	alex	Ability to subscribe to any system event from e-mail event
child of	0000856	closed (5.2.0)	alex	Add PriorityEventHandler to Core

Notes
(0004541) alex (manager) 2012-03-30 12:31	Will test all later together.

(0004542) alex (manager) 2012-03-30 12:31	Fix committed to 5.2.x branch. Commit Message: Fixes 0001241: Automatic redirect from ?env= urls to their mod-rewrite equivalents results in fatal error

(0004941) alex (manager) 2012-07-25 05:31	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15251 Timestamp: 2012-03-30 12:31:55 Author: alex [ Details ] [ Diff ]	Fixes 0001241: Automatic redirect from ?env= urls to their mod-rewrite equivalents results in fatal error
	mod - /in-portal/branches/5.2.x/core/kernel/application.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:31	alex	Note Added: 0004941
2012-07-25 05:31	alex	Status	resolved => closed
2012-03-30 12:33	alex	Relationship added	child of 0000856
2012-03-30 12:31	alex	Note Added: 0004542
2012-03-30 12:31	alex	Status	reviewed and tested => resolved
2012-03-30 12:31	alex	Fixed in Version	=> 5.2.0-B3
2012-03-30 12:31	alex	Resolution	open => fixed
2012-03-30 12:31	alex	Assigned To	!COMMUNITY => alex
2012-03-30 12:31	alex	Changeset attached	5.2.x r15251
2012-03-30 12:31	alex	Note Added: 0004541
2012-03-30 12:31	alex	Status	needs testing => reviewed and tested
2012-03-30 12:31	alex	Relationship added	related to 0001207
2012-03-30 12:31	alex	Assigned To	=> !COMMUNITY
2012-03-30 12:31	alex	Developer	=> alex
2012-03-30 12:31	alex	Status	active => needs testing
2012-03-30 12:30	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/TAEQLMUY__o/discussion
2012-03-30 12:28	alex	New Issue
2012-03-30 12:28	alex	File Added: fatal_error_on_env_to_rewrite_redirect.patch
2012-03-30 12:28	alex	Change Log Message	=> Fixes fatal error during redirect from non mod-rewrite url to mod-rewrite url
2012-03-30 12:28	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group