In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001209

[In-Portal CMS] Database

bug report

always

2012-02-16 05:02

2012-07-25 05:31

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0-B2

Status

closed

Product Version

5.1.3

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001209: Incorrect MultiOptions grid filter value escaping

Description

I was trying to use brand new "grid_multioptions_filter" with "Module" field of "LanguageLabels" table and got SQL error instead of labels filtered by their module.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/9txC8xZUYZY/discussion

Change Log Message

Fixes broken "grid_multioptions_filter" block

Estimate Points

1

incorrect_multioptions_filter_value_escaping.patch [^] (1,060 bytes) 2012-02-16 05:02 [Show Content]

Index: units/helpers/search_helper.php
===================================================================
--- units/helpers/search_helper.php	(revision 15111)
+++ units/helpers/search_helper.php	(working copy)
@@ -632,13 +632,14 @@
 					break;
 
 				case 'multioptions':
-					$field_value = strlen($field_options['submit_value']) ? $this->Conn->escape($field_options['submit_value']) : false;
+					$field_value = $field_options['submit_value'];
 
 					if ( $field_value ) {
 						$field_value = explode('|', substr($field_value, 1, -1));
-						$field_value = $this->Conn->qstrArray($field_value, 'escape');
+						$multiple = $object->GetFieldOption($field_name, 'multiple');
+						$field_value = $this->Conn->qstrArray($field_value, $multiple ? 'escape' : 'qstr');
 
-						if ( $object->GetFieldOption($field_name, 'multiple') ) {
+						if ( $multiple ) {
 							$filter_value = $table_name . '`' . $field_name . '` LIKE "%|' . implode('|%" OR ' . $table_name . '`' . $field_name . '` LIKE "%|', $field_value) . '|%"';
 						}
 						else {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	0001196	closed (5.2.0)	alex	Improvements to Languages and Phrases Export capabilities
child of	0000816	closed (5.2.0)	alex	New grid multioptions filter

Notes
(0004462) alex (manager) 2012-02-16 05:13	Will test all together later.

(0004463) alex (manager) 2012-02-16 05:13	Fix committed to 5.2.x branch. Commit Message: Fixes 0001209: Incorrect MultiOptions grid filter value escaping

(0004974) alex (manager) 2012-07-25 05:31	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15113 Timestamp: 2012-02-16 05:13:15 Author: alex [ Details ] [ Diff ]	Fixes 0001209: Incorrect MultiOptions grid filter value escaping
	mod - /in-portal/branches/5.2.x/core/units/helpers/search_helper.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:31	alex	Note Added: 0004974
2012-07-25 05:31	alex	Status	resolved => closed
2012-02-16 05:13	alex	Note Added: 0004463
2012-02-16 05:13	alex	Status	reviewed and tested => resolved
2012-02-16 05:13	alex	Fixed in Version	=> 5.2.0-B2
2012-02-16 05:13	alex	Resolution	open => fixed
2012-02-16 05:13	alex	Assigned To	!COMMUNITY => alex
2012-02-16 05:13	alex	Changeset attached	5.2.x r15113
2012-02-16 05:13	alex	Note Added: 0004462
2012-02-16 05:13	alex	Status	needs testing => reviewed and tested
2012-02-16 05:12	alex	Assigned To	=> !COMMUNITY
2012-02-16 05:12	alex	Developer	=> alex
2012-02-16 05:12	alex	Status	active => needs testing
2012-02-16 05:12	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/9txC8xZUYZY/discussion
2012-02-16 05:03	alex	Relationship added	child of 0000816
2012-02-16 05:03	alex	Relationship added	related to 0001196
2012-02-16 05:02	alex	New Issue
2012-02-16 05:02	alex	File Added: incorrect_multioptions_filter_value_escaping.patch
2012-02-16 05:02	alex	Change Log Message	=> Fixes broken "grid_multioptions_filter" block
2012-02-16 05:02	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group