In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001172

[In-Portal CMS] Database

bug report

always

2011-11-27 13:13

2012-07-25 05:32

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0-B1

Status

closed

Product Version

5.1.3

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001172: Incorrect SQL when item load clause contains NULL

Description

There are multiple ways to load record information from database:

1. by specifying Primary Keys value
2. by specifying value of a given field
3. by specifying a hash of field-value pairs that all must match for a loaded item

It all works until the value, used to load an item is set to NULL instead of string or number as usual.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/_CDwRSvfsDE/discussion

Change Log Message

Fixes NULL value load attempt failure in kDBItem class

Estimate Points

1

null_dbitem_load_fix.patch [^] (721 bytes) 2011-11-27 13:13 [Show Content]

Index: dbitem.php
===================================================================
--- dbitem.php	(revision 14795)
+++ dbitem.php	(working copy)
@@ -353,12 +353,9 @@
 		$ret = '';
 
 		foreach ($keys_hash as $field => $value) {
-			if ( !preg_match('/\./', $field) ) {
-				$ret .= '(`' . $this->TableName . '`.' . $field . ' = ' . $this->Conn->qstr($value) . ') AND ';
-			}
-			else {
-				$ret .= '(' . $field . ' = ' . $this->Conn->qstr($value) . ') AND ';
-			}
+			$value_part = is_null($value) ? ' IS NULL' : ' = ' . $this->Conn->qstr($value);
+
+			$ret .= '(' . (strpos($field, '.') === false ? '`' . $this->TableName . '`.' : '') . $field . $value_part . ') AND ';
 		}
 
 		return substr($ret, 0, -5);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004175) alex (manager) 2011-11-27 13:15	Will test all together later.

(0004176) alex (manager) 2011-11-27 13:15	Fix committed to 5.2.x branch. Commit Message: Fixes 0001172: Incorrect SQL when item load clause contains NULL

(0005046) alex (manager) 2012-07-25 05:32	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14799 Timestamp: 2011-11-27 13:15:42 Author: alex [ Details ] [ Diff ]	Fixes 0001172: Incorrect SQL when item load clause contains NULL
	mod - /in-portal/branches/5.2.x/core/kernel/db/dbitem.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:32	alex	Note Added: 0005046
2012-07-25 05:32	alex	Status	resolved => closed
2011-11-27 13:15	alex	Note Added: 0004176
2011-11-27 13:15	alex	Status	reviewed and tested => resolved
2011-11-27 13:15	alex	Fixed in Version	=> 5.2.0-B1
2011-11-27 13:15	alex	Resolution	open => fixed
2011-11-27 13:15	alex	Assigned To	!COMMUNITY => alex
2011-11-27 13:15	alex	Changeset attached	5.2.x r14799
2011-11-27 13:15	alex	Note Added: 0004175
2011-11-27 13:15	alex	Status	needs testing => reviewed and tested
2011-11-27 13:15	alex	Assigned To	=> !COMMUNITY
2011-11-27 13:15	alex	Developer	=> alex
2011-11-27 13:15	alex	Status	active => needs testing
2011-11-27 13:14	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/_CDwRSvfsDE/discussion
2011-11-27 13:13	alex	New Issue
2011-11-27 13:13	alex	File Added: null_dbitem_load_fix.patch
2011-11-27 13:13	alex	Change Log Message	=> Fixes NULL value load attempt failure in kDBItem class
2011-11-27 13:13	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group