In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001104

[In-Portal CMS] Data Management

bug report

always

2011-08-17 05:05

2011-09-19 16:08

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.3

Status

closed

Product Version

5.1.3-RC2

Target Version

5.1.3

Time Estimate

No estimate

Summary

0001104: Impossible to use OnAfterConfigRead event, when there is a system preset for a given unit config

Description

It's impossible to use OnAfterConfigRead event, when there is a system preset for a given unit config.

For example this code in EUserEventHandler::OnAfterConfigRead method, used to make user's first name required:

$fields = $this->Application->getUnitOption($event->Prefix, 'Fields');
$fields['FirstName']['required'] = 1;
$this->Application->setUnitOption($event->Prefix, 'Fields', $fields);

has no effect, when current system preset (e.g. "simple" system preset) has "users_u.php" that resets all required fields anyway.

To solve that I'm proposing to apply system preset imposed changed before calling OnAfterConfigRead event. This way any code in OnAfterConfigRead even will override whatever system preset is imposing.

That's how it worked before system presets were invented.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/EDa93FXm49c/discussion

Change Log Message

Fixes some code of OnAfterConfigRead event was overwritten from system preset problem

Estimate Points

0

apply_system_presets_before_onafterconfigread_event_called.patch [^] (727 bytes) 2011-08-17 05:05 [Show Content]

Index: units/sections/sections_config.php
===================================================================
--- units/sections/sections_config.php	(revision 14476)
+++ units/sections/sections_config.php	(working copy)
@@ -21,7 +21,7 @@
 
 		'Hooks' => Array (
 			Array (
-				'Mode' => hAFTER,
+				'Mode' => hBEFORE,
 				'Conditional' => false,
 				'HookToPrefix' => '*',
 				'HookToSpecial' => '*',
@@ -219,7 +219,7 @@
 				'parent'		=>	'in-portal:tools',
 				'icon'			=>	'import_data',
 				'label'			=>	'la_tab_ImportData',
-				'url'			=>	Array ('t' => 'tools/import1'),				
+				'url'			=>	Array ('t' => 'tools/import1'),
 				'permissions'	=>	Array ('view'),
 				'priority'		=>	3,
 				'type'			=>	stTREE,

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	0000964	closed (5.2.0)	alex	Improvements to user Login field
child of	0000199	closed (5.0.1)	alex	Create a Switch between "Site Configs"

Notes
(0003684) Dmitry (manager) 2011-08-23 18:02	Tested okay. Please commit.

(0003691) alex (manager) 2011-08-24 02:39	Fix committed to 5.1.x branch. Commit Message: Fixes 0001104: Impossible to use OnAfterConfigRead event, when there is a system preset for a given unit config

(0003789) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14506 Timestamp: 2011-08-24 02:39:52 Author: alex [ Details ] [ Diff ]	Fixes 0001104: Impossible to use OnAfterConfigRead event, when there is a system preset for a given unit config
	mod - /in-portal/branches/5.1.x/core/units/sections/sections_config.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003789
2011-09-19 16:08	alex	Status	resolved => closed
2011-09-02 07:30	alex	Relationship added	related to 0000964
2011-08-24 02:39	alex	Note Added: 0003691
2011-08-24 02:39	alex	Status	reviewed and tested => resolved
2011-08-24 02:39	alex	Fixed in Version	=> 5.1.3
2011-08-24 02:39	alex	Resolution	open => fixed
2011-08-24 02:39	alex	Assigned To	!COMMUNITY => alex
2011-08-24 02:39	alex	Changeset attached	5.1.x r14506
2011-08-23 18:02	Dmitry	Note Added: 0003684
2011-08-23 18:02	Dmitry	Status	needs testing => reviewed and tested
2011-08-17 05:09	alex	Relationship added	child of 0000199
2011-08-17 05:06	alex	Assigned To	=> !COMMUNITY
2011-08-17 05:06	alex	Developer	=> alex
2011-08-17 05:06	alex	Status	active => needs testing
2011-08-17 05:06	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/EDa93FXm49c/discussion
2011-08-17 05:05	alex	New Issue
2011-08-17 05:05	alex	File Added: apply_system_presets_before_onafterconfigread_event_called.patch
2011-08-17 05:05	alex	Change Log Message	=> Fixes some code of OnAfterConfigRead event was overwritten from system preset problem

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group