In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/Wl3z8zvaInQ/discussion

Change Log Message

Fixes problem, when "Home" and "Go Up" buttons were not disabled in time

Estimate Points

Attached Files

disable_homeup_buttons_core.patch [^] (1,809 bytes) 2011-07-18 03:10 [Show Content]

Index: admin_templates/catalog_tab.tpl
===================================================================
--- admin_templates/catalog_tab.tpl	(revision 14472)
+++ admin_templates/catalog_tab.tpl	(working copy)
@@ -73,16 +73,8 @@
 		<inp2:m_RenderElement name="grid_search_buttons" PrefixSpecial="$prefix" grid="$grid_name" ajax="1"/>
 
 		Grids['<inp2:m_param name="prefix"/>'].SetDependantToolbarButtons( new Array('edit','delete','approve','decline','sep3','cut','copy','move_up','move_down','sep6'));
+		<inp2:m_RenderElement name="reflect_catalog_buttons"/>
 
-		<inp2:m_if check="{$prefix}_ModuleRootCategory">
-			a_toolbar.DisableButton('upcat');
-			a_toolbar.DisableButton('homecat');
-		<inp2:m_else/>
-			a_toolbar.EnableButton('upcat');
-			a_toolbar.EnableButton('homecat');
-		</inp2:m_if>
-		$Catalog.reflectPasteButton(<inp2:$prefix_HasClipboard/>);
-
 		<inp2:m_if check="m_Recall" name="root_delete_error">
 			alert('<inp2:m_Phrase name="la_error_RootCategoriesDelete"/>');
 			<inp2:m_RemoveVar name="root_delete_error"/>
Index: admin_templates/categories/ci_blocks.tpl
===================================================================
--- admin_templates/categories/ci_blocks.tpl	(revision 14472)
+++ admin_templates/categories/ci_blocks.tpl	(working copy)
@@ -75,4 +75,16 @@
 	</inp2:m_if>
 
 	$menu_frame.SyncActive('<inp2:m_t pass="m" m_opener="r"/>');
+</inp2:m_DefineElement>
+
+<inp2:m_DefineElement name="reflect_catalog_buttons">
+	<inp2:m_if check="c_ModuleRootCategory">
+		a_toolbar.DisableButton('upcat');
+		a_toolbar.DisableButton('homecat');
+	<inp2:m_else/>
+		a_toolbar.EnableButton('upcat');
+		a_toolbar.EnableButton('homecat');
+	</inp2:m_if>
+
+	$Catalog.reflectPasteButton(<inp2:c_HasClipboard/>);
 </inp2:m_DefineElement>
\ No newline at end of file

disable_homeup_buttons_modules.patch [^] (3,508 bytes) 2011-07-18 03:10 [Show Content]

Index: in-bulletin/admin_templates/catalog_tab.tpl
===================================================================
--- in-bulletin/admin_templates/catalog_tab.tpl	(revision 14472)
+++ in-bulletin/admin_templates/catalog_tab.tpl	(working copy)
@@ -39,7 +39,8 @@
 			Grids['<inp2:m_param name="prefix"/>'].AddAlternativeGrid('<inp2:m_param name="cat_prefix"/>', true);
 		</inp2:m_if>
 		Grids['<inp2:m_param name="prefix"/>'].SetDependantToolbarButtons( new Array('edit','delete','approve','decline','sep3','cut','copy','move_up','move_down','sep6'));
-		$Catalog.reflectPasteButton(<inp2:c_HasClipboard/>);
+		<inp2:m_RenderElement name="reflect_catalog_buttons"/>
+
 		$Catalog.setViewMenu('<inp2:m_param name="prefix"/>');
 		<inp2:m_if check="m_ParamEquals" name="tab_mode" value="single">
 			Grids['<inp2:m_param name="prefix"/>'].DblClick = function() {return false};
Index: in-commerce/admin_templates/catalog_tab.tpl
===================================================================
--- in-commerce/admin_templates/catalog_tab.tpl	(revision 14472)
+++ in-commerce/admin_templates/catalog_tab.tpl	(working copy)
@@ -84,7 +84,8 @@
 			Grids['<inp2:m_param name="prefix"/>'].AddAlternativeGrid('<inp2:m_param name="cat_prefix"/>', true);
 		</inp2:m_if>
 		Grids['<inp2:m_param name="prefix"/>'].SetDependantToolbarButtons( new Array('edit','delete','approve','decline','sep3','cut','copy','move_up','move_down','sep6'));
-		$Catalog.reflectPasteButton(<inp2:c_HasClipboard/>);
+		<inp2:m_RenderElement name="reflect_catalog_buttons"/>
+
 		$Catalog.setViewMenu('<inp2:m_param name="prefix"/>');
 		<inp2:m_if check="m_ParamEquals" name="tab_mode" value="single">
 			Grids['<inp2:m_param name="prefix"/>'].DblClick = function() {return false};
Index: in-link/admin_templates/catalog_tab.tpl
===================================================================
--- in-link/admin_templates/catalog_tab.tpl	(revision 14472)
+++ in-link/admin_templates/catalog_tab.tpl	(working copy)
@@ -38,7 +38,8 @@
 			Grids['<inp2:m_param name="prefix"/>'].AddAlternativeGrid('<inp2:m_param name="cat_prefix"/>', true);
 		</inp2:m_if>
 		Grids['<inp2:m_param name="prefix"/>'].SetDependantToolbarButtons( new Array('edit','delete','approve','decline','sep3','cut','copy','move_up','move_down','sep6'));
-		$Catalog.reflectPasteButton(<inp2:c_HasClipboard/>);
+		<inp2:m_RenderElement name="reflect_catalog_buttons"/>
+
 		$Catalog.setViewMenu('<inp2:m_param name="prefix"/>');
 		<inp2:m_if check="m_ParamEquals" name="tab_mode" value="single">
 			Grids['<inp2:m_param name="prefix"/>'].DblClick = function() {return false};
Index: in-news/admin_templates/catalog_tab.tpl
===================================================================
--- in-news/admin_templates/catalog_tab.tpl	(revision 14472)
+++ in-news/admin_templates/catalog_tab.tpl	(working copy)
@@ -47,7 +47,8 @@
 			Grids['<inp2:m_param name="prefix"/>'].AddAlternativeGrid('<inp2:m_param name="cat_prefix"/>', true);
 		</inp2:m_if>
 		Grids['<inp2:m_param name="prefix"/>'].SetDependantToolbarButtons( new Array('edit','delete','approve','decline','sep3','cut','copy','move_up','move_down','sep6'));
-		$Catalog.reflectPasteButton(<inp2:c_HasClipboard/>);
+		<inp2:m_RenderElement name="reflect_catalog_buttons"/>
+
 		$Catalog.setViewMenu('<inp2:m_param name="prefix"/>');
 		<inp2:m_if check="m_ParamEquals" name="tab_mode" value="single">
 			Grids['<inp2:m_param name="prefix"/>'].DblClick = function() {return false};

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

0001055

closed (5.1.3)

alex

"Up" toolbar button in Catalog can go beyond "Home" category

Notes
(0003658) Dmitry (manager) 2011-08-12 18:16	Tested please commit.

(0003666) alex (manager) 2011-08-13 00:38	Fix committed to 5.1.x branch. Commit Message: Fixes 0001083: Buttons "Home" and "Go Up" are not disabled when used from non-Sections tab

(0003801) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14484 Timestamp: 2011-08-13 00:38:51 Author: alex [ Details ] [ Diff ]	Fixes 0001083: Buttons "Home" and "Go Up" are not disabled when used from non-Sections tab
	mod - /in-portal/branches/5.1.x/core/admin_templates/catalog_tab.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/admin_templates/categories/ci_blocks.tpl	[ Diff ] [ File ]

Modules :: In-News: 5.1.x r14483 Timestamp: 2011-08-13 00:37:59 Author: alex [ Details ] [ Diff ]	Bug 0001083: Buttons "Home" and "Go Up" are not disabled when used from non-Sections tab
	mod - /modules/in-news/branches/5.1.x/admin_templates/catalog_tab.tpl	[ Diff ] [ File ]
	mod - /modules/in-news/branches/5.1.x/install/upgrades.php	[ Diff ] [ File ]
	mod - /modules/in-news/branches/5.1.x/install/upgrades.sql	[ Diff ] [ File ]

Modules :: In-Link: 5.1.x r14482 Timestamp: 2011-08-13 00:36:40 Author: alex [ Details ] [ Diff ]	Bug 0001083: Buttons "Home" and "Go Up" are not disabled when used from non-Sections tab
	mod - /modules/in-link/branches/5.1.x/admin_templates/catalog_tab.tpl	[ Diff ] [ File ]
	mod - /modules/in-link/branches/5.1.x/install/upgrades.php	[ Diff ] [ File ]
	mod - /modules/in-link/branches/5.1.x/install/upgrades.sql	[ Diff ] [ File ]

Modules :: In-Commerce: 5.1.x r14481 Timestamp: 2011-08-13 00:35:17 Author: alex [ Details ] [ Diff ]	Bug 0001083: Buttons "Home" and "Go Up" are not disabled when used from non-Sections tab
	mod - /w/in-commerce/branches/5.1.x/admin_templates/catalog_tab.tpl	[ Diff ] [ File ]
	mod - /w/in-commerce/branches/5.1.x/install/upgrades.php	[ Diff ] [ File ]
	mod - /w/in-commerce/branches/5.1.x/install/upgrades.sql	[ Diff ] [ File ]

Modules :: In-Bulletin: 5.1.x r14480 Timestamp: 2011-08-13 00:34:25 Author: alex [ Details ] [ Diff ]	Bug 0001083: Buttons "Home" and "Go Up" are not disabled when used from non-Sections tab
	mod - /modules/in-bulletin/branches/5.1.x/admin_templates/catalog_tab.tpl	[ Diff ] [ File ]
	mod - /modules/in-bulletin/branches/5.1.x/install/upgrades.php	[ Diff ] [ File ]
	mod - /modules/in-bulletin/branches/5.1.x/install/upgrades.sql	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003801
2011-09-19 16:08	alex	Status	resolved => closed
2011-08-13 00:38	alex	Note Added: 0003666
2011-08-13 00:38	alex	Status	reviewed and tested => resolved
2011-08-13 00:38	alex	Fixed in Version	=> 5.1.3-RC2
2011-08-13 00:38	alex	Resolution	open => fixed
2011-08-13 00:38	alex	Assigned To	!COMMUNITY => alex
2011-08-13 00:38	alex	Changeset attached	5.1.x r14484
2011-08-13 00:37	alex	Changeset attached	5.1.x r14483
2011-08-13 00:36	alex	Changeset attached	5.1.x r14482
2011-08-13 00:35	alex	Changeset attached	5.1.x r14481
2011-08-13 00:34	alex	Changeset attached	5.1.x r14480
2011-08-12 18:16	Dmitry	Note Added: 0003658
2011-08-12 18:16	Dmitry	Status	needs testing => reviewed and tested
2011-07-18 03:13	alex	Relationship added	related to 0001055
2011-07-18 03:11	alex	Assigned To	=> !COMMUNITY
2011-07-18 03:11	alex	Developer	=> alex
2011-07-18 03:11	alex	Status	active => needs testing
2011-07-18 03:11	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/Wl3z8zvaInQ/discussion
2011-07-18 03:10	alex	File Added: disable_homeup_buttons_modules.patch
2011-07-18 03:10	alex	New Issue
2011-07-18 03:10	alex	File Added: disable_homeup_buttons_core.patch
2011-07-18 03:10	alex	Change Log Message	=> Fixes problem, when "Home" and "Go Up" buttons were not disabled in time

Web Development by Intechnic

In-Portal Open Source CMS