In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001066

[In-Portal CMS] Front End

bug report

always

2011-05-28 14:51

2011-09-19 16:08

Reporter

alex

View Status

public

Project Name

In-Bulletin

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.3-RC1

Status

closed

Product Version

5.1.2

Target Version

5.1.3

Time Estimate

No estimate

Summary

0001066: Non working poll comment anti-spam protection

Description

There is an error in In-Bulletin's poll comment anti-spam protection engine, that prevents it from working properly.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/KuxHhi-ZnmE/discussion

Change Log Message

Fixes anti-spam protection in poll comments

Estimate Points

0

poll_comment_spam_protection_not_working.patch [^] (1,355 bytes) 2011-05-28 14:51 [Show Content]

Index: in-bulletin/units/poll_comments/poll_comment_eh.php
===================================================================
--- in-bulletin/units/poll_comments/poll_comment_eh.php	(revision 14318)
+++ in-bulletin/units/poll_comments/poll_comment_eh.php	(working copy)
@@ -139,8 +139,7 @@
 
 				$object =& $event->getObject();
 
-				$config_mapping = $this->Application->getUnitOption($event->Prefix, 'ConfigMapping');
-				$comment_settings = $config_mapping['CommentDelayValue'].':'.$config_mapping['CommentDelayInterval'];
+				$comment_settings = 'poll_CommentDelay_Value:poll_CommentDelay_Interval';
 				$spam_helper->InitHelper($object->GetDBField('PollId'), 'PollComment', $comment_settings);
 				$spam_helper->AddToSpamControl();
 			}
Index: in-bulletin/units/poll_comments/poll_comments_config.php
===================================================================
--- in-bulletin/units/poll_comments/poll_comments_config.php	(revision 14318)
+++ in-bulletin/units/poll_comments/poll_comments_config.php	(working copy)
@@ -85,12 +85,6 @@
 			),
 		),
 
-		'ConfigMapping' => Array (
-			'PerPage'				=>	'poll_Perpage_Comments',
-			'CommentDelayInterval'	=>	'poll_CommentDelay_Value',
-			'CommentDelayValue'		=>	'poll_CommentDelay_Interval',
-		),
-
 		'Grids' => Array (
 						'Default' => Array (
 							'Icons' => Array (

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

closed (5.1.3)

In-Portal CMS

Usage of non-existent configuration variable "DomainDetect"

Notes
(0003510) Dmitry (manager) 2011-05-30 22:43	Reviewed and tested okay.

(0003594) Dmitry (manager) 2011-07-07 10:06	Patch has been reviewed and tested. Moved to 5.1.3 release to get it out the way and make Merge to 5.2.0 easier.

(0003605) alex (manager) 2011-07-08 05:07	Fix committed to 5.1.x branch. Commit Message: Fixes 0001066: Non working poll comment anti-spam protection

(0003813) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
Modules :: In-Bulletin: 5.1.x r14441 Timestamp: 2011-07-08 05:07:41 Author: alex [ Details ] [ Diff ]	Fixes 0001066: Non working poll comment anti-spam protection
	mod - /modules/in-bulletin/branches/5.1.x/units/poll_comments/poll_comment_eh.php		[ Diff ] [ File ]
	mod - /modules/in-bulletin/branches/5.1.x/units/poll_comments/poll_comments_config.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003813
2011-09-19 16:08	alex	Status	resolved => closed
2011-07-08 05:07	alex	Note Added: 0003605
2011-07-08 05:07	alex	Status	reviewed and tested => resolved
2011-07-08 05:07	alex	Fixed in Version	=> 5.1.3-RC1
2011-07-08 05:07	alex	Resolution	open => fixed
2011-07-08 05:07	alex	Assigned To	!COMMUNITY => alex
2011-07-08 05:07	alex	Changeset attached	5.1.x r14441
2011-07-07 10:06	Dmitry	Note Added: 0003594
2011-07-07 10:06	Dmitry	Target Version	Icebox => 5.1.3
2011-05-30 22:43	Dmitry	Note Added: 0003510
2011-05-30 22:43	Dmitry	Status	needs testing => reviewed and tested
2011-05-28 14:52	alex	Assigned To	=> !COMMUNITY
2011-05-28 14:52	alex	Developer	=> alex
2011-05-28 14:52	alex	Status	active => needs testing
2011-05-28 14:52	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/KuxHhi-ZnmE/discussion
2011-05-28 14:51	alex	Relationship added	related to 0001021
2011-05-28 14:51	alex	New Issue
2011-05-28 14:51	alex	File Added: poll_comment_spam_protection_not_working.patch
2011-05-28 14:51	alex	Change Log Message	=> Fixes anti-spam protection in poll comments

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group