In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/1q2DpkInEyo/discussion

Change Log Message

Adding OptionValue tag for displaying option title by option id

Estimate Points

Attached Files

option_value_tag.patch [^] (2,720 bytes) 2011-03-28 09:56 [Show Content]

Index: admin_templates/incs/form_blocks.tpl
===================================================================
--- admin_templates/incs/form_blocks.tpl	(revision 14260)
+++ admin_templates/incs/form_blocks.tpl	(working copy)
@@ -583,6 +583,10 @@
 	</inp2:m_RenderElement>
 </inp2:m_DefineElement>
 
+<inp2:m_DefineElement name="inp_single_option">
+	<option value="<inp2:m_param name='value'/>"<inp2:m_if check="{$prefix}_Selected" field="$field" value="$value"> selected</inp2:m_if>><inp2:$prefix_OptionValue field="$field" value="$value"/></option>
+</inp2:m_DefineElement>
+
 <inp2:m_DefineElement name="inp_edit_multioptions" has_empty="0" empty_value="" style="">
 	<inp2:m_RenderElement design="form_row" pass_params="1">
 		<td class="control-cell">
@@ -665,6 +669,10 @@
 	</inp2:m_RenderElement>
 </inp2:m_DefineElement>
 
+<inp2:m_DefineElement name="inp_single_checkbox">
+	<input type="checkbox"<inp2:m_if check="{$prefix}_Selected" field="$field" value="$value"> checked</inp2:m_if> id="<inp2:{$prefix}_InputName field='$field'/>_<inp2:m_param name='value'/>" value="<inp2:m_param name='value'/>" onclick="update_checkbox_options(/^<inp2:{$prefix}_InputName field='$field' as_preg='1'/>_([0-9A-Za-z-]+)/, '<inp2:{$prefix}_InputName field='$field'/>');"><label for="<inp2:{$prefix}_InputName field='$field'/>_<inp2:m_param name='value'/>"><inp2:$prefix_OptionValue field="$field" value="$value"/></label>&nbsp;
+</inp2:m_DefineElement>
+
 <inp2:m_DefineElement name="inp_edit_checkbox_allow_html" field_class="" onchange="" onclick="" title="la_enable_html" hint_label="la_Warning_Enable_HTML">
 	<inp2:m_RenderElement name="inp_edit_checkbox" pass_params="1"/>
 
Index: kernel/db/db_tag_processor.php
===================================================================
--- kernel/db/db_tag_processor.php	(revision 14260)
+++ kernel/db/db_tag_processor.php	(working copy)
@@ -2773,6 +2773,33 @@
 			return in_array($params['value'], $value);
 		}
 
-		return $value;
+		return $value == $params['value'];
 	}
+
+	/**
+	 * Displays option name by it's value
+	 *
+	 * @param Array $params
+	 * @return string
+	 */
+	function OptionValue($params)
+	{
+		$object =& $this->getObject($params);
+		/* @var $object kDBItem */
+
+		$value = $params['value'];
+		$field = $this->SelectParam($params, 'name,field');
+
+		$field_options = $object->GetFieldOptions($field);
+
+		if ( isset($field_options['options'][$value]) ) {
+			$value = $field_options['options'][$value];
+			$use_phrases = isset($field_options['use_phrases']) ? $field_options['use_phrases'] : false;
+
+			return $use_phrases ? $this->Application->Phrase($value) : $value;
+		}
+
+		return '';
+	}
+
 }
\ No newline at end of file

option_value_tag_520.patch [^] (2,694 bytes) 2011-10-26 03:07 [Show Content]

Index: admin_templates/incs/form_blocks.tpl
===================================================================
--- admin_templates/incs/form_blocks.tpl	(revision 14653)
+++ admin_templates/incs/form_blocks.tpl	(working copy)
@@ -613,6 +613,10 @@
 	</inp2:m_RenderElement>
 </inp2:m_DefineElement>
 
+<inp2:m_DefineElement name="inp_single_option">
+	<option value="<inp2:m_param name='value'/>"<inp2:m_if check="{$prefix}_Selected" field="$field" value="$value"> selected</inp2:m_if>><inp2:$prefix_OptionValue field="$field" value="$value"/></option>
+</inp2:m_DefineElement>
+
 <inp2:m_DefineElement name="inp_edit_multioptions" has_empty="0" empty_value="" style="">
 	<inp2:m_RenderElement design="form_row" pass_params="1">
 		<td class="control-cell">
@@ -694,6 +698,10 @@
 	</inp2:m_RenderElement>
 </inp2:m_DefineElement>
 
+<inp2:m_DefineElement name="inp_single_checkbox">
+	<input type="checkbox"<inp2:m_if check="{$prefix}_Selected" field="$field" value="$value"> checked</inp2:m_if> id="<inp2:{$prefix}_InputName field='$field'/>_<inp2:m_param name='value'/>" value="<inp2:m_param name='value'/>" onclick="update_checkbox_options(/^<inp2:{$prefix}_InputName field='$field' as_preg='1'/>_([0-9A-Za-z-]+)/, '<inp2:{$prefix}_InputName field='$field'/>');"><label for="<inp2:{$prefix}_InputName field='$field'/>_<inp2:m_param name='value'/>"><inp2:$prefix_OptionValue field="$field" value="$value"/></label>&nbsp;
+</inp2:m_DefineElement>
+
 <inp2:m_DefineElement name="inp_edit_checkbox_allow_html" field_class="" onchange="" onclick="" title="la_enable_html" hint_label="la_Warning_Enable_HTML">
 	<inp2:m_RenderElement name="inp_edit_checkbox" pass_params="1"/>
 
Index: kernel/db/db_tag_processor.php
===================================================================
--- kernel/db/db_tag_processor.php	(revision 14694)
+++ kernel/db/db_tag_processor.php	(working copy)
@@ -2906,6 +2906,33 @@
 	}
 
 	/**
+	 * Displays option name by it's value
+	 *
+	 * @param Array $params
+	 * @return string
+	 * @access protected
+	 */
+	protected function OptionValue($params)
+	{
+		$object =& $this->getObject($params);
+		/* @var $object kDBItem */
+
+		$value = $params['value'];
+		$field = $this->SelectParam($params, 'name,field');
+
+		$field_options = $object->GetFieldOptions($field);
+
+		if ( isset($field_options['options'][$value]) ) {
+			$value = $field_options['options'][$value];
+			$use_phrases = isset($field_options['use_phrases']) ? $field_options['use_phrases'] : false;
+
+			return $use_phrases ? $this->Application->Phrase($value) : $value;
+		}
+
+		return '';
+	}
+
+	/**
 	 * Returns/sets form name for current object
 	 *
 	 * @param Array $params

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

0000427

closed (5.1.1)

alex

Refactor "Display To Public" functionality

Notes
(0003311) alex (manager) 2011-03-28 09:57	Done. I've also fixed incorrect behavior in Selected tag in cases, when field allowed only one option (of many) to be selected (like dropdown) and that tag always returned 1.

(0003730) Dmitry (manager) 2011-09-11 22:13	Reminder sent to: alex I need help testing this functionality.

(0003891) alex (manager) 2011-09-24 04:13	To test this you need: 1. create field/custom field of "text" type 2. specify 2+ options for that field via kOptionsFormatter class 3. then on front-end: - render "inp_single_checkbox" blocks for each option you've created in 2nd step - place a hidden field from "inp_edit_checkboxes" block As a result clicking on checkboxes, produced by "inp_single_checkbox" block would make hidden field value to change the same way, like it is changed, when used along with "inp_edit_checkboxes" block. Benefit of "inp_single_checkbox" is that, you can specify any options from given field using order you need and can easily place them into target web page design.

(0004090) Dmitry (manager) 2011-10-25 21:51	Tested good! Please update to use Public/Private for Function call and commit.

(0004096) alex (manager) 2011-10-26 03:09	Fix committed to 5.2.x branch. Commit Message: Fixes 0001027: Tag, to display given option title

(0005070) alex (manager) 2012-07-25 05:33	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14696 Timestamp: 2011-10-26 03:09:34 Author: alex [ Details ] [ Diff ]	Fixes 0001027: Tag, to display given option title
	mod - /in-portal/branches/5.2.x/core/admin_templates/incs/form_blocks.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/kernel/db/db_tag_processor.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:33	alex	Note Added: 0005070
2012-07-25 05:33	alex	Status	resolved => closed
2011-10-26 03:09	alex	Changeset attached	5.2.x r14696
2011-10-26 03:09	alex	Note Added: 0004096
2011-10-26 03:09	alex	Status	reviewed and tested => resolved
2011-10-26 03:09	alex	Fixed in Version	=> 5.2.0-B1
2011-10-26 03:09	alex	Resolution	open => fixed
2011-10-26 03:09	alex	Assigned To	!COMMUNITY => alex
2011-10-26 03:07	alex	File Added: option_value_tag_520.patch
2011-10-25 21:51	Dmitry	Note Added: 0004090
2011-10-25 21:51	Dmitry	Status	needs testing => reviewed and tested
2011-10-22 05:40	alex	Estimate Points	=> 1
2011-09-24 04:13	alex	Note Added: 0003891
2011-09-24 04:13	alex	Status	needs work => needs testing
2011-09-23 22:09	Dmitry	Status	needs testing => needs work
2011-09-23 22:09	Dmitry	Target Version	Icebox => 5.2.0
2011-09-11 22:13	Dmitry	Note Added: 0003730
2011-04-04 05:04	alex	Relationship added	related to 0000427
2011-03-28 09:57	alex	Note Added: 0003311
2011-03-28 09:57	alex	Assigned To	=> !COMMUNITY
2011-03-28 09:57	alex	Developer	=> alex
2011-03-28 09:57	alex	Status	active => needs testing
2011-03-28 09:56	alex	New Issue
2011-03-28 09:56	alex	File Added: option_value_tag.patch
2011-03-28 09:56	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/1q2DpkInEyo/discussion
2011-03-28 09:56	alex	Change Log Message	=> Adding OptionValue tag for displaying option title by option id

Web Development by Intechnic

In-Portal Open Source CMS