In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001342 [In-Portal CMS] Front End task always 2012-07-09 11:16 2012-09-16 04:45
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0
Status closed Product Version 5.0.0 Target Version 5.2.0
Time EstimateNo estimate
Summary 0001342: Make UTF-8 the only one supported language encoding
Description In-Portal always allowed to enter custom charset for each language you've add. However from time, when we implemented this feature a lot has changed and now UTF-8 is major charset that supports all of them together.

I propose to remove Charset from Language settings and always use UTF-8.

I'm proposing this because recently I had a need to do some symbol conversions in OnAfterConfigRead event, which is called before actual charset from a language is detected and mb_internal_encoding is set.

For backwards compatibility we still can support "one-per-system" charset setting in config.php (like we do now with database), but not "each language have it's own charset" system, that is bad.
Additional Information
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-dev/YNBKQEC68dU/discussion
Change Log Message Changed only UTF-8 is allowed
Estimate Points 1
Attached Files patch file icon unified_charset_core.patch [^] (21,492 bytes) 2012-07-13 11:34 [Show Content]
patch file icon unified_charset_modules.patch [^] (3,944 bytes) 2012-07-13 11:36 [Show Content]
patch file icon unified_charset_themes.patch [^] (3,374 bytes) 2012-07-13 11:36 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0001423resolved (5.2.1)alex Function "htmlspecialchars" breaks down UTF-8 encoding 

-  Notes
User avatar (0004776)
alex (manager)
2012-07-13 11:40

Will test all together later.
User avatar (0004777)
alex (manager)
2012-07-13 11:44

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001342: Make UTF-8 the only one supported language encoding
User avatar (0004838)
alex (manager)
2012-07-25 05:29

Since 5.2.0 version was released.
User avatar (0005180)
alex (manager)
2012-09-16 04:45

Without this fix In-Portal can't work with UTF-8 urls on PHP 5.4.

- Related Changesets
In-Portal CMS: 5.2.x r15445
Timestamp: 2012-07-13 11:44:00
Author: alex
Details ] Diff ]
Fixes 0001342: Make UTF-8 the only one supported language encoding
mod - /in-portal/branches/5.2.x/core/admin_templates/browser/browser_header.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/catalog_tab.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/categories/permissions_tab.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/incs/close_popup.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/incs/header.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/index.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/regional/languages_edit.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/reviews/reviews_tab.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/step_templates/sys_config.tpl Diff ] File ]
mod - /in-portal/branches/5.2.x/core/install/steps_db.xml Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/application.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/managers/rewrite_url_processor.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/startup.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/utility/email_send.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/categories/categories_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/fck/fck_eh.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/csv_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/language_import_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/mime_decode_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/languages/languages_config.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/languages/languages_tag_processor.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/translator/translator_event_handler.php Diff ] File ]
Themes :: Simple: 1.2.x r15444
Timestamp: 2012-07-13 11:42:34
Author: alex
Details ] Diff ]
Bug 0001342: Make UTF-8 the only one supported language encoding
mod - /themes/simple/branches/1.2.x/elements/html_head.elm.tpl Diff ] File ]
Themes :: Default: 5.2.x r15443
Timestamp: 2012-07-13 11:42:22
Author: alex
Details ] Diff ]
Bug 0001342: Make UTF-8 the only one supported language encoding
mod - /themes/default/branches/5.2.x/elements/html_head.elm.tpl Diff ] File ]
Themes :: Advanced: 1.2.x r15442
Timestamp: 2012-07-13 11:42:05
Author: alex
Details ] Diff ]
Bug 0001342: Make UTF-8 the only one supported language encoding
mod - /themes/advanced/branches/1.2.x/platform/designs/popup_design.des.tpl Diff ] File ]
mod - /themes/advanced/branches/1.2.x/platform/elements/html_head.elm.tpl Diff ] File ]
Modules :: In-News: 5.2.x r15441
Timestamp: 2012-07-13 11:41:34
Author: alex
Details ] Diff ]
Bug 0001342: Make UTF-8 the only one supported language encoding
mod - /modules/in-news/branches/5.2.x/admin_templates/catalog_tab.tpl Diff ] File ]
Modules :: In-Link: 5.2.x r15440
Timestamp: 2012-07-13 11:41:24
Author: alex
Details ] Diff ]
Bug 0001342: Make UTF-8 the only one supported language encoding
mod - /modules/in-link/branches/5.2.x/admin_templates/catalog_tab.tpl Diff ] File ]
Modules :: In-Commerce: 5.2.x r15439
Timestamp: 2012-07-13 11:41:05
Author: alex
Details ] Diff ]
Bug 0001342: Make UTF-8 the only one supported language encoding
mod - /w/in-commerce/branches/5.2.x/admin_templates/catalog_tab.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/admin_templates/products/products_pricing_grid.tpl Diff ] File ]
Modules :: In-Bulletin: 5.2.x r15438
Timestamp: 2012-07-13 11:40:50
Author: alex
Details ] Diff ]
Bug 0001342: Make UTF-8 the only one supported language encoding
mod - /modules/in-bulletin/branches/5.2.x/admin_templates/catalog_tab.tpl Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-11-02 08:54 alex Relationship added related to 0001423
2012-09-16 04:45 alex Note Added: 0005180
2012-07-25 05:29 alex Note Added: 0004838
2012-07-25 05:29 alex Status resolved => closed
2012-07-13 11:44 alex Changeset attached 5.2.x r15445
2012-07-13 11:44 alex Note Added: 0004777
2012-07-13 11:44 alex Status reviewed and tested => resolved
2012-07-13 11:44 alex Fixed in Version => 5.2.0
2012-07-13 11:44 alex Resolution open => fixed
2012-07-13 11:44 alex Assigned To !COMMUNITY => alex
2012-07-13 11:42 alex Changeset attached 1.2.x r15444
2012-07-13 11:42 alex Changeset attached 5.2.x r15443
2012-07-13 11:42 alex Changeset attached 1.2.x r15442
2012-07-13 11:41 alex Changeset attached 5.2.x r15441
2012-07-13 11:41 alex Changeset attached 5.2.x r15440
2012-07-13 11:41 alex Changeset attached 5.2.x r15439
2012-07-13 11:40 alex Changeset attached 5.2.x r15438
2012-07-13 11:40 alex Note Added: 0004776
2012-07-13 11:40 alex Status needs testing => reviewed and tested
2012-07-13 11:40 alex Assigned To => !COMMUNITY
2012-07-13 11:40 alex Developer => alex
2012-07-13 11:40 alex Status active => needs testing
2012-07-13 11:36 alex File Added: unified_charset_themes.patch
2012-07-13 11:36 alex File Added: unified_charset_modules.patch
2012-07-13 11:34 alex File Added: unified_charset_core.patch
2012-07-09 11:16 alex New Issue
2012-07-09 11:16 alex Reference => https://groups.google.com/d/topic/in-portal-dev/YNBKQEC68dU/discussion
2012-07-09 11:16 alex Change Log Message => Changed only UTF-8 is allowed
2012-07-09 11:16 alex Estimate Points => 1



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker