In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0001337

[In-Portal CMS] Admin Interfaces

bug report

always

2012-07-03 03:20

2012-07-25 05:29

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0

Status

closed

Product Version

5.1.0

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001337: Don't use Admin-specific list settings on Front-End

Description

One of the powerful features of Administrative Console in In-Portal are lists (grids).

Each list can have unlimited number of rows and columns. Each column can have a filter block above it, that allows to filter displayed rows based on data in that column.
Filters from different columns can be easily combined to get more specific results.

All list have following settings, that can be tuned once by "root" user and then automatically populated to all users, who tries to use them:
* item count to show per page
* columns to be used in default sorting
* visible columns, their order and widths

This was done for In-Portal installation, that have multiple (>10) administrator accounts with different permissions each. Then "root" user can setup layout for all other administrator users.

Recently (in In-Portal 5.1.3) I've found a side effect of that functionality: sorting set by "root" user in "Visitor Log" section (with In-Commerce installed) in Admin Console was populated to "Affiliate Statistics" page on Front-End resulting SQL error, because "OrderAffiliateCommissionSum" field used in sorting exists in Admin Console only.

I'm proposing not to use described functionality on Front-End at all.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/lEEfFmHxYW4/discussion

Change Log Message

Don't use admin-specific settings for lists on Front-End

Estimate Points

Attached Files

dont_use_admin_list_settings_on_frontend.patch [^] (1,463 bytes) 2012-07-03 03:25 [Show Content]

Index: kernel/db/db_event_handler.php
===================================================================
--- kernel/db/db_event_handler.php	(revision 15359)
+++ kernel/db/db_event_handler.php	(working copy)
@@ -1153,7 +1153,8 @@
 			$storage_prefix = $event->getEventParam('same_special') ? $event->Prefix : $event->getPrefixSpecial();
 
 			// get sorting from persistent session
-			$variable_value = $this->Application->RecallPersistentVar($storage_prefix . '_' . $variable_name . '.' . $view_name, ALLOW_DEFAULT_SETTINGS);
+			$default_value = $this->Application->isAdmin ? ALLOW_DEFAULT_SETTINGS : false;
+			$variable_value = $this->Application->RecallPersistentVar($storage_prefix . '_' . $variable_name . '.' . $view_name, $default_value);
 
 			/*if ( !$variable_value ) {
 				// get sorting from session
Index: units/helpers/col_picker_helper.php
===================================================================
--- units/helpers/col_picker_helper.php	(revision 15359)
+++ units/helpers/col_picker_helper.php	(working copy)
@@ -43,7 +43,8 @@
 
 	function LoadColumns($prefix)
 	{
-		$val = $this->Application->RecallPersistentVar($this->_getVarName($prefix, 'get'), ALLOW_DEFAULT_SETTINGS);
+		$default_value = $this->Application->isAdmin ? ALLOW_DEFAULT_SETTINGS : false;
+		$val = $this->Application->RecallPersistentVar($this->_getVarName($prefix, 'get'), $default_value);
 
 		if (!$val) {
 			$cols = $this->RebuildColumns($prefix);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004756) alex (manager) 2012-07-03 03:26	Will test all together later.

(0004757) alex (manager) 2012-07-03 03:27	Fix committed to 5.2.x branch. Commit Message: Fixes 0001337: Don't use Admin-specific list settings on Front-End

(0004850) alex (manager) 2012-07-25 05:29	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15425 Timestamp: 2012-07-03 03:27:15 Author: alex [ Details ] [ Diff ]	Fixes 0001337: Don't use Admin-specific list settings on Front-End
	mod - /in-portal/branches/5.2.x/core/kernel/db/db_event_handler.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/units/helpers/col_picker_helper.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:29	alex	Note Added: 0004850
2012-07-25 05:29	alex	Status	resolved => closed
2012-07-03 03:27	alex	Note Added: 0004757
2012-07-03 03:27	alex	Status	reviewed and tested => resolved
2012-07-03 03:27	alex	Fixed in Version	=> 5.2.0
2012-07-03 03:27	alex	Resolution	open => fixed
2012-07-03 03:27	alex	Assigned To	!COMMUNITY => alex
2012-07-03 03:27	alex	Changeset attached	5.2.x r15425
2012-07-03 03:26	alex	Note Added: 0004756
2012-07-03 03:26	alex	Status	needs testing => reviewed and tested
2012-07-03 03:26	alex	Assigned To	=> !COMMUNITY
2012-07-03 03:26	alex	Developer	=> alex
2012-07-03 03:26	alex	Status	active => needs testing
2012-07-03 03:26	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/lEEfFmHxYW4/discussion
2012-07-03 03:25	alex	File Added: dont_use_admin_list_settings_on_frontend.patch
2012-07-03 03:20	alex	New Issue
2012-07-03 03:20	alex	Change Log Message	=> Don't use admin-specific settings for lists on Front-End
2012-07-03 03:20	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS