In-Portal Issue Tracker

Index: kernel/db/cat_event_handler.php
===================================================================
--- kernel/db/cat_event_handler.php	(revision 15226)
+++ kernel/db/cat_event_handler.php	(working copy)
@@ -1090,7 +1090,7 @@
 		$event->redirect = false;
 		$search_table = TABLE_PREFIX.'ses_'.$this->Application->GetSID().'_'.TABLE_PREFIX.'Search';
 
-		$keywords = kUtil::unhtmlentities( trim($this->Application->GetVar('keywords')) );
+		$keywords = htmlspecialchars_decode( trim($this->Application->GetVar('keywords')) );
 
 		$query_object = $this->Application->recallObject('HTTPQuery');
 		/* @var $query_object kHTTPQuery */
@@ -1634,14 +1634,14 @@
 		$condition = '';
 		switch ($record['FieldType']) {
 			case 'select':
-				$keywords[$field] = kUtil::unhtmlentities( $keywords[$field] );
+				$keywords[$field] = htmlspecialchars_decode( $keywords[$field] );
 				if ($keywords[$field]) {
 					$condition = sprintf($condition_patterns['is'], $field_name, $this->Conn->qstr( $keywords[$field] ));
 				}
 				break;
 
 			case 'multiselect':
-				$keywords[$field] = kUtil::unhtmlentities( $keywords[$field] );
+				$keywords[$field] = htmlspecialchars_decode( $keywords[$field] );
 				if ($keywords[$field]) {
 					$condition = Array ();
 					$values = explode('|', substr($keywords[$field], 1, -1));
@@ -1653,7 +1653,7 @@
 				break;
 
 			case 'text':
-				$keywords[$field] = kUtil::unhtmlentities( $keywords[$field] );
+				$keywords[$field] = htmlspecialchars_decode( $keywords[$field] );
 
 				if (mb_strlen($keywords[$field]) >= $this->Application->ConfigValue('Search_MinKeyword_Length')) {
 					$highlight_keywords[] = $keywords[$field];
Index: kernel/globals.php
===================================================================
--- kernel/globals.php	(revision 15246)
+++ kernel/globals.php	(working copy)
@@ -302,21 +302,6 @@
 	}
 
 	/**
-	 * Reverts effects of "htmlspecialchars" function
-	 *
-	 * @param string $string
-	 * @return string
-	 * @access public
-	 */
-	public static function unhtmlentities($string)
-	{
-		$trans_tbl = get_html_translation_table(HTML_ENTITIES); // from PHP 5.3.4: , ENT_COMPAT, 'utf-8');
-		$trans_tbl = array_flip ($trans_tbl);
-
-		return strtr($string, $trans_tbl);
-	}
-
-	/**
 	 * submits $url with $post as POST
 	 *
 	 * @param string $url
Index: kernel/processors/main_processor.php
===================================================================
--- kernel/processors/main_processor.php	(revision 15278)
+++ kernel/processors/main_processor.php	(working copy)
@@ -408,7 +408,7 @@
 		}
 
 		if (array_key_exists('no_html_escape', $params) && $params['no_html_escape']) {
-			return kUtil::unhtmlentities($ret);
+			return htmlspecialchars_decode($ret);
 		}
 
 		return $ret;
Index: kernel/utility/formatters/formatter.php
===================================================================
--- kernel/utility/formatters/formatter.php	(revision 15226)
+++ kernel/utility/formatters/formatter.php	(working copy)
@@ -75,7 +75,7 @@
 			elseif ( $field_type == 'string' ) {
 				if ( !$this->Application->isAdmin && isset($options['allow_html']) && $options['allow_html'] ) {
 					// this allows to revert htmlspecialchars call for each field submitted on front-end
-					$value = kUtil::unhtmlentities($value);
+					$value = htmlspecialchars_decode($value);
 				}
 
 				return $value;
Index: units/categories/categories_event_handler.php
===================================================================
--- units/categories/categories_event_handler.php	(revision 15268)
+++ units/categories/categories_event_handler.php	(working copy)
@@ -2265,7 +2265,7 @@
 		function OnUpdatePreviewBlock($event)
 		{
 			$event->status = kEvent::erSTOP;
-			$string = kUtil::unhtmlentities($this->Application->GetVar('preview_content'));
+			$string = htmlspecialchars_decode($this->Application->GetVar('preview_content'));
 
 			$category_helper = $this->Application->recallObject('CategoryHelper');
 			/* @var $category_helper CategoryHelper */
@@ -2286,7 +2286,7 @@
 			$event->redirect = false;
 			$search_table = TABLE_PREFIX.'ses_'.$this->Application->GetSID().'_'.TABLE_PREFIX.'Search';
 
-			$keywords = kUtil::unhtmlentities( trim($this->Application->GetVar('keywords')) );
+			$keywords = htmlspecialchars_decode( trim($this->Application->GetVar('keywords')) );
 
 			$query_object = $this->Application->recallObject('HTTPQuery');
 			/* @var $query_object kHTTPQuery */
Index: units/categories/categories_tag_processor.php
===================================================================
--- units/categories/categories_tag_processor.php	(revision 15274)
+++ units/categories/categories_tag_processor.php	(working copy)
@@ -942,7 +942,7 @@
 	 */
 	protected function SpellingSuggestions($params)
 	{
-		$keywords = kUtil::unhtmlentities( trim($this->Application->GetVar('keywords')) );
+		$keywords = htmlspecialchars_decode( trim($this->Application->GetVar('keywords')) );
 		if ( !$keywords ) {
 			return '';
 		}
Index: units/forms/form_submissions/form_submissions_eh.php
===================================================================
--- units/forms/form_submissions/form_submissions_eh.php	(revision 15165)
+++ units/forms/form_submissions/form_submissions_eh.php	(working copy)
@@ -262,7 +262,7 @@
 			$theme = $this->Application->recallObject('theme.current');
 			/* @var $theme kDBItem */
 
-			$template = kUtil::unhtmlentities($this->Application->GetVar('success_template')); // kHTTPQuery do htmlspecialchars on everything
+			$template = htmlspecialchars_decode($this->Application->GetVar('success_template')); // kHTTPQuery do htmlspecialchars on everything
 			$alias_template = $theme->GetField('TemplateAliases', $template);
 
 			$event->redirect = $alias_template ? $alias_template : $template;
Index: units/thesaurus/thesaurus_eh.php
===================================================================
--- units/thesaurus/thesaurus_eh.php	(revision 15165)
+++ units/thesaurus/thesaurus_eh.php	(working copy)
@@ -32,7 +32,7 @@
 			/* @var $object kDBList */
 
 			if ( !$this->Application->isAdminUser ) {
-				$keywords = kUtil::unhtmlentities(trim($this->Application->GetVar('keywords')));
+				$keywords = htmlspecialchars_decode(trim($this->Application->GetVar('keywords')));
 				$object->addFilter('search_filter', '%1$s.SearchTerm LIKE ' . $this->Conn->qstr($keywords) . ' OR %1$s.SearchTerm LIKE ' . $this->Conn->qstr($keywords . '_'));
 			}
 		}
Index: units/thesaurus/thesaurus_tp.php
===================================================================
--- units/thesaurus/thesaurus_tp.php	(revision 15165)
+++ units/thesaurus/thesaurus_tp.php	(working copy)
@@ -30,7 +30,7 @@
 
 		function _getThesaurusRecords()
 		{
-			$keywords = kUtil::unhtmlentities( trim($this->Application->GetVar('keywords')) );
+			$keywords = htmlspecialchars_decode( trim($this->Application->GetVar('keywords')) );
 			$table_name = $this->Application->getUnitOption($this->Prefix, 'TableName');
 
 			$sql = 'SELECT *
Index: units/user_profile/user_profile_eh.php
===================================================================
--- units/user_profile/user_profile_eh.php	(revision 15165)
+++ units/user_profile/user_profile_eh.php	(working copy)
@@ -67,7 +67,7 @@
 					}
 				}
 				else {
-					$this->Application->StorePersistentVar($variable_name, kUtil::unhtmlentities($variable_value));
+					$this->Application->StorePersistentVar($variable_name, htmlspecialchars_decode($variable_value));
 				}
 			}
 

Index: in-bulletin/units/helpers/post_helper.php
===================================================================
--- in-bulletin/units/helpers/post_helper.php	(revision 15286)
+++ in-bulletin/units/helpers/post_helper.php	(working copy)
@@ -407,7 +407,7 @@
 				$bbcode_mask = trim($this->Application->ParseBlock($block_params));
 			}
 
-			$input_string = trim( str_replace('\"','"', kUtil::unhtmlentities($input_string)) );
+			$input_string = trim( str_replace('\"','"', htmlspecialchars_decode($input_string)) );
 			$input_string = $this->highlightCode($input_string);
 			$input_string = preg_replace("/\r<br \/>/s", "\r", $input_string); // undo nl2br added in highlighting
 			$input_string = str_replace('#BB_CODE#', $input_string, $bbcode_mask);
Index: in-commerce/units/order_items/order_items_tag_processor.php
===================================================================
--- in-commerce/units/order_items/order_items_tag_processor.php	(revision 15165)
+++ in-commerce/units/order_items/order_items_tag_processor.php	(working copy)
@@ -78,7 +78,7 @@
 		$options = $item_data['Options'];
 		foreach ($options as $opt => $val) {
 			if ( !is_array($val) ) {
-				$val = kUtil::unhtmlentities($val);
+				$val = htmlspecialchars_decode($val);
 			}
 			$key_data = $opt_helper->ConvertKey($opt, $object->GetDBField('ProductId'));
 
@@ -175,7 +175,7 @@
 		$i = 0;
 		foreach ($values as $val) {
 			$i++;
-			$val = kUtil::unhtmlentities($val);
+			$val = htmlspecialchars_decode($val);
 			$block_params['value'] = htmlspecialchars($val);
 			if ($price_types[$val] == '$') {
 				$iso = $this->GetISO($params['currency']);
Index: in-commerce/units/orders/order_calculator.php
===================================================================
--- in-commerce/units/orders/order_calculator.php	(revision 15165)
+++ in-commerce/units/orders/order_calculator.php	(working copy)
@@ -576,7 +576,7 @@
 
 		protected function formatPrice($a_val, $price, $parsed)
 		{
-			$a_val = kUtil::unhtmlentities($a_val);
+			$a_val = htmlspecialchars_decode($a_val);
 
 			$addition = 0;
 			$conv_prices = $parsed['Prices'];
Index: in-commerce/units/product_options/product_options_tag_processor.php
===================================================================
--- in-commerce/units/product_options/product_options_tag_processor.php	(revision 15165)
+++ in-commerce/units/product_options/product_options_tag_processor.php	(working copy)
@@ -108,7 +108,7 @@
 					$selected = is_array($option_value) && in_array(htmlspecialchars($val), $option_value);
 				}
 				else { // radio buttons ?
-					$selected = kUtil::unhtmlentities($option_value) == $val;
+					$selected = htmlspecialchars_decode($option_value) == $val;
 				}
 			}
 
Index: in-news/units/articles/articles_event_handler.php
===================================================================
--- in-news/units/articles/articles_event_handler.php	(revision 15245)
+++ in-news/units/articles/articles_event_handler.php	(working copy)
@@ -333,7 +333,7 @@
 					break;
 
 				case 'html':
-					$data = kUtil::unhtmlentities( $node->GetXML(true) ); // $node->firstChild->Data // $node->Data
+					$data = htmlspecialchars_decode( $node->GetXML(true) ); // $node->firstChild->Data // $node->Data
 					break;
 
 				default: