In-Portal Issue Tracker

Index: units/reviews/reviews_event_handler.php
===================================================================
--- units/reviews/reviews_event_handler.php	(revision 15111)
+++ units/reviews/reviews_event_handler.php	(working copy)
@@ -424,30 +424,40 @@
 		 */
 		function updateSubitemCounters(&$event)
 		{
+			if ( $event->Special == '-item' ) {
+				// ignore Main Item Copy/Pasting and Deleting
+				return;
+			}
+
+			$object =& $event->getObject();
+			/* @var $object kDBItem */
+
 			$parent_prefix = $this->Application->getUnitOption($event->Prefix, 'ParentPrefix');
-			$main_object =& $this->Application->recallObject($parent_prefix, null, Array ('raise_warnings' => 0));
-			/* @var $main_object kCatDBItem */
+			$parent_table = $this->Application->getUnitOption($parent_prefix, 'TableName');
 
-			if (!$main_object->isLoaded()) {
-				// deleting main item / cloning main item
-				return ;
+			if ( $object->IsTempTable() ) {
+				$parent_table = $this->Application->GetTempName($parent_table, 'prefix:' . $object->Prefix);
 			}
 
-			$object =& $event->getObject(); // for temp tables
-			/* @var $object kDBItem */
+			$fields_hash = Array ('CachedReviewsQty' => 0, 'CachedRating' => 0, 'CachedVotesQty' => 0);
 
 			// 1. update review counter
 			$sql = 'SELECT COUNT(ReviewId)
-					FROM '.$object->TableName.'
-					WHERE ItemId = '.$main_object->GetDBField('ResourceId');
-			$review_count = $this->Conn->GetOne($sql);
-			$main_object->SetDBField('CachedReviewsQty', $review_count);
+					FROM ' . $object->TableName . '
+					WHERE ItemId = ' . $object->GetDBField('ItemId');
+			$fields_hash['CachedReviewsQty'] = $this->Conn->GetOne($sql);
 
 			// 2. update votes counter + rating
 			$rating = $object->GetDBField('Rating');
-			$avg_rating = $main_object->GetDBField('CachedRating');
-			$votes_count = $main_object->GetDBField('CachedVotesQty');
 
+			$sql = 'SELECT CachedRating, CachedVotesQty
+					FROM ' . $parent_table . '
+					WHERE ResourceId = ' . $object->GetDBField('ItemId');
+			$parent_data = $this->Conn->GetRow($sql);
+
+			$avg_rating = $parent_data['CachedRating'];
+			$votes_count = $parent_data['CachedVotesQty'];
+
 			switch ($event->Name) {
 				case 'OnAfterItemCreate': // adding new review with rating
 					$this->changeRating($avg_rating, $votes_count, $rating, '+');
@@ -462,9 +472,11 @@
 					$this->changeRating($avg_rating, $votes_count, $rating, '+');
 					break;
 			}
-			$main_object->SetDBField('CachedRating', "$avg_rating"); // covert $avg_rating value to string
-			$main_object->SetDBField('CachedVotesQty', $votes_count);
-			$main_object->Update();
+
+			$fields_hash['CachedRating'] = "$avg_rating";
+			$fields_hash['CachedVotesQty'] = $votes_count;
+
+			$this->Conn->doUpdate($fields_hash, $parent_table, 'ResourceId = ' . $object->GetDBField('ItemId'));
 		}
 
 		/**
@@ -477,16 +489,21 @@
 		 */
 		function changeRating(&$avg_rating, &$votes_count, $rating, $operation)
 		{
-			if ($rating < 1 || $rating > 5) {
-				return ;
+			if ( $rating < 1 || $rating > 5 ) {
+				return;
 			}
 
-			if ($operation == '+') {
+			if ( $operation == '+' ) {
 				$avg_rating = (($avg_rating * $votes_count) + $rating) / ($votes_count + 1);
 				++$votes_count;
 			}
 			else {
-				$avg_rating = (($avg_rating * $votes_count) - $rating) / ($votes_count - 1);
+				if ( $votes_count > 1 ) { // escape division by 0
+					$avg_rating = (($avg_rating * $votes_count) - $rating) / ($votes_count - 1);
+				}
+				else {
+					$avg_rating = (($avg_rating * $votes_count) - $rating) / 1;
+				}
 				--$votes_count;
 			}
 		}

Index: in-bulletin/install/upgrades.sql
===================================================================
--- in-bulletin/install/upgrades.sql	(revision 15111)
+++ in-bulletin/install/upgrades.sql	(working copy)
@@ -251,3 +251,7 @@
 
 DELETE FROM SystemSettings
 WHERE VariableName IN ('Topic_Highlight_OpenTag', 'Topic_Highlight_CloseTag', 'Posts_NewDays');
+
+# ===== v 5.2.0-B2 =====
+UPDATE Topic main_table
+SET main_table.CachedReviewsQty = (SELECT COUNT(*) FROM <%TABLE_PREFIX%>CatalogReviews review_table WHERE review_table.ItemId = main_table.ResourceId);
Index: in-commerce/install/upgrades.sql
===================================================================
--- in-commerce/install/upgrades.sql	(revision 15111)
+++ in-commerce/install/upgrades.sql	(working copy)
@@ -259,3 +259,7 @@
 );
 
 INSERT INTO SystemSettings VALUES(DEFAULT, 'MaxCompareProducts', '3', 'In-Commerce', 'in-commerce:output', 'la_Text_Products', 'la_config_MaxCompareProducts', 'text', NULL, NULL, 10.12, 0, 1, NULL);
+
+# ===== v 5.2.0-B2 =====
+UPDATE Products main_table
+SET main_table.CachedReviewsQty = (SELECT COUNT(*) FROM <%TABLE_PREFIX%>CatalogReviews review_table WHERE review_table.ItemId = main_table.ResourceId);
Index: in-link/install/upgrades.sql
===================================================================
--- in-link/install/upgrades.sql	(revision 15111)
+++ in-link/install/upgrades.sql	(working copy)
@@ -183,3 +183,7 @@
 UPDATE SearchConfig
 SET ForeignField = 'Users.Username'
 WHERE ForeignField = 'PortalUser.Username' AND ModuleName = 'In-Link';
+
+# ===== v 5.2.0-B2 =====
+UPDATE Link main_table
+SET main_table.CachedReviewsQty = (SELECT COUNT(*) FROM <%TABLE_PREFIX%>CatalogReviews review_table WHERE review_table.ItemId = main_table.ResourceId);
Index: in-news/install/upgrades.sql
===================================================================
--- in-news/install/upgrades.sql	(revision 15111)
+++ in-news/install/upgrades.sql	(working copy)
@@ -124,3 +124,7 @@
 # ===== v 5.2.0-B1 =====
 DELETE FROM SystemSettings
 WHERE VariableName IN ('News_Highlight_OpenTag', 'News_Highlight_CloseTag');
+
+# ===== v 5.2.0-B2 =====
+UPDATE News main_table
+SET main_table.CachedReviewsQty = (SELECT COUNT(*) FROM <%TABLE_PREFIX%>CatalogReviews review_table WHERE review_table.ItemId = main_table.ResourceId);