In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001167 [In-Portal CMS] Optimization task always 2011-11-13 17:07 2012-07-25 05:30
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-B1
Status closed Product Version 5.1.0 Target Version 5.2.0
Time EstimateNo estimate
Summary 0001167: Improvements in Compressed CSS/JS File Naming
Description Starting with In-Portal 5.1.0 new feature was introduced. This feature allows to merge all js/css files on the page into one file and then compress it. This allows to significantly enhance website loading time.

While feature works well in general there is a problem though: old versions of compressed files are never deleted.

Currently filename is generated by following scheme:
<d¦c>_<filenames_crc>_<timestamp>.<css¦js>

This way new file is created every time developer forces a recompression procedure by pressing "refresh" button in themes list in admin console.

I'm proposing to move timestamp part away from filename part into that file's url parameters. We actually could just use file modification time from file system instead of keeping it in 2 places, like now.

For example url "http://www.website.tld/system/cache/c_1253243_544433445.css" becomes "http://www.website.tld/system/cache/c_1253243.css?ts=544433445".

This way we always use the same file and just change it's url, so web browser would read it from server and not from it's cache.
Additional Information NOTES:

1. please add ability to pass param "save_as='somename'" so it can be more readble name if needed.

2. ts=544433445 should be replaced with real date/time so it's easy to see if file is new or outdated.

Example: http://www.website.tld/system/cache/c_generalstyles.css?ts=2011-12-02_12:21:12

where 20111202 is date stamp and is 122112 time stamp (15hours-21min-12sec).
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-dev/aELuW-LC9ZQ/discussion
Change Log Message improved compressed css/js file naming
Estimate Points 2
Attached Files patch file icon disk_friendly_js_css_compression.patch [^] (6,302 bytes) 2011-12-02 04:52 [Show Content]
patch file icon friendly_url_for_compressed_js_css_addon.patch [^] (574 bytes) 2011-12-07 06:22 [Show Content]
patch file icon empty_compression_file_list_fix.patch [^] (711 bytes) 2011-12-30 11:03 [Show Content]
patch file icon disk_friendly_compression_513.patch [^] (8,737 bytes) 2012-05-29 16:18 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0000040closed (Icebox)Dmitry Issues with JavaScript and CSS Caching 
related to 0001177closed (5.2.0)alex Debug version of CSS/JS files (decompressed) loaded even after Debug is Disabled via Cookies 
child of 0000457closed (5.1.0)!COMMUNITY Automatic CSS / JS Compression 

-  Notes
User avatar (0004189)
Dmitry (manager)
2011-12-01 20:52

Please see additional notes added.
User avatar (0004191)
alex (manager)
2011-12-02 04:53

Will test all together later.
User avatar (0004192)
alex (manager)
2011-12-02 04:55

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001167: Improvements in Compressed CSS/JS File Naming
User avatar (0004210)
Dmitry (manager)
2011-12-06 14:02

Please implement Human readable time format for "TS" as discussed in the groups.

Example: http://www.website.tld/system/cache/c_generalstyles.css?ts=20111202-182112
User avatar (0004211)
alex (manager)
2011-12-07 06:23

Will test all together later.
User avatar (0004212)
alex (manager)
2011-12-07 06:23

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001167: Improvements in Compressed CSS/JS File Naming
1. compressed file url format changed
User avatar (0004880)
alex (manager)
2012-07-25 05:30

Since 5.2.0/1.2.0 versions was released.

- Related Changesets
In-Portal CMS: 5.2.x r14966
Timestamp: 2011-12-30 11:04:23
Author: alex
Details ] Diff ]
Bug 0001167: Improvements in Compressed CSS/JS File Naming
1. fixes case with empty file list
mod - /in-portal/branches/5.2.x/core/units/helpers/minifiers/minify_helper.php Diff ] File ]
In-Portal CMS: 5.2.x r14836
Timestamp: 2011-12-07 06:23:41
Author: alex
Details ] Diff ]
Fixes 0001167: Improvements in Compressed CSS/JS File Naming
1. compressed file url format changed
mod - /in-portal/branches/5.2.x/core/units/helpers/minifiers/minify_helper.php Diff ] File ]
In-Portal CMS: 5.2.x r14818
Timestamp: 2011-12-02 04:55:36
Author: alex
Details ] Diff ]
Fixes 0001167: Improvements in Compressed CSS/JS File Naming
mod - /in-portal/branches/5.2.x/core/units/helpers/minifiers/minify_helper.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:30 alex Note Added: 0004880
2012-07-25 05:30 alex Status resolved => closed
2012-05-29 16:18 alex File Added: disk_friendly_compression_513.patch
2011-12-30 11:04 alex Changeset attached 5.2.x r14966
2011-12-30 11:03 alex File Added: empty_compression_file_list_fix.patch
2011-12-08 03:46 alex Relationship added related to 0001177
2011-12-07 06:23 alex Note Added: 0004212
2011-12-07 06:23 alex Status reviewed and tested => resolved
2011-12-07 06:23 alex Assigned To !COMMUNITY => alex
2011-12-07 06:23 alex Changeset attached 5.2.x r14836
2011-12-07 06:23 alex Note Added: 0004211
2011-12-07 06:23 alex Status needs testing => reviewed and tested
2011-12-07 06:22 alex Assigned To alex => !COMMUNITY
2011-12-07 06:22 alex Status needs work => needs testing
2011-12-07 06:22 alex File Added: friendly_url_for_compressed_js_css_addon.patch
2011-12-06 15:31 alex Additional Information Updated View Revisions
2011-12-06 14:02 Dmitry Note Added: 0004210
2011-12-06 14:02 Dmitry Status resolved => needs work
2011-12-02 04:55 alex Note Added: 0004192
2011-12-02 04:55 alex Status reviewed and tested => resolved
2011-12-02 04:55 alex Fixed in Version => 5.2.0-B1
2011-12-02 04:55 alex Resolution open => fixed
2011-12-02 04:55 alex Assigned To !COMMUNITY => alex
2011-12-02 04:55 alex Changeset attached 5.2.x r14818
2011-12-02 04:53 alex Note Added: 0004191
2011-12-02 04:53 alex Status needs testing => reviewed and tested
2011-12-02 04:53 alex Assigned To => !COMMUNITY
2011-12-02 04:53 alex Developer => alex
2011-12-02 04:53 alex Status active => needs testing
2011-12-02 04:52 alex Additional Information Updated View Revisions
2011-12-02 04:52 alex File Added: disk_friendly_js_css_compression.patch
2011-12-01 20:52 Dmitry Note Added: 0004189
2011-12-01 20:52 Dmitry Additional Information Updated View Revisions
2011-11-14 05:07 alex Reference [/url] => [url]https://groups.google.com/d/topic/in-portal-dev/aELuW-LC9ZQ/discussion
2011-11-13 17:09 Dmitry Relationship added related to 0000040
2011-11-13 17:08 Dmitry Relationship added child of 0000457
2011-11-13 17:07 Dmitry New Issue
2011-11-13 17:07 Dmitry Reference => [url][/url]
2011-11-13 17:07 Dmitry Change Log Message => improved compressed css/js file naming
2011-11-13 17:07 Dmitry Estimate Points => 2



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker