In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001146

[In-Portal CMS] Front End

bug report

always

2011-10-17 08:19

2012-07-25 05:32

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0-B1

Status

closed

Product Version

5.1.0

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001146: Tag "st_CachedMenu" sets incorrect "template" parameter to menu elements (v 5.1.0)

Description

Below is the code, that could be to display website menu top level:

<inp2:m_DefineElement name="menu_element">
    <a href="<inp2:m_Link template='$template' m_cat_id='$cat_id' use_section='$use_section'/>">
        <inp2:m_Param name="title"/>
    </a>
</inp2:m_DefineElement>

<inp2:st_CachedMenu render_as="menu_element" category_id="1"/>

This code works before and after In-Portal 5.1.0 version. Problem arises, when developer tries to use "template" parameter directly without passing it to m_Link tag.

For example here the result of <inp2:m_Param name="template"/> tag before & after In-Portal 5.1.0 release:
before 5.1.0 release: "path/to/template"
after 5.1.0 release: "id:434" (434 is ID of a section, that is displayed in menu)

Attached patch restored pre 5.1.0 behavior related to "template" parameter value.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/jMXBiBoEH-0/discussion

Change Log Message

Fixes parameter "template" value within element rendered in st_CachedMenu tag

Estimate Points

0

cachedmenu_tag_pass_template_instead_of_its_id.patch [^] (653 bytes) 2011-10-17 08:19 [Show Content]

Index: menu_helper.php
===================================================================
--- menu_helper.php	(revision 14504)
+++ menu_helper.php	(working copy)
@@ -222,6 +222,11 @@
 				$active = $page['ItemPath'] == preg_replace('/^Content\//i', '', $this->Application->GetVar('t'));
 			}*/
 
+			if ( substr($page['ItemPath'], 0, 3) == 'id:' ) {
+				// resolve ID path here, since it can be used directly without m_Link tag (that usually resolves it)
+				$page['ItemPath'] = $this->Application->structureTemplateMapping[ $page['ItemPath'] ];
+			}
+
 			$block_params = Array (
 				'title' => $title,
 				'template' => $page['ItemPath'],

cachedmenu_tag_pass_template_instead_of_its_id_520.patch [^] (702 bytes) 2011-12-27 03:26 [Show Content]

Index: units/helpers/menu_helper.php
===================================================================
--- units/helpers/menu_helper.php	(revision 14888)
+++ units/helpers/menu_helper.php	(working copy)
@@ -231,6 +231,11 @@
 				$active = $page['ItemPath'] == preg_replace('/^Content\//i', '', $this->Application->GetVar('t'));
 			}*/
 
+			if ( substr($page['ItemPath'], 0, 3) == 'id:' ) {
+				// resolve ID path here, since it can be used directly without m_Link tag (that usually resolves it)
+				$page['ItemPath'] = $this->Application->getVirtualPageTemplate(substr($page['ItemPath'], 3));
+			}
+
 			$block_params = Array (
 				'title' => $title,
 				'template' => $page['ItemPath'],

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0004315) Dmitry (manager) 2011-12-23 14:56	Reviewed and tested, please commit to 5.2.0

(0004318) alex (manager) 2011-12-27 03:27	Fix committed to 5.2.x branch. Commit Message: Fixes 0001146: Tag "st_CachedMenu" sets incorrect "template" parameter to menu elements

(0005017) alex (manager) 2012-07-25 05:32	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14915 Timestamp: 2011-12-27 03:27:37 Author: alex [ Details ] [ Diff ]	Fixes 0001146: Tag "st_CachedMenu" sets incorrect "template" parameter to menu elements
	mod - /in-portal/branches/5.2.x/core/units/helpers/menu_helper.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:32	alex	Note Added: 0005017
2012-07-25 05:32	alex	Status	resolved => closed
2011-12-27 03:27	alex	Note Added: 0004318
2011-12-27 03:27	alex	Status	reviewed and tested => resolved
2011-12-27 03:27	alex	Fixed in Version	=> 5.2.0-B1
2011-12-27 03:27	alex	Resolution	open => fixed
2011-12-27 03:27	alex	Changeset attached	5.2.x r14915
2011-12-27 03:26	alex	File Added: cachedmenu_tag_pass_template_instead_of_its_id_520.patch
2011-12-23 14:56	Dmitry	Note Added: 0004315
2011-12-23 14:56	Dmitry	Assigned To	!COMMUNITY => alex
2011-12-23 14:56	Dmitry	Status	needs testing => reviewed and tested
2011-12-23 10:43	Dmitry	Estimate Points	=> 0
2011-12-23 10:43	Dmitry	Target Version	5.1.4 => 5.2.0
2011-10-17 08:22	alex	Assigned To	=> !COMMUNITY
2011-10-17 08:22	alex	Developer	=> alex
2011-10-17 08:22	alex	Status	active => needs testing
2011-10-17 08:22	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/jMXBiBoEH-0/discussion
2011-10-17 08:20	alex	Description Updated	View Revisions
2011-10-17 08:19	alex	New Issue
2011-10-17 08:19	alex	File Added: cachedmenu_tag_pass_template_instead_of_its_id.patch
2011-10-17 08:19	alex	Change Log Message	=> Fixes parameter "template" value within element rendered in st_CachedMenu tag

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group