In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001089

[In-Portal CMS] Front End

bug report

always

2011-08-08 10:06

2011-09-19 16:08

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.3

Status

closed

Product Version

5.1.3-RC1

Target Version

5.1.3

Time Estimate

No estimate

Summary

0001089: Long text is clipped in the middle of the word

Description

I have no any URL to give an example, but In-Portal has text clipping function, that allows any db field value to be clipped to a given length. For example not to break page layout by inserting very long text.

Here is how to use it:

<inp2:prefix_Field name="FieldName" cut_first="145"/>

This will return first 145 symbols of given field value. In case, when there is a middle of a word at 145th symbol, then word would be broken, e.g. "this is example of broken spl ...".

I'm attaching a patch, that would do same, but also will keep word integrity, like this: "this is example of broken ...".

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/0Z7lsjwK7ok/discussion

Change Log Message

Fixed text shortening algorithm when first_chars/cut_first parameter is used in Field tag

Estimate Points

0

wordbreak_safe_text_stripping.patch [^] (611 bytes) 2011-08-08 10:06 [Show Content]

Index: db_tag_processor.php
===================================================================
--- db_tag_processor.php	(revision 14472)
+++ db_tag_processor.php	(working copy)
@@ -884,8 +884,8 @@
 		if ($first_chars) {
 			$stripped_value = strip_tags($value, $this->SelectParam($params, 'allowed_tags'));
 
-			if (mb_strlen($stripped_value) > $first_chars) {
-				$value = mb_substr($stripped_value, 0, $first_chars) . ' ...';
+			if ( mb_strlen($stripped_value) > $first_chars ) {
+				$value = preg_replace('/\s+?(\S+)?$/', '', mb_substr($stripped_value, 0, $first_chars + 1)) . ' ...';
 			}
 		}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003724) Dmitry (manager) 2011-09-07 18:07	Moved to 5.1.3. Patch tested good, please commit.

(0003742) alex (manager) 2011-09-16 09:22	Fix committed to 5.1.x branch. Commit Message: Fixes 0001089: Long text is clipped in the middle of the word

(0003781) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14520 Timestamp: 2011-09-16 09:22:39 Author: alex [ Details ] [ Diff ]	Fixes 0001089: Long text is clipped in the middle of the word
	mod - /in-portal/branches/5.1.x/core/kernel/db/db_tag_processor.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003781
2011-09-19 16:08	alex	Status	resolved => closed
2011-09-16 09:22	alex	Note Added: 0003742
2011-09-16 09:22	alex	Status	reviewed and tested => resolved
2011-09-16 09:22	alex	Fixed in Version	=> 5.1.3
2011-09-16 09:22	alex	Resolution	open => fixed
2011-09-16 09:22	alex	Assigned To	!COMMUNITY => alex
2011-09-16 09:22	alex	Changeset attached	5.1.x r14520
2011-09-07 18:07	Dmitry	Note Added: 0003724
2011-09-07 18:07	Dmitry	Status	needs testing => reviewed and tested
2011-09-07 18:07	Dmitry	Target Version	Icebox => 5.1.3
2011-08-08 10:06	alex	Assigned To	=> !COMMUNITY
2011-08-08 10:06	alex	Developer	=> alex
2011-08-08 10:06	alex	Status	active => needs testing
2011-08-08 10:06	alex	New Issue
2011-08-08 10:06	alex	File Added: wordbreak_safe_text_stripping.patch
2011-08-08 10:06	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/0Z7lsjwK7ok/discussion
2011-08-08 10:06	alex	Change Log Message	=> Fixed text shortening algorithm when first_chars/cut_first parameter is used in Field tag

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group