In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001057 [In-Portal CMS] Front End bug report always 2011-05-21 07:01 2011-09-19 16:08
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.3-B2
Status closed Product Version 5.1.2 Target Version 5.1.3
Time EstimateNo estimate
Summary 0001057: Translating missing phrases in debug mode
Description In-Portal has ability to translate missing phrases on Front-End directly, without going to Admin Console. This feature is done specially for developers, who use Debug Mode.

This functionality was temporary unavailable (from In-Portal 5.0.0 to In-Portal 5.0.2 versions), but it was fixed in 0000451 task and is working since In-Portal 5.0.3.

However during major translation system refactoring in 0000285 task some strange thing happend to it:
1. go to any page where with a non-translated phrase
2. click on translation link -> will go to phrases_edit.tpl template
3. enter translation
4. click "Create" button -> will stay on same page and not return to page, where non-translated phrase was present
Additional Information
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-bugs/w2XJ6XMCFrs/discussion
Change Log Message Fixes redirect during phrase translation in debug mode
Estimate Points 0
Attached Files patch file icon debug_phrase_translation_frontend_core.patch [^] (1,467 bytes) 2011-05-21 07:01 [Show Content]
patch file icon debug_phrase_translation_frontend_advanced_theme.patch [^] (1,634 bytes) 2011-05-21 07:01 [Show Content]
patch file icon debug_phrase_translation_frontend_core_addon.patch [^] (1,757 bytes) 2011-05-29 03:52 [Show Content]
patch file icon debug_phrase_translation_frontend_advanced_theme_addon.patch [^] (2,618 bytes) 2011-05-29 03:52 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0000221closed (5.0.1)alex Final Changes in "Browse Modes" 
child of 0000285closed (5.1.0)alex Translation system refactoring 

-  Notes
User avatar (0003454)
alex (manager)
2011-05-21 07:04

Place <inp2:m_Phrase name="lu_hint_Test"/> tag on any Front-end template. Then go to that template in web browser and click on translation link (debug mode should be enabled).

After performing translation you should return to template where you clicked on a missing phrase.
User avatar (0003455)
alex (manager)
2011-05-21 07:06

Moving to 5.1.3, since it's every day use functionality and really slows down development, when not fixed.
User avatar (0003459)
Dmitry (manager)
2011-05-22 01:19

Reviewed and tested ok, please commit
User avatar (0003480)
alex (manager)
2011-05-23 02:39

Fix committed to 5.1.x branch. Commit Message:

Fixes 0001057: Translating missing phrases in debug mode
User avatar (0003508)
alex (manager)
2011-05-29 03:52

While using this functionality I've noticed that there is a problem, when site have 2+ languages.

When you already have translated a phrase in primary language and then you switch Front-end language to other language (where this phrase isn't translated), then problem stays:
1. after translating phrase you stay on same phrase editing template
2. phrase translation is initially set to primary language translation, however it should be empty
User avatar (0003509)
alex (manager)
2011-05-29 03:53

Please apply 2 *_addon.patch patches to test.
User avatar (0003553)
Dmitry (manager)
2011-06-26 22:56

Tested okay - great work! Please commit!
User avatar (0003562)
alex (manager)
2011-06-27 02:58

Fix committed to 5.1.x branch. Commit Message:

Fixes 0001057: Translating missing phrases in debug mode
User avatar (0003827)
alex (manager)
2011-09-19 16:08

Closing, since 5.1.3 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r14390
Timestamp: 2011-06-27 02:58:18
Author: alex
Details ] Diff ]
Fixes 0001057: Translating missing phrases in debug mode
mod - /in-portal/branches/5.1.x/core/units/phrases/phrases_event_handler.php Diff ] File ]
Themes :: Advanced: 1.1.x r14389
Timestamp: 2011-06-27 02:57:15
Author: alex
Details ] Diff ]
Bug 0001057: Translating missing phrases in debug mode
mod - /themes/advanced/branches/1.1.x/phrases_edit.tpl Diff ] File ]
mod - /themes/advanced/branches/1.1.x/platform/elements/forms.elm.tpl Diff ] File ]
In-Portal CMS: 5.1.x r14338
Timestamp: 2011-05-23 02:39:43
Author: alex
Details ] Diff ]
Fixes 0001057: Translating missing phrases in debug mode
mod - /in-portal/branches/5.1.x/core/kernel/languages/phrases_cache.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/phrases/phrases_event_handler.php Diff ] File ]
Themes :: Advanced: 1.1.x r14337
Timestamp: 2011-05-23 02:38:34
Author: alex
Details ] Diff ]
Bug 0001057: Translating missing phrases in debug mode
mod - /themes/advanced/branches/1.1.x/phrases_edit.tpl Diff ] File ]

- Issue History
Date Modified Username Field Change
2011-09-19 16:08 alex Note Added: 0003827
2011-09-19 16:08 alex Status resolved => closed
2011-06-27 02:58 alex Note Added: 0003562
2011-06-27 02:58 alex Status reviewed and tested => resolved
2011-06-27 02:58 alex Fixed in Version => 5.1.3-B2
2011-06-27 02:58 alex Assigned To !COMMUNITY => alex
2011-06-27 02:58 alex Changeset attached 5.1.x r14390
2011-06-27 02:57 alex Changeset attached 1.1.x r14389
2011-06-26 22:56 Dmitry Note Added: 0003553
2011-06-26 22:56 Dmitry Status needs testing => reviewed and tested
2011-06-19 21:35 Dmitry Fixed in Version 5.1.3-B1 =>
2011-05-29 03:53 alex Note Added: 0003509
2011-05-29 03:53 alex Assigned To alex => !COMMUNITY
2011-05-29 03:53 alex Status needs work => needs testing
2011-05-29 03:52 alex File Added: debug_phrase_translation_frontend_advanced_theme_addon.patch
2011-05-29 03:52 alex File Added: debug_phrase_translation_frontend_core_addon.patch
2011-05-29 03:52 alex Note Added: 0003508
2011-05-29 03:52 alex Status resolved => needs work
2011-05-23 02:39 alex Note Added: 0003480
2011-05-23 02:39 alex Status reviewed and tested => resolved
2011-05-23 02:39 alex Fixed in Version => 5.1.3-B1
2011-05-23 02:39 alex Resolution open => fixed
2011-05-23 02:39 alex Changeset attached 5.1.x r14338
2011-05-23 02:38 alex Changeset attached 1.1.x r14337
2011-05-22 01:19 Dmitry Note Added: 0003459
2011-05-22 01:19 Dmitry Assigned To !COMMUNITY => alex
2011-05-22 01:19 Dmitry Status needs testing => reviewed and tested
2011-05-21 07:06 alex Note Added: 0003455
2011-05-21 07:06 alex Target Version Icebox => 5.1.3
2011-05-21 07:05 alex Note Added: 0003454
2011-05-21 07:05 alex Assigned To => !COMMUNITY
2011-05-21 07:05 alex Developer => alex
2011-05-21 07:05 alex Status active => needs testing
2011-05-21 07:03 alex Reference => https://groups.google.com/d/topic/in-portal-bugs/w2XJ6XMCFrs/discussion
2011-05-21 07:02 alex Relationship added related to 0000221
2011-05-21 07:02 alex Relationship added child of 0000285
2011-05-21 07:01 alex File Added: debug_phrase_translation_frontend_advanced_theme.patch
2011-05-21 07:01 alex New Issue
2011-05-21 07:01 alex File Added: debug_phrase_translation_frontend_core.patch
2011-05-21 07:01 alex Change Log Message => Fixes redirect during phrase translation in debug mode



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker