In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001054

[In-Portal CMS] Data Management

bug report

always

2011-05-20 05:57

2011-09-19 16:08

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.3-RC1

Status

closed

Product Version

5.1.2

Target Version

5.1.3

Time Estimate

No estimate

Summary

0001054: There is php warning on each product update

Description

In default installation no check is made to detect changed fields of a product before saving it to a database.

However, when I added it my product in OnBeforeItemUpdate method, then I received a warning, that MoreCategories field is missing in a product. Of course it's missing, since there are not product suggest form anywhere to populate/create that MoreCategories field.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/Hj1oxdL8viM/discussion

Change Log Message

Fixes warning about missing MoreCategories field

Estimate Points

0

warning_on_each_product_update.patch [^] (901 bytes) 2011-05-20 05:57 [Show Content]

Index: cat_event_handler.php
===================================================================
--- cat_event_handler.php	(revision 14239)
+++ cat_event_handler.php	(working copy)
@@ -955,9 +955,11 @@
 
 		$file_helper->LoadItemFiles($object);
 
-		// set item's additional categories to virtual field (used in editing)
-		$item_categories = $this->getItemCategories($object->GetDBField('ResourceId'));
-		$object->SetDBField('MoreCategories', $item_categories ? '|'.implode('|', $item_categories).'|' : '');
+		if ( array_key_exists('MoreCategories', $object->VirtualFields) ) {
+			// set item's additional categories to virtual field (used in editing)
+			$item_categories = $this->getItemCategories($object->GetDBField('ResourceId'));
+			$object->SetDBField('MoreCategories', $item_categories ? '|'.implode('|', $item_categories).'|' : '');
+		}
 	}
 
 	function OnAfterItemUpdate(&$event)

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003500) Dmitry (manager) 2011-05-23 08:07	Tested good, please move to 5.1.3 and commit.

(0003607) alex (manager) 2011-07-08 05:11	Fix committed to 5.1.x branch. Commit Message: Fixes 0001054: There is php warning on each product update

(0003811) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14443 Timestamp: 2011-07-08 05:11:10 Author: alex [ Details ] [ Diff ]	Fixes 0001054: There is php warning on each product update
	mod - /in-portal/branches/5.1.x/core/kernel/db/cat_event_handler.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003811
2011-09-19 16:08	alex	Status	resolved => closed
2011-07-08 05:11	alex	Note Added: 0003607
2011-07-08 05:11	alex	Status	reviewed and tested => resolved
2011-07-08 05:11	alex	Fixed in Version	=> 5.1.3-RC1
2011-07-08 05:11	alex	Resolution	open => fixed
2011-07-08 05:11	alex	Changeset attached	5.1.x r14443
2011-07-08 05:10	alex	Project	In-Commerce => In-Portal CMS
2011-07-07 10:02	Dmitry	Target Version	Icebox => 5.1.3
2011-05-23 08:07	Dmitry	Note Added: 0003500
2011-05-23 08:07	Dmitry	Assigned To	Dmitry => alex
2011-05-23 08:07	Dmitry	Status	needs testing => reviewed and tested
2011-05-20 05:58	alex	Assigned To	=> Dmitry
2011-05-20 05:58	alex	Developer	=> alex
2011-05-20 05:58	alex	Status	active => needs testing
2011-05-20 05:58	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/Hj1oxdL8viM/discussion
2011-05-20 05:57	alex	New Issue
2011-05-20 05:57	alex	File Added: warning_on_each_product_update.patch
2011-05-20 05:57	alex	Change Log Message	=> Fixes warning about missing MoreCategories field

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group