In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001009

[In-Portal CMS] Mailing System

bug report

always

2011-03-04 10:41

2011-03-30 09:53

Reporter

gleb

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.2-RC1

Status

closed

Product Version

5.1.0-RC1

Target Version

5.1.2

Time Estimate

No estimate

Summary

0001009: Issue in kMainTagProcessor::AttachFile method related to attaching files

Description

Reported on behalf Erik.

Issue in kMainTagProcessor::AttachFile method related to attaching files in main_processor.php file.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/a9f72wEHkjY/discussion

Change Log Message

Estimate Points

0

AttachFile_function.patch [^] (565 bytes) 2011-03-04 10:41 [Show Content]

Index: main_processor.php
===================================================================
--- main_processor.php	(revision 14238)
+++ main_processor.php	(working copy)
@@ -1001,7 +1001,7 @@
 	 */
 	function AttachFile($params)
 	{
-		$esender =& $application->recallObject('EmailSender'.(isset($params['special']) ? '.'.$params['special'] : ''));
+		$esender =& $this->Application->recallObject('EmailSender'.(isset($params['special']) ? '.'.$params['special'] : ''));
 		/* @var $esender kEmailSendingHelper */
 
 		$path = FULL_PATH.'/'.$params['path'];

m_attachfile_tag_fix_v2.patch [^] (802 bytes) 2011-03-22 04:27 [Show Content]

Index: kernel/processors/main_processor.php
===================================================================
--- kernel/processors/main_processor.php	(revision 14260)
+++ kernel/processors/main_processor.php	(working copy)
@@ -966,11 +966,13 @@
 	 */
 	function AttachFile($params)
 	{
-		$esender =& $application->recallObject('EmailSender'.(isset($params['special']) ? '.'.$params['special'] : ''));
+		$path = FULL_PATH . '/' . $params['path'];
+		$pseudo = isset($params['special']) ? 'EmailSender.' . $params['special'] : 'EmailSender';
+
+		$esender =& $this->Application->recallObject($pseudo);
 		/* @var $esender kEmailSendingHelper */
 
-		$path = FULL_PATH.'/'.$params['path'];
-		if (file_exists($path)) {
+		if ( file_exists($path) ) {
 			$esender->AddAttachment($path);
 		}
 	}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003286) Dmitry (manager) 2011-03-04 11:11	Tested good!

(0003304) alex (manager) 2011-03-22 04:28	Wasn't able to apply attached patch, so I've created new one "m_attachfile_tag_fix_v2.patch" against 5.1.x branch.

(0003305) alex (manager) 2011-03-22 04:28	Fix committed to 5.1.x branch. Commit Message: Fixes 0001009: Issue in kMainTagProcessor::AttachFile method related to attaching files

(0003316) Dmitry (manager) 2011-03-30 09:53	Closing, since 5.1.2 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14264 Timestamp: 2011-03-22 04:28:37 Author: alex [ Details ] [ Diff ]	Fixes 0001009: Issue in kMainTagProcessor::AttachFile method related to attaching files
	mod - /in-portal/branches/5.1.x/core/kernel/processors/main_processor.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-03-30 09:53	Dmitry	Note Added: 0003316
2011-03-30 09:53	Dmitry	Status	resolved => closed
2011-03-22 04:28	alex	Note Added: 0003305
2011-03-22 04:28	alex	Status	reviewed and tested => resolved
2011-03-22 04:28	alex	Fixed in Version	=> 5.1.2-RC1
2011-03-22 04:28	alex	Resolution	open => fixed
2011-03-22 04:28	alex	Changeset attached	5.1.x r14264
2011-03-22 04:28	alex	Note Added: 0003304
2011-03-22 04:27	alex	File Added: m_attachfile_tag_fix_v2.patch
2011-03-04 11:11	Dmitry	Note Added: 0003286
2011-03-04 11:11	Dmitry	Assigned To	!COMMUNITY => alex
2011-03-04 11:11	Dmitry	Status	needs testing => reviewed and tested
2011-03-04 11:10	Dmitry	Target Version	=> 5.1.2
2011-03-04 10:43	gleb	Assigned To	=> !COMMUNITY
2011-03-04 10:43	gleb	Developer	=> gleb
2011-03-04 10:43	gleb	Status	active => needs testing
2011-03-04 10:41	gleb	New Issue
2011-03-04 10:41	gleb	File Added: AttachFile_function.patch
2011-03-04 10:41	gleb	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/a9f72wEHkjY/discussion

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group