In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-dev/browse_thread/thread/2b9d1ec963542bf8

Change Log Message

Added System cleanup and DB optimizzation

Estimate Points

Attached Files

optimize_performance_939.patch [^] (1,962 bytes) 2011-10-05 07:51 [Show Content]

Index: admin_config.php
===================================================================
--- admin_config.php	(revision 14636)
+++ admin_config.php	(working copy)
@@ -24,6 +24,10 @@
 			1 => 'event',
 		),
 
+		'RegularEvents' => Array(
+			'optimize_performance' => Array('EventName' => 'OnOptimizePerformance', 'RunInterval' => 86400, 'Type' => reAFTER),
+		),
+
 		'TitlePresets' => Array (
 			'tree_root'		=>	Array ('format' => '!la_section_overview!'),
 
Index: admin_events_handler.php
===================================================================
--- admin_events_handler.php	(revision 14636)
+++ admin_events_handler.php	(working copy)
@@ -1384,6 +1384,53 @@
 			$event->status = kEvent::erFAIL;
 		}
 	}
+
+	/**
+	 * 1. Delete all Debug files from system/.restricted folder	(format debug_@977827436@.txt)
+	 * 2. Run MySQL OPTIMIZE SQL one by one on all In-Portal tables (found by prefix).
+	 *
+	 * @param kEvent $event
+	 */
+	function OnOptimizePerformance(&$event)
+	{
+		$start_time = adodb_mktime();
+		$active_sessions = array_flip(
+			$this->Conn->GetCol('SELECT SessionKey
+				FROM ' . TABLE_PREFIX. 'UserSession
+				WHERE LastAccessed > ' . adodb_mktime()
+			)
+		);
+
+		$files = scandir(RESTRICTED);
+		$file_path = RESTRICTED.'/';
+		foreach ($files AS $file_name) {
+
+			if (!preg_match('#^debug_@([0-9]{9})@.txt$#', $file_name, $matches)) {
+				// not debug file
+				continue;
+			}
+
+			$sid = $matches[1];
+
+			if (isset($active_sessions[$sid])) {
+				// debug file belongs to an active session
+				continue;
+			}
+
+			if (filemtime($file_path.$file_name) > $start_time) {
+				// debug file is recently created (after sessions snapshot)
+				continue;
+			}
+
+			@unlink($file_path.$file_name);
+		}
+
+		$system_tables = $this->Conn->GetCol('SHOW TABLES LIKE "'.TABLE_PREFIX.'%"');
+
+		foreach ($system_tables AS $table_name) {
+			$this->Conn->Query('OPTIMIZE TABLE '.$table_name);
+		}
+	}
 }

optimize_performance_939.2.patch [^] (1,953 bytes) 2011-10-05 10:06 [Show Content]

Index: admin_config.php
===================================================================
--- admin_config.php	(revision 14636)
+++ admin_config.php	(working copy)
@@ -24,6 +24,10 @@
 			1 => 'event',
 		),
 
+		'RegularEvents' => Array(
+			'optimize_performance' => Array('EventName' => 'OnOptimizePerformance', 'RunInterval' => 86400, 'Type' => reAFTER),
+		),
+
 		'TitlePresets' => Array (
 			'tree_root'		=>	Array ('format' => '!la_section_overview!'),
 
Index: admin_events_handler.php
===================================================================
--- admin_events_handler.php	(revision 14636)
+++ admin_events_handler.php	(working copy)
@@ -1384,6 +1384,49 @@
 			$event->status = kEvent::erFAIL;
 		}
 	}
+
+	/**
+	 * 1. Delete all Debug files from system/.restricted folder	(format debug_@977827436@.txt)
+	 * 2. Run MySQL OPTIMIZE SQL one by one on all In-Portal tables (found by prefix).
+	 *
+	 * @param kEvent $event
+	 */
+	function OnOptimizePerformance(&$event)
+	{
+		$start_time = adodb_mktime();
+		$sql = 'SELECT SessionKey FROM ' . TABLE_PREFIX . 'UserSession WHERE LastAccessed > ' . $start_time;
+		$active_sessions = array_flip( $this->Conn->GetCol($sql) );
+
+		$files = scandir(RESTRICTED);
+		$file_path = RESTRICTED.'/';
+
+		foreach ($files AS $file_name) {
+			if (!preg_match('#^debug_@([0-9]{9})@.txt$#', $file_name, $matches)) {
+				// not debug file
+				continue;
+			}
+
+			$sid = $matches[1];
+
+			if (isset($active_sessions[$sid])) {
+				// debug file belongs to an active session
+				continue;
+			}
+
+			if (filemtime($file_path.$file_name) > $start_time) {
+				// debug file is recently created (after sessions snapshot)
+				continue;
+			}
+
+			unlink($file_path.$file_name);
+		}
+
+		$system_tables = $this->Conn->GetCol('SHOW TABLES LIKE "'.TABLE_PREFIX.'%"');
+
+		foreach ($system_tables AS $table_name) {
+			$this->Conn->Query('OPTIMIZE TABLE '.$table_name);
+		}
+	}
 }

optimize_performance_agent_v3.patch [^] (2,103 bytes) 2011-10-05 10:41 [Show Content]

Index: units/admin/admin_config.php
===================================================================
--- units/admin/admin_config.php	(revision 14590)
+++ units/admin/admin_config.php	(working copy)
@@ -24,6 +24,10 @@
 			1 => 'event',
 		),
 
+		'RegularEvents' => Array(
+			'optimize_performance' => Array('EventName' => 'OnOptimizePerformance', 'RunInterval' => 86400, 'Type' => reAFTER),
+		),
+
 		'TitlePresets' => Array (
 			'tree_root'		=>	Array ('format' => '!la_section_overview!'),
 
Index: units/admin/admin_events_handler.php
===================================================================
--- units/admin/admin_events_handler.php	(revision 14637)
+++ units/admin/admin_events_handler.php	(working copy)
@@ -1404,6 +1404,51 @@
 			$event->SetRedirectParam('action_completed', 1);
 		}
 	}
+
+	/**
+	 * [AGENT]
+	 * 1. Delete all Debug files from system/.restricted folder	(format debug_@977827436@.txt)
+	 * 2. Run MySQL OPTIMIZE SQL one by one on all In-Portal tables (found by prefix).
+	 *
+	 * @param kEvent $event
+	 * @return void
+	 * @access protected
+	 */
+	protected function OnOptimizePerformance(&$event)
+	{
+		$start_time = adodb_mktime();
+
+		$sql = 'SELECT SessionKey
+				FROM ' . TABLE_PREFIX . 'UserSession
+				WHERE LastAccessed > ' . $start_time;
+		$active_sessions = array_flip($this->Conn->GetCol($sql));
+
+		$files = scandir(RESTRICTED);
+		$file_path = RESTRICTED . '/';
+
+		foreach ($files AS $file_name) {
+			if ( !preg_match('#^debug_@([0-9]{9})@.txt$#', $file_name, $matches) ) {
+				// not debug file
+				continue;
+			}
+
+			$sid = $matches[1];
+
+			if ( isset($active_sessions[$sid]) || (filemtime($file_path . $file_name) > $start_time ) ) {
+				// debug file belongs to an active session
+				// debug file is recently created (after sessions snapshot)
+				continue;
+			}
+
+			unlink($file_path . $file_name);
+		}
+
+		$system_tables = $this->Conn->GetCol('SHOW TABLES LIKE "' . TABLE_PREFIX . '%"');
+
+		foreach ($system_tables AS $table_name) {
+			$this->Conn->Query('OPTIMIZE TABLE ' . $table_name);
+		}
+	}
 }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003910) alex (manager) 2011-09-26 04:47	Really needed stuff. I have a lot of debugger reports.

(0004018) erik (manager) 2011-10-05 07:52	patch attached - needs testing

(0004025) alex (manager) 2011-10-05 09:28	1. please assign sql to a temporary variable (e.g. $sql) and then pass such variable to $this->Conn object method; sql should be properly formatted. 2. Remove "@" symbol before php function calls, since it could hide important error (e.g. that incorrect permissions are set to /system/restricted folder). 3. No empty line needed after opening brace of "foreach" statement, but the one is needed before "foreach" statement. ---- Interesting idea to check for debugger reports, that were created after agent start.

(0004026) erik (manager) 2011-10-05 10:06	optimize_performance_939.2.patch attached - needs testing

(0004029) alex (manager) 2011-10-05 10:41	Fix committed to 5.2.x branch. Commit Message: Fixes 0000939: New Agent to perform System Cleanup and Optimize Performance Commit on behalf of Erik

(0005109) alex (manager) 2012-07-25 05:33	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14642 Timestamp: 2011-10-05 10:41:37 Author: alex [ Details ] [ Diff ]	Fixes 0000939: New Agent to perform System Cleanup and Optimize Performance Commit on behalf of Erik
	mod - /in-portal/branches/5.2.x/core/units/admin/admin_config.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/units/admin/admin_events_handler.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:33	alex	Note Added: 0005109
2012-07-25 05:33	alex	Status	resolved => closed
2011-10-22 05:30	alex	Estimate Points	=> 1
2011-10-05 10:41	alex	Changeset attached	5.2.x r14642
2011-10-05 10:41	alex	Note Added: 0004029
2011-10-05 10:41	alex	Status	reviewed and tested => resolved
2011-10-05 10:41	alex	Fixed in Version	=> 5.2.0-B1
2011-10-05 10:41	alex	Resolution	open => fixed
2011-10-05 10:41	alex	Assigned To	!COMMUNITY => alex
2011-10-05 10:41	alex	Assigned To	alex => !COMMUNITY
2011-10-05 10:41	alex	Status	needs testing => reviewed and tested
2011-10-05 10:41	alex	File Added: optimize_performance_agent_v3.patch
2011-10-05 10:06	erik	Note Added: 0004026
2011-10-05 10:06	erik	Assigned To	erik => alex
2011-10-05 10:06	erik	Status	needs work => needs testing
2011-10-05 10:06	erik	File Added: optimize_performance_939.2.patch
2011-10-05 09:28	alex	Note Added: 0004025
2011-10-05 09:28	alex	Assigned To	alex => erik
2011-10-05 09:28	alex	Status	needs testing => needs work
2011-10-05 07:52	erik	Time Estimate Removed	1 =>
2011-10-05 07:52	erik	Note Added: 0004018
2011-10-05 07:52	erik	Assigned To	erik => alex
2011-10-05 07:52	erik	Developer	=> erik
2011-10-05 07:52	erik	Status	needs work => needs testing
2011-10-05 07:51	erik	File Added: optimize_performance_939.patch
2011-10-05 02:14	alex	Description Updated	View Revisions
2011-10-05 02:14	alex	Additional Information Updated	View Revisions
2011-10-04 21:03	Dmitry	Assigned To	=> erik
2011-10-04 21:03	Dmitry	Status	active => needs work
2011-09-26 04:47	alex	Time Estimate Added	1
2011-09-26 04:47	alex	Note Added: 0003910
2011-09-23 21:27	Dmitry	Target Version	Icebox => 5.2.0
2010-11-30 12:34	Dmitry	Change Log Message	=> Added System cleanup and DB optimizzation
2010-11-30 12:23	Dmitry	Type	task => feature request
2010-11-30 12:23	Dmitry	New Issue
2010-11-30 12:23	Dmitry	Reference	=> http://groups.google.com/group/in-portal-dev/browse_thread/thread/2b9d1ec963542bf8

Web Development by Intechnic

In-Portal Open Source CMS