In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000928 [In-Portal CMS] Admin Interfaces bug report always 2010-11-18 13:44 2011-03-30 09:53
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.2-B1
Status closed Product Version 5.1.1-RC1 Target Version 5.1.2
Time EstimateNo estimate
Summary 0000928: Remove forced sorting for Catalog Items in Admin
Description We need to remove ANY forced sorting (to the top) in Admin for Catalog Items.

Currently it's impossible to sort by Ids or other fields when Editors' Pick column forced to the top plus the Priority field.
Additional Information
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-bugs/browse_thread/thread/c031349b294d44c0
Change Log Message Removed forced sorting for Catalog Items in Admin
Estimate Points 0
Attached Files patch file icon Remove-forcing-EditorsPick-sorting-Admin.patch [^] (1,186 bytes) 2010-11-18 13:44 [Show Content]
patch file icon Remove-forcing-sorting-Admin-CORE.patch [^] (2,966 bytes) 2010-11-18 14:51 [Show Content]
patch file icon Remove-forcing-sorting-Admin-MODULES.patch [^] (5,020 bytes) 2010-11-18 14:51 [Show Content]
patch file icon Remove-forcing-sorting-Admin-CORE-v2.patch [^] (2,443 bytes) 2010-11-20 15:18 [Show Content]
patch file icon Remove-forcing-sorting-Admin-MODULES-v2.patch [^] (6,422 bytes) 2010-11-20 15:18 [Show Content]
patch file icon Remove-forcing-sorting-Admin-CORE-v3.patch [^] (2,634 bytes) 2010-11-21 04:31 [Show Content]
patch file icon Remove-forcing-sorting-Admin-MODULES-v3.patch [^] (10,001 bytes) 2010-11-21 04:31 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0000931closed (5.1.1)alex Category item sorting not displayed in Admin Console 

-  Notes
User avatar (0002977)
alex (manager)
2010-11-18 14:04

Task is not about just removing Editor's Pick sorting. It's about admin user inability to fully control sorting in admin grids.

Also "Priority" column sorting bothers, since admin can't override it's effects.
User avatar (0002978)
Dmitry (manager)
2010-11-18 14:51

Please test again.
User avatar (0002983)
alex (manager)
2010-11-20 04:47

You've changed a bit too much. Now you even removed default front-end sorting, that admin user can control.

You should:
* initially keep Priority and EditorsPick sorting in unit config
* in OnAfterConfigRead:
** remove EditorsPick sorting (via "unset"), when config option disabled (both admin and front-end)
** remove Priority storting, when in admin

Don't code random code. You should always have "why?" question answer for every code line you created.
User avatar (0002984)
Dmitry (manager)
2010-11-20 15:19

Thanks for your comments. Please review this one!

Note that I am removing both Priority and Editors pick for Admin.
User avatar (0002985)
alex (manager)
2010-11-21 04:33

Patch "Remove-forcing-sorting-Admin-CORE-v3.patch" moves sorting code to new method.

Patch "Remove-forcing-sorting-Admin-MODULES-v3.patch" adds Priority column also to "Radio" grids and adds "CreatedOn" column to article list, since without it sorting mark wasn't displayed at all.
User avatar (0002986)
alex (manager)
2010-11-21 04:33

Tested with few minor adjustments. New patches uploaded.
User avatar (0003186)
alex (manager)
2011-01-09 08:56

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000928: Remove forced sorting for Catalog Items in Admin
User avatar (0003345)
Dmitry (manager)
2011-03-30 09:53

Closing, since 5.1.2 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r14140
Timestamp: 2011-01-09 08:56:21
Author: alex
Details ] Diff ]
Fixes 0000928: Remove forced sorting for Catalog Items in Admin
mod - /in-portal/branches/5.1.x/core/kernel/db/cat_event_handler.php Diff ] File ]
Modules :: In-News: 5.1.x r14139
Timestamp: 2011-01-09 08:55:45
Author: alex
Details ] Diff ]
Bug 0000928: Remove forced sorting for Catalog Items in Admin
mod - /modules/in-news/branches/5.1.x/units/articles/articles_config.php Diff ] File ]
Modules :: In-Link: 5.1.x r14138
Timestamp: 2011-01-09 08:55:24
Author: alex
Details ] Diff ]
Bug 0000928: Remove forced sorting for Catalog Items in Admin
mod - /modules/in-link/branches/5.1.x/units/links/links_config.php Diff ] File ]
Modules :: In-Commerce: 5.1.x r14137
Timestamp: 2011-01-09 08:55:11
Author: alex
Details ] Diff ]
Bug 0000928: Remove forced sorting for Catalog Items in Admin
mod - /w/in-commerce/branches/5.1.x/units/products/products_config.php Diff ] File ]
Modules :: In-Bulletin: 5.1.x r14136
Timestamp: 2011-01-09 08:54:26
Author: alex
Details ] Diff ]
Bug 0000928: Remove forced sorting for Catalog Items in Admin
mod - /modules/in-bulletin/branches/5.1.x/units/topics/topics_config.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2011-03-30 09:53 Dmitry Note Added: 0003345
2011-03-30 09:53 Dmitry Status resolved => closed
2011-01-09 08:56 alex Note Added: 0003186
2011-01-09 08:56 alex Status reviewed and tested => resolved
2011-01-09 08:56 alex Fixed in Version => 5.1.2-B1
2011-01-09 08:56 alex Resolution open => fixed
2011-01-09 08:56 alex Assigned To !COMMUNITY => alex
2011-01-09 08:56 alex Changeset attached 5.1.x r14140
2011-01-09 08:55 alex Changeset attached 5.1.x r14139
2011-01-09 08:55 alex Changeset attached 5.1.x r14138
2011-01-09 08:55 alex Changeset attached 5.1.x r14137
2011-01-09 08:54 alex Changeset attached 5.1.x r14136
2010-11-21 04:43 alex Relationship added related to 0000931
2010-11-21 04:33 alex Note Added: 0002986
2010-11-21 04:33 alex Assigned To alex => !COMMUNITY
2010-11-21 04:33 alex Status needs testing => reviewed and tested
2010-11-21 04:33 alex Note Added: 0002985
2010-11-21 04:31 alex File Added: Remove-forcing-sorting-Admin-MODULES-v3.patch
2010-11-21 04:31 alex File Added: Remove-forcing-sorting-Admin-CORE-v3.patch
2010-11-20 15:19 Dmitry Note Added: 0002984
2010-11-20 15:19 Dmitry Assigned To !COMMUNITY => alex
2010-11-20 15:19 Dmitry Status needs work => needs testing
2010-11-20 15:18 Dmitry File Added: Remove-forcing-sorting-Admin-MODULES-v2.patch
2010-11-20 15:18 Dmitry File Added: Remove-forcing-sorting-Admin-CORE-v2.patch
2010-11-20 04:47 alex Note Added: 0002983
2010-11-20 04:47 alex Status needs testing => needs work
2010-11-18 14:51 Dmitry Note Added: 0002978
2010-11-18 14:51 Dmitry Status needs work => needs testing
2010-11-18 14:51 Dmitry File Added: Remove-forcing-sorting-Admin-MODULES.patch
2010-11-18 14:51 Dmitry File Added: Remove-forcing-sorting-Admin-CORE.patch
2010-11-18 14:50 Dmitry Change Log Message Removed forced sorting in Admin for Catalog items => Removed forced sorting for Catalog Items in Admin
2010-11-18 14:50 Dmitry Summary Remove forcing Editors Pick sorting in Admin for Catalog Items => Remove forced sorting for Catalog Items in Admin
2010-11-18 14:50 Dmitry Description Updated View Revisions
2010-11-18 14:04 alex Note Added: 0002977
2010-11-18 14:04 alex Status needs testing => needs work
2010-11-18 13:44 Dmitry Assigned To => !COMMUNITY
2010-11-18 13:44 Dmitry Developer => Dmitry
2010-11-18 13:44 Dmitry Status active => needs testing
2010-11-18 13:44 Dmitry New Issue
2010-11-18 13:44 Dmitry File Added: Remove-forcing-EditorsPick-sorting-Admin.patch
2010-11-18 13:44 Dmitry Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/c031349b294d44c0
2010-11-18 13:44 Dmitry Change Log Message => Removed forced sorting in Admin for Catalog items



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker