In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/4032a058c92f6c63

Change Log Message

Fixes Fatal error on Creating Coupon in Admin

Estimate Points

Attached Files

Fatal-Error-on-Creating-Coupon.patch [^] (10,137 bytes) 2010-11-01 11:44 [Show Content]

Index: units/coupon_items/coupon_items_config.php
===================================================================
--- units/coupon_items/coupon_items_config.php	(revision 14023)
+++ units/coupon_items/coupon_items_config.php	(working copy)
@@ -13,117 +13,140 @@
 
 	defined('FULL_PATH') or die('restricted access!');
 
-	$config =	Array(
-					'Prefix'			=>	'coupi',
-					'ItemClass'			=>	Array('class'=>'kDBItem','file'=>'','build_event'=>'OnItemBuild'),
-					'ListClass'			=>	Array('class'=>'kDBList','file'=>'','build_event'=>'OnListBuild'),
-					'EventHandlerClass'	=>	Array('class'=>'CouponItemsEventHandler','file'=>'coupon_items_event_handler.php','build_event'=>'OnBuild'),
-					'TagProcessorClass' =>	Array('class'=>'CouponItemsTagProcessor','file'=>'coupon_items_tag_processor.php','build_event'=>'OnBuild'),
-					'AutoLoad'			=>	true,
-					'Hooks'	=>	Array(
-												Array(
-													'Mode' => hAFTER,
-													'Conditional' => false,
-													'HookToPrefix' => 'p',
-													'HookToSpecial' => '-item',
-													'HookToEvent' => Array('OnAfterItemDelete'),
-													'DoPrefix' => '',
-													'DoSpecial' => '',
-													'DoEvent' => 'OnDeleteCouponItem',
-												),
-											),
-					'QueryString'		=>	Array(
-												1 => 'id',
-												2 => 'Page',
-												3 => 'PerPage',
-												4 => 'event',
-											),
-					'IDField'			=>	'CouponItemId',
-					'StatusField'		=>	Array('Status'),
-					'TitleField'		=>	'Name',
-					'TableName'			=>	TABLE_PREFIX.'ProductsCouponItems',
+	$config = Array(
+		'Prefix' => 'coupi',
+		'ItemClass' => Array('class' => 'kDBItem', 'file' => '', 'build_event' => 'OnItemBuild'),
+		'ListClass' => Array('class' => 'kDBList', 'file' => '', 'build_event' => 'OnListBuild'),
+		'EventHandlerClass' => Array('class' => 'CouponItemsEventHandler', 'file' => 'coupon_items_event_handler.php', 'build_event' => 'OnBuild'),
+		'TagProcessorClass' => Array('class' => 'CouponItemsTagProcessor', 'file' => 'coupon_items_tag_processor.php', 'build_event' => 'OnBuild'),
+		'AutoLoad' => true,
+	
+		'IDField' => 'CouponItemId',
+		'StatusField' => Array('Status'),
+		'TitleField' => 'Name',
+		'TableName' => TABLE_PREFIX . 'ProductsCouponItems',
+		
+		'ForeignKey' => 'CouponId',
+		'ParentTableKey' => 'CouponId',
+		'ParentPrefix' => 'coup',
+		'AutoDelete' => true,
+		'AutoClone' => true,
+	
+		'Hooks'	=> Array(
+			Array(
+				'Mode' => hAFTER,
+				'Conditional' => false,
+				'HookToPrefix' => 'p',
+				'HookToSpecial' => '-item',
+				'HookToEvent' => Array('OnAfterItemDelete'),
+				'DoPrefix' => '',
+				'DoSpecial' => '',
+				'DoEvent' => 'OnDeleteCouponItem',
+			),
+		),
+					
+		'QueryString' => Array(
+			1 => 'id',
+			2 => 'Page',
+			3 => 'PerPage',
+			4 => 'event',
+		),
+		
+		'ListSQLs' => Array(
+			'' => '	SELECT %1$s.* %2$s
+						FROM %1$s
+						LEFT JOIN ' . TABLE_PREFIX . 'Products p ON %1$s.ItemResourceId = p.ResourceId
+						LEFT JOIN ' . TABLE_PREFIX . 'Category c ON %1$s.ItemResourceId = c.ResourceId',
+			), // key - special, value - list select sql
+			
+		'ItemSQLs' => Array(
+			'' => 'SELECT * FROM %s',
+		),
 
-					'CalculatedFields'	=>	Array(
-												''	=>	Array(
-															'ProductId'		=>	'p.ProductId',
-															'ItemName'			=>	'IF(p.Name IS NULL,c.Name,p.l1_Name)',
-															'SKU'			=>	'p.SKU',
-															'Weight'		=>	'p.Weight',
-															'CreatedOn'		=>	'p.CreatedOn',
-															'BackOrderDate'	=>	'p.BackOrderDate',
-															'Status'		=>	'p.Status',
-															'CategoryId'	=>	'c.CategoryId',
+		/*'BelongsTo' => Array(
+			Array(
+				'prefix' => 'd', 'key' => 'DiscountId', 'ForeignKey' => 'DiscountId'),
+		),*/
+		
+		'ListSortings' => Array(
+			'' => Array(
+				'Sorting' => Array('ItemName' => 'asc'),
+			),
+		),
 
-														),
+		'Fields' => Array (
+			'CouponItemId' => Array('type' => 'int', 'not_null' => 1, 'default' => 0,),
+            'CouponId' => Array('type' => 'int', 'default' => null, ),
+            'ItemResourceId' => Array('type' => 'int', 'default' => null, ),
+            'ItemType' => Array(
+            	'type' => 'int',
+            	'formatter' => 'kOptionsFormatter',
+            	'options' => Array (1 => 'la_Product', 2 => 'la_Category', 0 => 'la_WholeOrder'),
+            	'default' => 1, 'not_null' => 1, 'use_phrases' => 1,
+			),
+		),
+		
+		'CalculatedFields' => Array(
+			'' => Array(
+				'ProductId' => 'p.ProductId',
+				'ItemName' => 'IF(p.Name IS NULL,c.Name,p.l1_Name)',
+				'SKU' => 'p.SKU',
+				'Weight' => 'p.Weight',
+				'CreatedOn' => 'p.CreatedOn',
+				'BackOrderDate' => 'p.BackOrderDate',
+				'Status' => 'p.Status',
+				'CategoryId' => 'c.CategoryId',
+			),
+		),
 
-											),
-					'ListSQLs'			=>	Array(	''=>'	SELECT %1$s.* %2$s
-															FROM %1$s
-															LEFT JOIN '.TABLE_PREFIX.'Products p ON %1$s.ItemResourceId = p.ResourceId
-															LEFT JOIN '.TABLE_PREFIX.'Category c ON %1$s.ItemResourceId = c.ResourceId',
-																		), // key - special, value - list select sql
-					'ItemSQLs'			=>	Array(	''=>'SELECT * FROM %s',
-																		),
+		'VirtualFields'	=> 	Array(
+			'ProductId' => Array('type' => 'int', 'default' => 0),
+			'ItemName' => Array('type' => 'string', 'default' => ''),
+			'SKU' => Array('type' => 'string', 'default' => ''),
+			'Weight' => Array(
+				'type' => 'float',
+				'formatter' => 'kFormatter', 'format' => '%0.2f',
+				'min_value_exc' => 0, 'default' => NULL,
+			),
+			'CreatedOn' => Array(
+				'type' => 'int',
+				'formatter' => 'kDateFormatter',
+				'default' => '#NOW#',
+			),
+			'BackOrderDate' => Array(
+				'type' => 'int',
+				'formatter' => 'kDateFormatter',
+				'default' => NULL,
+			),
+			'Status' =>	Array (
+		    	'type' => 'int',
+		    	'formatter' => 'kOptionsFormatter',
+		    	'options' => Array (1 => 'la_Active', 2 => 'la_Pending', 0 => 'la_Disabled'),
+		    	'use_phrases' => 1, 'default' => 2, 
+			),
+			'CategoryId' => Array ('type' => 'int', 'default' => 0),
+		),
 
-					/*'BelongsTo'			=> Array(
-												Array('prefix' => 'd', 'key' => 'DiscountId', 'ForeignKey' => 'DiscountId'),
-											),*/
-					'ForeignKey'	=>	'CouponId',
-					'ParentTableKey' => 'CouponId',
-					'ParentPrefix' => 'coup',
-					'AutoDelete'	=>	true,
-					'AutoClone'	=> true,
-
-					'ListSortings'	=> 	Array(
-												'' => Array(
-													'Sorting' => Array('ItemName' => 'asc'),
-												)
-											),
-
-					'Fields' => Array (
-						'CouponItemId' => Array('type' => 'int', 'not_null' => 1, 'default' => 0, ),
-			            'CouponId' => Array('type' => 'int', 'default' => null, ),
-			            'ItemResourceId' => Array('type' => 'int', 'default' => null, ),
-			            'ItemType' => Array('type' => 'int', 'not_null' => 1, 'formatter' => 'kOptionsFormatter', 'use_phrases' => 1, 'options' => Array ( 1 => 'la_Product', 2 => 'la_Category', 0 => 'la_WholeOrder' ), 'default' => 1, ),
-					),
-
-					'VirtualFields'	=> 	Array(
-													'ProductId' => Array('type' => 'int', 'default' => 0),
-													'ItemName' => Array('type' => 'string', 'default' => ''),
-													'SKU' => Array('type' => 'string', 'default' => ''),
-													'Weight' => Array('type'=>'float', 'min_value_exc'=>0, 'formatter' => 'kFormatter', 'format' => '%0.2f', 'default' => 0),
-													'CreatedOn' => Array('type' => 'int', 'formatter' => 'kDateFormatter', 'default' => '#NOW#'),
-													'BackOrderDate' => Array('type' => 'int', 'formatter' => 'kDateFormatter', 'default' => NULL),
-													'Status' =>	Array (
-												    	'type' => 'int',
-												    	'formatter' => 'kOptionsFormatter',
-												    	'options' => Array (1 => 'la_Active', 2 => 'la_Pending', 0 => 'la_Disabled'), 'use_phrases' => 1,
-												    	'default' => 2,
-													),
-													'CategoryId' => Array ('type' => 'int', 'default' => 0),
-												),
-
-					'Grids'	=> Array(
-								'Default'		=>	Array(
-																	'Icons' => Array('default'=>'icon16_entire_order.gif'),
-																	'Fields' => Array(
-																			'ItemType' => Array( 'title'=>'la_col_ItemType', 'data_block' => 'grid_checkbox_td', 'filter_block' => 'grid_empty_filter', 'width' => 200, ),
-																		),
-
-																),
-								'CouponItems'		=>	Array(
-									'Icons' => Array(
-										'default' => 'icon16_product.png',
-										0 => 'icon16_product_disabled.png',
-										1 => 'icon16_product.png',
-										2 => 'icon16_product_pending.png',
-									),
-																	'Fields' => Array(
-																			'ProductId' => Array( 'title'=>'la_col_Id', 'data_block' => 'grid_item_td', 'filter_block' => 'grid_range_filter', 'width' => 60, ),
-																			'ItemName' => Array( 'title'=>'la_col_ItemName', 'filter_block' => 'grid_like_filter', 'width' => 250, ),
-																			'ItemType' => Array( 'title'=>'la_col_CouponItemType', 'filter_block' => 'grid_options_filter', 'width' => 150, ),
-																		),
-
-																),
-													),
+		'Grids'	=> Array(
+			'Default' => Array(
+				'Icons' => Array('default'=>'icon16_entire_order.gif'),
+				'Fields' => Array(
+					'ItemType' => Array( 'title'=>'la_col_ItemType', 'data_block' => 'grid_checkbox_td', 'filter_block' => 'grid_empty_filter', 'width' => 200, ),
+				),
+			),
+			'CouponItems' => Array(
+				'Icons' => Array(
+					'default' => 'icon16_product.png',
+					0 => 'icon16_product_disabled.png',
+					1 => 'icon16_product.png',
+					2 => 'icon16_product_pending.png',
+				),
+				'Fields' => Array(
+					'ProductId' => Array( 'title'=>'la_col_Id', 'data_block' => 'grid_item_td', 'filter_block' => 'grid_range_filter', 'width' => 60, ),
+					'ItemName' => Array( 'title'=>'la_col_ItemName', 'filter_block' => 'grid_like_filter', 'width' => 250, ),
+					'ItemType' => Array( 'title'=>'la_col_CouponItemType', 'filter_block' => 'grid_options_filter', 'width' => 150, ),
+				),
+			),
+		),
+		
 	);
\ No newline at end of file

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	0000917	closed (5.1.1)	alex	In-Commerce	Fatal Error on Creating Discount and Affiliate Plan Items
child of	0000845	closed (5.1.1)	Dmitry	In-Portal CMS	Revising usage of NULL columns

Notes
(0002936) Dmitry (manager) 2010-11-01 11:45	Please test the patch: 1. Specified as Default NULL in Weight field. 2. Reworked the whole config so it complies with our Unit Config formatting rules.

(0002944) alex (manager) 2010-11-01 15:33 edited on: 2010-11-01 15:33	Tested, but you've made too aggressive changes to structure of changed unit config file. For example order of unit config options and order of field declaration options was changed a lot, so it even remotely wasn't matching common order, used in other unit configs and on http://guide.in-portal.org/eng/index.php/K4:%D0%9A%D0%BE%D0%BD%D1%84%D0%B8%D0%B3%D1%83%D1%80%D0%B0%D1%86%D0%B8%D0%BE%D0%BD%D0%BD%D1%8B%D0%B5_%D1%84%D0%B0%D0%B9%D0%BB%D1%8B page.

(0002945) alex (manager) 2010-11-01 15:34	Fix committed to 5.1.x branch. Commit Message: 1. Fixes 0000908: Fatal Error on Creating Coupon 2. Commit on behalf of Dmitry

(0003387) Dmitry (manager) 2011-03-30 09:58	Closing, since 5.1.1 release has been released.

Related Changesets
Modules :: In-Commerce: 5.1.x r14028 Timestamp: 2010-11-01 15:34:23 Author: alex [ Details ] [ Diff ]	1. Fixes 0000908: Fatal Error on Creating Coupon 2. Commit on behalf of Dmitry
	mod - /w/in-commerce/branches/5.1.x/units/coupon_items/coupon_items_config.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-03-30 09:58	Dmitry	Note Added: 0003387
2011-03-30 09:58	Dmitry	Status	resolved => closed
2010-11-02 14:15	Dmitry	Relationship added	related to 0000917
2010-11-02 14:05	Dmitry	Change Log Message	Fixes error Fatal error on Creating Coupon => Fixes Fatal error on Creating Coupon in Admin
2010-11-01 15:34	alex	Note Added: 0002945
2010-11-01 15:34	alex	Status	reviewed and tested => resolved
2010-11-01 15:34	alex	Fixed in Version	=> 5.1.1-RC1
2010-11-01 15:34	alex	Resolution	open => fixed
2010-11-01 15:34	alex	Assigned To	Dmitry => alex
2010-11-01 15:34	alex	Changeset attached	5.1.x r14028
2010-11-01 15:33	alex	Note Edited: 0002944	View Revisions
2010-11-01 15:33	alex	Note Edited: 0002944	View Revisions
2010-11-01 15:33	alex	Note Added: 0002944
2010-11-01 15:33	alex	Assigned To	alex => Dmitry
2010-11-01 15:33	alex	Status	needs testing => reviewed and tested
2010-11-01 11:45	Dmitry	Note Added: 0002936
2010-11-01 11:45	Dmitry	Assigned To	Dmitry => alex
2010-11-01 11:45	Dmitry	Developer	=> Dmitry
2010-11-01 11:45	Dmitry	Status	needs work => needs testing
2010-11-01 11:44	Dmitry	File Added: Fatal-Error-on-Creating-Coupon.patch
2010-10-28 10:38	Dmitry	Assigned To	=> Dmitry
2010-10-28 10:38	Dmitry	Status	active => needs work
2010-10-28 10:36	Dmitry	Relationship added	child of 0000845
2010-10-28 10:36	Dmitry	New Issue
2010-10-28 10:36	Dmitry	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/4032a058c92f6c63
2010-10-28 10:36	Dmitry	Change Log Message	=> Fixes error Fatal error on Creating Coupon

Web Development by Intechnic

In-Portal Open Source CMS