In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0000891

[In-Portal CMS] Caching System

bug report

always

2010-10-19 03:47

2010-11-30 12:48

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.1-B2

Status

closed

Product Version

5.1.1-B1

Target Version

5.1.1

Time Estimate

No estimate

Summary

0000891: Price of "Downloadable Product" is never saved, while Memcache is enabled

Description

Price of "Downloadable Product" is never saved, while Memcache is enabled.

All product types, except Tangible are using "Price" virtual field for saving and displaying price from primary price bracket of product.

When Memcache is enabled, then instead of getting value from database, that "Price" field is getting value from memory cache. Seems ok for now.

But, when you save new price, then value is changed in database, but not in memcache (since memcache values are only changed, when I finish product editing in temporary table and will press "Save" button). Since that never happens, while I browsing through that product in temporary table, then you will never see price you entered on that form.

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/717f85cfaea38d41

Change Log Message

Estimate Points

Attached Files

unable_to_set_downloadable_product_price_in_memcache.patch [^] (548 bytes) 2010-10-19 03:47 [Show Content]

Index: products_item.php
===================================================================
--- products_item.php	(revision 13936)
+++ products_item.php	(working copy)
@@ -43,7 +43,8 @@
 				$cache_key .= ':group=' . $primary_group;
 			}
 
-			$price_info = $this->Application->getCache($cache_key);
+			// don't cache, while in temp table
+			$price_info = $this->IsTempTable() ? false : $this->Application->getCache($cache_key);
 
 			if ($price_info === false) {
 				if (!$this->Application->isAdmin && $this->Application->LoggedIn()) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0002910) Dmitry (manager) 2010-10-19 11:38	Patch tested okay, please commit.

(0002916) alex (manager) 2010-10-19 14:17	Fix committed to 5.1.x branch. Commit Message: Fixes 0000891: Price of "Downloadable Product" is never saved, while Memcache is enabled

(0003011) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
Modules :: In-Commerce: 5.1.x r14003 Timestamp: 2010-10-19 14:17:53 Author: alex [ Details ] [ Diff ]	Fixes 0000891: Price of "Downloadable Product" is never saved, while Memcache is enabled
	mod - /w/in-commerce/branches/5.1.x/units/products/products_item.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003011
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-10-19 14:17	alex	Note Added: 0002916
2010-10-19 14:17	alex	Status	reviewed and tested => resolved
2010-10-19 14:17	alex	Fixed in Version	=> 5.1.1-B2
2010-10-19 14:17	alex	Resolution	open => fixed
2010-10-19 14:17	alex	Assigned To	!COMMUNITY => alex
2010-10-19 14:17	alex	Changeset attached	5.1.x r14003
2010-10-19 11:38	Dmitry	Note Added: 0002910
2010-10-19 11:38	Dmitry	Status	needs testing => reviewed and tested
2010-10-19 03:48	alex	Assigned To	=> !COMMUNITY
2010-10-19 03:48	alex	Developer	=> alex
2010-10-19 03:48	alex	Status	active => needs testing
2010-10-19 03:47	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/717f85cfaea38d41
2010-10-19 03:47	alex	New Issue
2010-10-19 03:47	alex	File Added: unable_to_set_downloadable_product_price_in_memcache.patch

Web Development by Intechnic

In-Portal Open Source CMS