In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000856 [In-Portal CMS] Data Management feature request N/A 2010-09-07 12:31 2012-07-25 05:33
Reporter BaSSiST View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-B1
Status closed Product Version 5.1.0 Target Version 5.2.0
Time EstimateNo estimate
Summary 0000856: Add PriorityEventHandler to Core
Description We have PriorityHelper in Core, but to have full priority functionality, developer also needs PriorityEventHandler, which currently is copied between projects.
Additional Information PriorityEventHandler allows to use more intuitive "Move Up"/"Move Down" functionality, which effectively cancels any other sorting, used in grid before.
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/bf986a48dc1eade5
Change Log Message Add Priority handler to Core
Estimate Points 2
Attached Files patch file icon priority_eh.patch [^] (10,721 bytes) 2010-09-07 12:31 [Show Content]
patch file icon priority_eh_v2.patch [^] (30,816 bytes) 2011-05-18 05:43 [Show Content]
patch file icon priority_eh_v3.patch [^] (30,659 bytes) 2011-05-26 03:15 [Show Content]
patch file icon priority_eh_v4.patch [^] (31,501 bytes) 2011-08-30 09:45 [Show Content]
patch file icon priority_eh_v4_520.patch [^] (34,737 bytes) 2011-10-03 09:47 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
parent of 0001241closed (5.2.0)alex Automatic redirect from ?env= urls to their mod-rewrite equivalents results in fatal error 
parent of 0001247closed (5.2.0)alex Sql error on priorities recalculation for list without parent constrain 

-  Notes
User avatar (0002788)
alex (manager)
2010-09-07 12:33

To test you need add unit config prefix (that already uses Move Up/Move Down functionality) to "priorities_config.php" (via OnAfterConfigRead hook of course).
User avatar (0003423)
alex (manager)
2011-05-18 05:45

New "priority_eh_v2.patch" has:
1. all constrain related functionality build-in into kPriorityHelper class
2. all priority processing moved away from CategoriesEventHandler class
3. categories are has central priority processing via PriorityEventHandler class
4. PriorityEventHandler class now has full support of constrains
User avatar (0003504)
alex (manager)
2011-05-26 03:16

Patch "priority_eh_v3.patch" fixes:
1. newly created category in empty parent category always was created with -2 instead of -1 priority.
User avatar (0003701)
alex (manager)
2011-08-30 09:46

Patch "priority_eh_v4.patch" fixes case, when "move up/move down" toolbar buttons were used in subitem grid in temp table. In such case live table was used instead of temp!
User avatar (0003738)
alex (manager)
2011-09-16 07:00

Remove:

if ( $object->IsTempTable() ) {
    $table_name = $this->Application->GetTempName($table_name, 'prefix:' . $object->Prefix);
}

from preparePriorities method in latest patch. Without this fix priorities dropdown on item editing will be build purely from temp table and that's bad.
User avatar (0003876)
Dmitry (manager)
2011-09-23 20:36

Needs to be implemented for 5.2.0 (PHP 5)
User avatar (0003968)
alex (manager)
2011-10-03 09:47

Will test all together.
User avatar (0003969)
alex (manager)
2011-10-03 09:48

Fix committed to 5.2.x branch. Commit Message:

Fixes 0000856: Add PriorityEventHandler to Core
User avatar (0005093)
alex (manager)
2012-07-25 05:33

Since 5.2.0 version was released.

- Related Changesets
In-Portal CMS: 5.2.x r14615
Timestamp: 2011-10-03 11:14:10
Author: alex
Details ] Diff ]
Bug 0000856: Add PriorityEventHandler to Core
1. fixed outdated constant name
mod - /in-portal/branches/5.2.x/core/units/priorites/priority_eh.php Diff ] File ]
In-Portal CMS: 5.2.x r14610
Timestamp: 2011-10-03 09:48:11
Author: alex
Details ] Diff ]
Fixes 0000856: Add PriorityEventHandler to Core
mod - /in-portal/branches/5.2.x/core/kernel/db/db_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/categories/categories_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/priority_helper.php Diff ] File ]
add - /in-portal/branches/5.2.x/core/units/priorites File ]
add - /in-portal/branches/5.2.x/core/units/priorites/priorites_config.php File ]
add - /in-portal/branches/5.2.x/core/units/priorites/priority_eh.php File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005093
2012-07-25 05:33 alex Status resolved => closed
2012-04-03 06:10 alex Relationship added parent of 0001247
2012-03-30 12:33 alex Relationship added parent of 0001241
2011-10-22 05:33 alex Estimate Points => 2
2011-10-03 11:14 alex Changeset attached 5.2.x r14615
2011-10-03 09:48 alex Note Added: 0003969
2011-10-03 09:48 alex Status reviewed and tested => resolved
2011-10-03 09:48 alex Fixed in Version => 5.2.0-B1
2011-10-03 09:48 alex Resolution open => fixed
2011-10-03 09:48 alex Assigned To !COMMUNITY => alex
2011-10-03 09:48 alex Changeset attached 5.2.x r14610
2011-10-03 09:47 alex Note Added: 0003968
2011-10-03 09:47 alex Status needs testing => reviewed and tested
2011-10-03 09:47 alex Time Estimate Removed 1 =>
2011-10-03 09:47 alex Status needs work => needs testing
2011-10-03 09:47 alex File Added: priority_eh_v4_520.patch
2011-09-26 04:55 alex Time Estimate Added 1
2011-09-23 20:36 Dmitry Change Log Message => Add Priority handler to Core
2011-09-23 20:36 Dmitry Note Added: 0003876
2011-09-23 20:36 Dmitry Status needs testing => needs work
2011-09-23 20:36 Dmitry Target Version Icebox => 5.2.0
2011-09-16 07:00 alex Note Added: 0003738
2011-08-30 10:24 alex Issue Monitored: alex
2011-08-30 09:46 alex Note Added: 0003701
2011-08-30 09:45 alex File Added: priority_eh_v4.patch
2011-05-26 03:16 alex Note Added: 0003504
2011-05-26 03:15 alex File Added: priority_eh_v3.patch
2011-05-18 05:45 alex Note Added: 0003423
2011-05-18 05:43 alex File Added: priority_eh_v2.patch
2010-09-07 12:33 alex Note Added: 0002788
2010-09-07 12:33 alex Assigned To => !COMMUNITY
2010-09-07 12:33 alex Developer => alex
2010-09-07 12:33 alex Status active => needs testing
2010-09-07 12:31 alex Reporter alex => BaSSiST
2010-09-07 12:31 alex New Issue
2010-09-07 12:31 alex File Added: priority_eh.patch
2010-09-07 12:31 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/bf986a48dc1eade5



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker